Skip to content

Commit 7d92438

Browse files
author
Paddy Carver
committed
Delete TODO
We're going to handle that by coercing those values when creating the Value, then we'll always have an internally consistent representation of the value within a Value and can just convert at the edges.
1 parent 1a9a8d8 commit 7d92438

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

tfprotov5/tftypes/value_msgpack.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ func marshalMsgPackString(val Value, typ Type, p AttributePath, enc *msgpack.Enc
8585
}
8686

8787
func marshalMsgPackNumber(val Value, typ Type, p AttributePath, enc *msgpack.Encoder) error {
88-
// TODO: can we accept other types besides *big.Float?
89-
// at the very least it would be nice to have built-in handling
90-
// for Go's int/float type variations
91-
//
92-
// once we build up the Value.As interface, we may be able to take
93-
// advantage of that...
9488
n, ok := val.value.(*big.Float)
9589
if !ok {
9690
return unexpectedValueTypeError(p, n, val.value, typ)

0 commit comments

Comments
 (0)