Implement unit tests (#32)

* Test marshaling msgpack.

Test that the bytes produced from msgpack marshaling match the bytes cty
produces for equivalent msgpack marshaling. This hardcodes the bytes so
we don't have a dependency on cty.

* Fix dynamic tests.

* Make tests parallel.

* Test behavior of Value.As.

Add tests that assert we get the results we expect for given inputs of
the tftypes.Value.As method.

* Add tests for encoding and decoding types with JSON.

Add a test that will decode JSON from a hard-coded string and assert
that the type that was parsed is correct, then will encode the type and
ensure that the generated JSON is correct.

* Test Value.IsKnown() and Value.IsFullyKnown()

* Test WalkAttributePath.

* Move msgpack tests to tfprotov5, implement parsing.

Move our msgpack encoding tests to the tfprotov5 package, which led to
some unfortunate exports needing to be added to the tftypes package,
mostly the ValueComparer function.

But this lets us quickly and easily reuse those tests in the tfprotov5
package to test that our parsing of msgpack values is correct. We now
mimic the cty tests incredibly closely.

* Add tests for parsing JSON from DynamicValues.

Author: Paddy

go.mod

@@ -4,9 +4,11 @@ go 1.14
 
 require (
 	github.com/golang/protobuf v1.4.2
+	github.com/google/go-cmp v0.5.2
 	github.com/hashicorp/go-hclog v0.0.0-20180709165350-ff2cf002a8dd
 	github.com/hashicorp/go-plugin v1.3.0
 	github.com/kr/pretty v0.1.0 // indirect
+	github.com/nsf/jsondiff v0.0.0-20200515183724-f29ed568f4ce
 	github.com/vmihailenco/msgpack v4.0.4+incompatible
 	golang.org/x/net v0.0.0-20200301022130-244492dfa37a // indirect
 	google.golang.org/appengine v1.6.5 // indirect

go.sum

@@ -28,6 +28,8 @@ github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
 github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
 github.com/google/go-cmp v0.4.0 h1:xsAVV57WRhGj6kEIi8ReJzQlHHqcBYCElAvkovg3B/4=
 github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
+github.com/google/go-cmp v0.5.2 h1:X2ev0eStA3AbceY54o37/0PQ/UWqKEiiO2dKL5OPaFM=
+github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/hashicorp/go-hclog v0.0.0-20180709165350-ff2cf002a8dd h1:rNuUHR+CvK1IS89MMtcF0EpcVMZtjKfPRp4MEmt/aTs=
 github.com/hashicorp/go-hclog v0.0.0-20180709165350-ff2cf002a8dd/go.mod h1:9bjs9uLqI8l75knNv3lV1kA55veR+WUPSiKIWcQHudI=
 github.com/hashicorp/go-plugin v1.3.0 h1:4d/wJojzvHV1I4i/rrjVaeuyxWrLzDE1mDCyDy8fXS8=
@@ -43,6 +45,8 @@ github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
 github.com/mitchellh/go-testing-interface v0.0.0-20171004221916-a61a99592b77 h1:7GoSOOW2jpsfkntVKaS2rAr1TJqfcxotyaUcuxoZSzg=
 github.com/mitchellh/go-testing-interface v0.0.0-20171004221916-a61a99592b77/go.mod h1:kRemZodwjscx+RGhAo8eIhFbs2+BFgRtFPeD/KE+zxI=
+github.com/nsf/jsondiff v0.0.0-20200515183724-f29ed568f4ce h1:RPclfga2SEJmgMmz2k+Mg7cowZ8yv4Trqw9UsJby758=
+github.com/nsf/jsondiff v0.0.0-20200515183724-f29ed568f4ce/go.mod h1:uFMI8w+ref4v2r9jz+c9i1IfIttS/OkmLfrk1jne5hs=
 github.com/oklog/run v1.0.0 h1:Ru7dDtJNOyC66gQ5dQmaCa0qIsAUFY3sFpK1Xk8igrw=
 github.com/oklog/run v1.0.0/go.mod h1:dlhp/R75TPv97u0XWUtDeV/lRKWPKSdTuV0TZvrmrQA=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=

tfprotov5/dynamic_value.go

@@ -27,8 +27,6 @@ var ErrUnknownDynamicValueType = errors.New("DynamicValue had no JSON or msgpack
 // Type of the Value, but it can also be the DynamicPseudoType.
 func NewDynamicValue(t tftypes.Type, v tftypes.Value) (DynamicValue, error) {
 	b, err := v.MarshalMsgPack(t) //nolint:staticcheck
-	//
-	// Deprecated: this is not meant to be called by third-party code.
 	if err != nil {
 		return DynamicValue{}, err
 	}

tfprotov5/dynamic_value_json.go

@@ -3,6 +3,8 @@ package tfprotov5
 import (
 	"bytes"
 	"encoding/json"
+	"math/big"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-go/tfprotov5/tftypes"
 )
@@ -63,8 +65,10 @@ func jsonUnmarshalString(buf []byte, typ tftypes.Type, p tftypes.AttributePath)
 	case json.Number:
 		return tftypes.NewValue(tftypes.String, string(v)), nil
 	case bool:
-		// TODO: convert boolean to a string
-		// not really sure why, but... compatibility!
+		if v {
+			return tftypes.NewValue(tftypes.String, "true"), nil
+		}
+		return tftypes.NewValue(tftypes.String, "false"), nil
 	}
 	return tftypes.Value{}, p.NewErrorf("unsupported type %T sent as %s", tok, tftypes.String)
 }
@@ -76,12 +80,21 @@ func jsonUnmarshalNumber(buf []byte, typ tftypes.Type, p tftypes.AttributePath)
 	if err != nil {
 		return tftypes.Value{}, p.NewErrorf("error reading token: %w", err)
 	}
-	numTok, ok := tok.(json.Number)
-	if !ok {
-		return tftypes.Value{}, p.NewErrorf("unsupported type %T sent as %s", tok, tftypes.Number)
+	switch numTok := tok.(type) {
+	case json.Number:
+		f, _, err := big.ParseFloat(string(numTok), 10, 512, big.ToNearestEven)
+		if err != nil {
+			return tftypes.Value{}, p.NewErrorf("error parsing number: %w", err)
+		}
+		return tftypes.NewValue(typ, f), nil
+	case string:
+		f, _, err := big.ParseFloat(string(numTok), 10, 512, big.ToNearestEven)
+		if err != nil {
+			return tftypes.Value{}, p.NewErrorf("error parsing number: %w", err)
+		}
+		return tftypes.NewValue(typ, f), nil
 	}
-	// TODO: convert numTok to big.Float
-	return tftypes.NewValue(typ, numTok), nil
+	return tftypes.Value{}, p.NewErrorf("unsupported type %T sent as %s", tok, tftypes.Number)
 }
 
 func jsonUnmarshalBool(buf []byte, typ tftypes.Type, p tftypes.AttributePath) (tftypes.Value, error) {
@@ -94,7 +107,25 @@ func jsonUnmarshalBool(buf []byte, typ tftypes.Type, p tftypes.AttributePath) (t
 	case bool:
 		return tftypes.NewValue(tftypes.Bool, v), nil
 	case string:
-		// TODO: convert string to boolean
+		switch v {
+		case "true", "1":
+			return tftypes.NewValue(tftypes.Bool, true), nil
+		case "false", "0":
+			return tftypes.NewValue(tftypes.Bool, false), nil
+		}
+		switch strings.ToLower(string(v)) {
+		case "true":
+			return tftypes.Value{}, p.NewErrorf("to convert from string, use lowercase \"true\"")
+		case "false":
+			return tftypes.Value{}, p.NewErrorf("to convert from string, use lowercase \"false\"")
+		}
+	case json.Number:
+		switch v {
+		case "1":
+			return tftypes.NewValue(tftypes.Bool, true), nil
+		case "0":
+			return tftypes.NewValue(tftypes.Bool, false), nil
+		}
 	}
 	return tftypes.Value{}, p.NewErrorf("unsupported type %T sent as %s", tok, tftypes.Bool)
 }
@@ -201,8 +232,16 @@ func jsonUnmarshalList(buf []byte, elementType tftypes.Type, p tftypes.Attribute
 	if tok != json.Delim(']') {
 		return tftypes.Value{}, p.NewErrorf("invalid JSON, expected %q, got %q", json.Delim(']'), tok)
 	}
+
+	elTyp := elementType
+	if elTyp == tftypes.DynamicPseudoType {
+		elTyp, err = tftypes.TypeFromElements(vals)
+		if err != nil {
+			return tftypes.Value{}, p.NewErrorf("invalid elements for list: %w", err)
+		}
+	}
 	return tftypes.NewValue(tftypes.List{
-		ElementType: elementType,
+		ElementType: elTyp,
 	}, vals), nil
 }
 
@@ -250,8 +289,16 @@ func jsonUnmarshalSet(buf []byte, elementType tftypes.Type, p tftypes.AttributeP
 	if tok != json.Delim(']') {
 		return tftypes.Value{}, p.NewErrorf("invalid JSON, expected %q, got %q", json.Delim(']'), tok)
 	}
+
+	elTyp := elementType
+	if elTyp == tftypes.DynamicPseudoType {
+		elTyp, err = tftypes.TypeFromElements(vals)
+		if err != nil {
+			return tftypes.Value{}, p.NewErrorf("invalid elements for list: %w", err)
+		}
+	}
 	return tftypes.NewValue(tftypes.Set{
-		ElementType: elementType,
+		ElementType: elTyp,
 	}, vals), nil
 }