tfprotov6: Resource Identity implementation (#476)

* add resource identity support to protocol v6
* add changie entries for this change and the ones that landed in #472 and #474
* Apply suggestions from code review
* fix comment typo
* fix lint

---------

Co-authored-by: Austin Valle <[email protected]>

Author: ansgarm

.changes/unreleased/FEATURES-20250210-175144.yaml

@@ -0,0 +1,5 @@
+kind: FEATURES
+body: 'tfprotov5+tfprotov6: Upgraded protocols and added types to support the new resource identity feature'
+time: 2025-02-10T17:51:44.461603+01:00
+custom:
+    Issue: "476"

.changes/unreleased/NOTES-20250210-175414.yaml

@@ -0,0 +1,5 @@
+kind: NOTES
+body: 'tfprotov5+tfprotov6: An upcoming release will require the `GetResourceIdentitySchemas` and `UpgradeResourceIdentity` implementations as part of `ProviderServer`.'
+time: 2025-02-10T17:54:14.054598+01:00
+custom:
+    Issue: "476"

tfprotov5/provider.go

@@ -177,7 +177,7 @@ type GetResourceIdentitySchemasRequest struct{}
 // GetResourceIdentitySchemasResponse represents a Terraform RPC response containing
 // the provider's resource identity schemas.
 type GetResourceIdentitySchemasResponse struct {
-	// ResourceSchemas is a map of resource names to the schema for the
+	// IdentitySchemas is a map of resource names to the schema for the
 	// identity specified for the resource. The name should be a
 	// resource name, and should be prefixed with your provider's shortname
 	// and an underscore. It should match the first label after `resource`

tfprotov6/internal/fromproto/provider.go

@@ -28,6 +28,16 @@ func GetProviderSchemaRequest(in *tfplugin6.GetProviderSchema_Request) *tfprotov
 	return resp
 }
 
+func GetResourceIdentitySchemasRequest(in *tfplugin6.GetResourceIdentitySchemas_Request) *tfprotov6.GetResourceIdentitySchemasRequest {
+	if in == nil {
+		return nil
+	}
+
+	resp := &tfprotov6.GetResourceIdentitySchemasRequest{}
+
+	return resp
+}
+
 func ValidateProviderConfigRequest(in *tfplugin6.ValidateProviderConfig_Request) *tfprotov6.ValidateProviderConfigRequest {
 	if in == nil {
 		return nil

tfprotov6/internal/fromproto/provider_test.go

@@ -72,6 +72,37 @@ func TestGetProviderSchemaRequest(t *testing.T) {
 	}
 }
 
+func TestGetResourceIdentitySchemasRequest(t *testing.T) {
+	t.Parallel()
+
+	testCases := map[string]struct {
+		in       *tfplugin6.GetResourceIdentitySchemas_Request
+		expected *tfprotov6.GetResourceIdentitySchemasRequest
+	}{
+		"nil": {
+			in:       nil,
+			expected: nil,
+		},
+		"zero": {
+			in:       &tfplugin6.GetResourceIdentitySchemas_Request{},
+			expected: &tfprotov6.GetResourceIdentitySchemasRequest{},
+		},
+	}
+
+	for name, testCase := range testCases {
+
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
+			got := fromproto.GetResourceIdentitySchemasRequest(testCase.in)
+
+			if diff := cmp.Diff(got, testCase.expected); diff != "" {
+				t.Errorf("unexpected difference: %s", diff)
+			}
+		})
+	}
+}
+
 func TestConfigureProviderRequest(t *testing.T) {
 	t.Parallel()
 

tfprotov6/internal/fromproto/raw_identity.go

@@ -0,0 +1,20 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package fromproto
+
+import (
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+)
+
+func RawIdentity(in []byte) *tfprotov6.RawIdentity {
+	if in == nil {
+		return nil
+	}
+
+	resp := &tfprotov6.RawIdentity{
+		JSON: in,
+	}
+
+	return resp
+}

tfprotov6/internal/fromproto/raw_identity_test.go

@@ -0,0 +1,18 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package fromproto_test
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+)
+
+func testTfprotov6RawIdentity(t *testing.T, json []byte) *tfprotov6.RawIdentity {
+	t.Helper()
+
+	return &tfprotov6.RawIdentity{
+		JSON: json,
+	}
+}

tfprotov6/internal/fromproto/resource.go

@@ -36,6 +36,20 @@ func UpgradeResourceStateRequest(in *tfplugin6.UpgradeResourceState_Request) *tf
 	return resp
 }
 
+func UpgradeResourceIdentityRequest(in *tfplugin6.UpgradeResourceIdentity_Request) *tfprotov6.UpgradeResourceIdentityRequest {
+	if in == nil {
+		return nil
+	}
+
+	resp := &tfprotov6.UpgradeResourceIdentityRequest{
+		RawIdentity: RawIdentity(in.RawIdentity),
+		TypeName:    in.TypeName,
+		Version:     in.Version,
+	}
+
+	return resp
+}
+
 func ReadResourceRequest(in *tfplugin6.ReadResource_Request) *tfprotov6.ReadResourceRequest {
 	if in == nil {
 		return nil
@@ -47,6 +61,7 @@ func ReadResourceRequest(in *tfplugin6.ReadResource_Request) *tfprotov6.ReadReso
 		ProviderMeta:       DynamicValue(in.ProviderMeta),
 		TypeName:           in.TypeName,
 		ClientCapabilities: ReadResourceClientCapabilities(in.ClientCapabilities),
+		CurrentIdentity:    ResourceIdentityData(in.CurrentIdentity),
 	}
 
 	return resp
@@ -65,6 +80,7 @@ func PlanResourceChangeRequest(in *tfplugin6.PlanResourceChange_Request) *tfprot
 		ProviderMeta:       DynamicValue(in.ProviderMeta),
 		TypeName:           in.TypeName,
 		ClientCapabilities: PlanResourceChangeClientCapabilities(in.ClientCapabilities),
+		PriorIdentity:      ResourceIdentityData(in.PriorIdentity),
 	}
 
 	return resp
@@ -76,12 +92,13 @@ func ApplyResourceChangeRequest(in *tfplugin6.ApplyResourceChange_Request) *tfpr
 	}
 
 	resp := &tfprotov6.ApplyResourceChangeRequest{
-		Config:         DynamicValue(in.Config),
-		PlannedPrivate: in.PlannedPrivate,
-		PlannedState:   DynamicValue(in.PlannedState),
-		PriorState:     DynamicValue(in.PriorState),
-		ProviderMeta:   DynamicValue(in.ProviderMeta),
-		TypeName:       in.TypeName,
+		Config:          DynamicValue(in.Config),
+		PlannedPrivate:  in.PlannedPrivate,
+		PlannedState:    DynamicValue(in.PlannedState),
+		PriorState:      DynamicValue(in.PriorState),
+		ProviderMeta:    DynamicValue(in.ProviderMeta),
+		TypeName:        in.TypeName,
+		PlannedIdentity: ResourceIdentityData(in.PlannedIdentity),
 	}
 
 	return resp
@@ -96,6 +113,7 @@ func ImportResourceStateRequest(in *tfplugin6.ImportResourceState_Request) *tfpr
 		TypeName:           in.TypeName,
 		ID:                 in.Id,
 		ClientCapabilities: ImportResourceStateClientCapabilities(in.ClientCapabilities),
+		Identity:           ResourceIdentityData(in.Identity),
 	}
 
 	return resp
@@ -113,6 +131,7 @@ func MoveResourceStateRequest(in *tfplugin6.MoveResourceState_Request) *tfprotov
 		SourceState:           RawState(in.SourceState),
 		SourceTypeName:        in.SourceTypeName,
 		TargetTypeName:        in.TargetTypeName,
+		SourceIdentity:        ResourceIdentityData(in.SourceIdentity),
 	}
 
 	return resp

tfprotov6/internal/fromproto/resource_identity_data.go

@@ -0,0 +1,21 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package fromproto
+
+import (
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6"
+)
+
+func ResourceIdentityData(in *tfplugin6.ResourceIdentityData) *tfprotov6.ResourceIdentityData {
+	if in == nil {
+		return nil
+	}
+
+	resp := &tfprotov6.ResourceIdentityData{
+		IdentityData: DynamicValue(in.IdentityData),
+	}
+
+	return resp
+}

tfprotov6/internal/fromproto/resource_identity_data_test.go

@@ -0,0 +1,20 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package fromproto_test
+
+import (
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6"
+	"github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/toproto"
+)
+
+func testTfplugin6ResourceIdentityData() *tfplugin6.ResourceIdentityData {
+	return toproto.ResourceIdentityData(testTfprotov6ResourceIdentityData())
+}
+
+func testTfprotov6ResourceIdentityData() *tfprotov6.ResourceIdentityData {
+	return &tfprotov6.ResourceIdentityData{
+		IdentityData: testTfprotov6DynamicValue(),
+	}
+}