Also support floats in NewValue

Author: paultyng

tfprotov5/tftypes/value.go

@@ -61,7 +61,8 @@ type Value struct {
 // * String: string, *string
 //
 // * Number: *big.Float, int64, *int64, int32, *int32, int16, *int16, int8, *int8, int, *int,
-//   uint64, *uint64, uint32, *uint32, uint16, *uint16, uint8, *uint8, byte, *byte, uint, *uint
+//   uint64, *uint64, uint32, *uint32, uint16, *uint16, uint8, *uint8, byte, *byte, uint, *uint,
+//   float64, *float64, float32, *float32
 //
 // * Bool: bool, *bool
 //
@@ -226,6 +227,28 @@ func NewValue(t Type, val interface{}) Value {
 			typ:   t,
 			value: f,
 		}
+	case *float32:
+		if val == nil {
+			return Value{
+				typ:   t,
+				value: nil,
+			}
+		}
+		return Value{
+			typ:   t,
+			value: big.NewFloat(float64(*val)),
+		}
+	case *float64:
+		if val == nil {
+			return Value{
+				typ:   t,
+				value: nil,
+			}
+		}
+		return Value{
+			typ:   t,
+			value: big.NewFloat(*val),
+		}
 	case string, *big.Float, bool, map[string]Value, []Value:
 		return Value{
 			typ:   t,

tfprotov5/tftypes/value_test.go

@@ -24,6 +24,12 @@ func TestValueAs(t *testing.T) {
 	numberPointerPointer := func(in *big.Float) **big.Float {
 		return &in
 	}
+	float64Pointer := func(in float64) *float64 {
+		return &in
+	}
+	float32Pointer := func(in float32) *float32 {
+		return &in
+	}
 	int64Pointer := func(in int64) *int64 {
 		return &in
 	}
@@ -108,6 +114,26 @@ func TestValueAs(t *testing.T) {
 			as:       big.NewFloat(0),
 			expected: big.NewFloat(123),
 		},
+		"number-pointer-float64": {
+			in:       NewValue(Number, float64Pointer(123.4)),
+			as:       big.NewFloat(0),
+			expected: big.NewFloat(123.4),
+		},
+		"number-pointer-float64-null": {
+			in:       NewValue(Number, (*float64)(nil)),
+			as:       numberPointerPointer(big.NewFloat(123.4)),
+			expected: numberPointerPointer(nil),
+		},
+		"number-pointer-float32": {
+			in:       NewValue(Number, float32Pointer(0.125)),
+			as:       big.NewFloat(0),
+			expected: big.NewFloat(0.125),
+		},
+		"number-pointer-float32-null": {
+			in:       NewValue(Number, (*float32)(nil)),
+			as:       numberPointerPointer(big.NewFloat(0.125)),
+			expected: numberPointerPointer(nil),
+		},
 		"number-pointer-int64": {
 			in:       NewValue(Number, int64Pointer(123)),
 			as:       big.NewFloat(0),