ci: unleash the paralleltest lints (#252)

Author: austinvalle

.golangci.yml

@@ -15,7 +15,7 @@ linters:
     - makezero
     - misspell
     - nilerr
-    # - paralleltest # Reference: https://github.com/kunwardeep/paralleltest/issues/14
+    - paralleltest
     - predeclared
     - staticcheck
     - tenv

tfprotov5/internal/toproto/diagnostic_test.go

@@ -5,6 +5,8 @@ import (
 )
 
 func TestForceValidUTF8(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		Input string
 		Want  string
@@ -48,7 +50,10 @@ func TestForceValidUTF8(t *testing.T) {
 	}
 
 	for _, test := range tests {
+		test := test
 		t.Run(test.Input, func(t *testing.T) {
+			t.Parallel()
+
 			got := forceValidUTF8(test.Input)
 			if got != test.Want {
 				t.Errorf("wrong result\ngot:  %q\nwant: %q", got, test.Want)

tfprotov6/internal/toproto/diagnostic_test.go

@@ -5,6 +5,8 @@ import (
 )
 
 func TestForceValidUTF8(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		Input string
 		Want  string
@@ -48,7 +50,10 @@ func TestForceValidUTF8(t *testing.T) {
 	}
 
 	for _, test := range tests {
+		test := test
 		t.Run(test.Input, func(t *testing.T) {
+			t.Parallel()
+
 			got := forceValidUTF8(test.Input)
 			if got != test.Want {
 				t.Errorf("wrong result\ngot:  %q\nwant: %q", got, test.Want)

tftypes/primitive_test.go

@@ -134,6 +134,8 @@ func TestPrimitiveApplyTerraform5AttributePathStep(t *testing.T) {
 }
 
 func TestPrimitiveEqual(t *testing.T) {
+	t.Parallel()
+
 	type testCase struct {
 		p1    primitive
 		p2    primitive
@@ -154,6 +156,8 @@ func TestPrimitiveEqual(t *testing.T) {
 	for name, tc := range tests {
 		name, tc := name, tc
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
 			res := tc.p1.Equal(tc.p2)
 			revRes := tc.p2.Equal(tc.p1)
 			if res != revRes {
@@ -167,6 +171,8 @@ func TestPrimitiveEqual(t *testing.T) {
 }
 
 func TestPrimitiveIs(t *testing.T) {
+	t.Parallel()
+
 	type testCase struct {
 		p1    primitive
 		p2    primitive
@@ -187,6 +193,8 @@ func TestPrimitiveIs(t *testing.T) {
 	for name, tc := range tests {
 		name, tc := name, tc
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
 			res := tc.p1.Is(tc.p2)
 			if res != tc.equal {
 				t.Errorf("Expected result to be %v, got %v", tc.equal, res)
@@ -196,6 +204,8 @@ func TestPrimitiveIs(t *testing.T) {
 }
 
 func TestPrimitiveUsableAs(t *testing.T) {
+	t.Parallel()
+
 	type testCase struct {
 		p        primitive
 		o        Type

tftypes/type_json_test.go

@@ -156,6 +156,8 @@ func TestTypeJSON(t *testing.T) {
 	for name, test := range testCases {
 		name, test := name, test
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
 			typ, err := ParseJSONType([]byte(test.json))
 			if err != nil {
 				t.Fatalf("unexpected error parsing JSON: %s", err)

tftypes/value_test.go

@@ -430,6 +430,8 @@ func TestValueAs(t *testing.T) {
 	for name, test := range tests {
 		name, test := name, test
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
 			err := test.in.As(test.as)
 			if err != nil {
 				t.Fatalf("unexpected error: %s", err)
@@ -1747,6 +1749,8 @@ func TestValueString(t *testing.T) {
 	for name, test := range tests {
 		name, test := name, test
 		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
 			str := test.in.String()
 			if diff := cmp.Diff(test.expected, str); diff != "" {
 				t.Errorf("Unexpected results (-wanted, +got): %s", diff)

tftypes/walk_test.go

@@ -32,6 +32,8 @@ import (
 )
 
 func TestWalk(t *testing.T) {
+	t.Parallel()
+
 	valType := Object{
 		AttributeTypes: map[string]Type{
 			"string":       String,