Check the error on post-test destroy.

paddycarver · Paddy · commit 8c571eed2089 · 2020-09-15T12:17:41.000-07:00
We were silently discarding the error instead of surfacing it when there was an error returned from our post-test destroy code responsible for tearing down infrastructure. Let's tell the user so they know infrastructure may be dangling, and can see what went wrong and ideally fix it. Fixes #571.
diff --git a/helper/resource/testing_new.go b/helper/resource/testing_new.go
@@ -63,7 +63,10 @@ func runNewTest(t testing.T, c TestCase, helper *tftest.Helper) {
 		}
 
 		if !stateIsEmpty(statePreDestroy) {
-			runPostTestDestroy(t, c, wd, c.ProviderFactories)
+			err := runPostTestDestroy(t, c, wd, c.ProviderFactories)
+			if err != nil {
+				t.Fatalf("Error running post-test destroy, there may be dangling resources: %s", err.Error())
+			}
 		}
 
 		wd.Close()

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,10 @@ func runNewTest(t testing.T, c TestCase, helper *tftest.Helper) {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if !stateIsEmpty(statePreDestroy) {`
`66`		`- runPostTestDestroy(t, c, wd, c.ProviderFactories)`
	`66`	`+ err := runPostTestDestroy(t, c, wd, c.ProviderFactories)`
	`67`	`+ if err != nil {`
	`68`	`+ t.Fatalf("Error running post-test destroy, there may be dangling resources: %s", err.Error())`
	`69`	`+ }`
`67`	`70`	`}`
`68`	`71`
`69`	`72`	`wd.Close()`