Rename to step.ConfigExact

Author: bbasata

helper/resource/importstate/import_block_in_config_directory_test.go

@@ -35,11 +35,11 @@ func TestImportBlock_InConfigDirectory(t *testing.T) {
 				ConfigDirectory: config.StaticDirectory(`testdata/1`),
 			},
 			{
-				ResourceName:              "examplecloud_container.test",
-				ImportState:               true,
-				ImportStateKind:           r.ImportBlockWithID,
-				ImportStateReadOnlyConfig: true, // TODO: naming
-				ConfigDirectory:           config.StaticDirectory(`testdata/2`),
+				ResourceName:    "examplecloud_container.test",
+				ImportState:     true,
+				ImportStateKind: r.ImportBlockWithID,
+				ConfigDirectory: config.StaticDirectory(`testdata/2`),
+				ConfigExact:     true,
 			},
 		},
 	})
@@ -64,11 +64,11 @@ func TestImportBlock_InConfigDirectory_Writeable(t *testing.T) {
 				ConfigDirectory: config.StaticDirectory(`testdata/1`),
 			},
 			{
-				ResourceName:              "examplecloud_container.test",
-				ImportState:               true,
-				ImportStateKind:           r.ImportBlockWithID,
-				ImportStateReadOnlyConfig: false,
-				ConfigDirectory:           config.StaticDirectory(`testdata/writeable-config-directory`),
+				ResourceName:    "examplecloud_container.test",
+				ImportState:     true,
+				ImportStateKind: r.ImportBlockWithID,
+				ConfigDirectory: config.StaticDirectory(`testdata/writeable-config-directory`),
+				ConfigExact:     false,
 			},
 		},
 	})

helper/resource/testing.go

@@ -576,6 +576,16 @@ type TestStep struct {
 	// otherwise an error will be returned.
 	ConfigFile config.TestStepConfigFunc
 
+	// ConfigExact indicates that the test framework should use the exact
+	// content of the Config, ConfigFile, or ConfigDirectory inputs and should
+	// not modify it at test run time.
+	//
+	// The default is false. At test run time, the test framework will generate
+	// specific kinds of configuration, such as import blocks, and append them
+	// to the given Config, ConfigFile, or ConfigDirectory inputs. Using this
+	// default improves test readability and removes duplication of setup.
+	ConfigExact bool
+
 	// ConfigVariables is a map defining variables for use in conjunction
 	// with Terraform configuration. If this map is populated then it
 	// will be used to assemble an *.auto.tfvars.json which will be
@@ -666,10 +676,6 @@ type TestStep struct {
 
 	ImportStateKind ImportStateKind
 
-	// ImportStateReadOnlyConfig indicates that the test framework should not
-	// modify ConfigFile or ConfigDirectory inputs to the test step.
-	ImportStateReadOnlyConfig bool
-
 	// ImportStateId is the ID to perform an ImportState operation with.
 	// This is optional. If it isn't set, then the resource ID is automatically
 	// determined by inspecting the state for ResourceName's ID.

helper/resource/testing_new_import_state.go

@@ -135,7 +135,7 @@ func testStepNewImportState(ctx context.Context, t testing.T, helper *plugintest
 			t.Fatal("Cannot import state with no specified config")
 		}
 
-	case step.ImportStateReadOnlyConfig:
+	case step.ConfigExact:
 		break
 
 	case step.ConfigDirectory != nil: