extract: improve nil error

Author: bschaatsbergen

statecheck/extract_bool_value.go

@@ -62,7 +62,7 @@ func (e extractBoolValue) CheckState(ctx context.Context, req CheckStateRequest,
 	}
 
 	if result == nil {
-		resp.Error = fmt.Errorf("attribute '%s' not found in '%s'", e.attributePath, e.resourceAddress)
+		resp.Error = fmt.Errorf("nil: result for attribute '%s' in '%s'", e.attributePath, e.resourceAddress)
 
 		return
 	}
@@ -72,6 +72,7 @@ func (e extractBoolValue) CheckState(ctx context.Context, req CheckStateRequest,
 		*e.targetVar = t
 	default:
 		resp.Error = fmt.Errorf("invalid type for attribute '%s' in '%s'. Expected: bool, Got: %T", e.attributePath, e.resourceAddress, t)
+
 		return
 	}
 }

statecheck/extract_bool_value_test.go

@@ -8,11 +8,11 @@ import (
 	"regexp"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/statecheck"
-	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/hashicorp/terraform-plugin-testing/tfjsonpath"
 )
 
@@ -103,7 +103,7 @@ func TestExtractBoolValue_CheckState_Null(t *testing.T) {
 						&targetVar,
 					),
 				},
-				ExpectError: regexp.MustCompile(`invalid type for attribute \'float_attribute\' in \'test_resource\.one\'. Expected: bool, Got: json\.Number`),
+				ExpectError: regexp.MustCompile(`nil: result for attribute \'bool_attribute\' in \'test_resource.one\'`),
 			},
 		},
 	})