Rename to ImportStateConfigExact and tidy comment

Author: bbasata

helper/resource/importstate/import_block_as_first_step_test.go

@@ -48,7 +48,7 @@ func TestImportBlock_AsFirstStep(t *testing.T) {
 					id = "westeurope/somevalue"
 				}
 				`,
-				ConfigExact: true,
+				ImportStateConfigExact: true,
 				ImportPlanChecks: r.ImportPlanChecks{
 					PreApply: []plancheck.PlanCheck{
 						plancheck.ExpectResourceAction("examplecloud_container.test", plancheck.ResourceActionNoop),

helper/resource/importstate/import_block_in_config_directory_test.go

@@ -69,8 +69,8 @@ func TestImportBlock_InConfigDirectory_ConfigExactTrue(t *testing.T) {
 
 				// This content includes an import block with an ID so we will
 				// use the exact content
-				ConfigDirectory: config.StaticDirectory(`testdata/2_with_exact_import_config`),
-				ConfigExact:     true,
+				ConfigDirectory:        config.StaticDirectory(`testdata/2_with_exact_import_config`),
+				ImportStateConfigExact: true,
 			},
 		},
 	})

helper/resource/importstate/import_block_in_config_file_test.go

@@ -97,8 +97,8 @@ func TestImportBlock_InConfigFile_ConfigExactTrue(t *testing.T) {
 
 				// This content includes an import block with an ID so we will
 				// use the exact content
-				ConfigFile:  config.StaticFile(`testdata/examplecloud_container_with_exact_import_config_with_id.tf`),
-				ConfigExact: true,
+				ConfigFile:             config.StaticFile(`testdata/examplecloud_container_with_exact_import_config_with_id.tf`),
+				ImportStateConfigExact: true,
 			},
 		},
 	})

helper/resource/importstate/import_block_with_id_test.go

@@ -89,11 +89,11 @@ func TestImportBlock_WithID_ExpectError(t *testing.T) {
 					id = "westeurope/somevalue"
 				}
 				`,
-				ConfigExact:     true,
-				ResourceName:    "examplecloud_container.test",
-				ImportState:     true,
-				ImportStateKind: r.ImportBlockWithID,
-				ExpectError:     regexp.MustCompile(`importing resource examplecloud_container.test: expected a no-op import operation, got.*\["update"\] action with plan(.?)`),
+				ResourceName:           "examplecloud_container.test",
+				ImportState:            true,
+				ImportStateKind:        r.ImportBlockWithID,
+				ImportStateConfigExact: true,
+				ExpectError:            regexp.MustCompile(`importing resource examplecloud_container.test: expected a no-op import operation, got.*\["update"\] action with plan(.?)`),
 			},
 		},
 	})
@@ -296,10 +296,10 @@ func TestImportBlock_WithID_WithBlankOptionalAttribute_GeneratesCorrectPlan(t *t
 					id = "sometestid"
 
 				}`,
-				ConfigExact:     true,
-				ResourceName:    "examplecloud_container.test",
-				ImportState:     true,
-				ImportStateKind: r.ImportBlockWithID,
+				ResourceName:           "examplecloud_container.test",
+				ImportState:            true,
+				ImportStateKind:        r.ImportBlockWithID,
+				ImportStateConfigExact: true,
 			},
 		},
 	})
@@ -418,11 +418,11 @@ import {
 				Config: config,
 			},
 			{
-				ImportState:     true,
-				ImportStateKind: r.ImportBlockWithID,
-				Config:          configWithImportBlock,
-				ConfigExact:     true,
-				ResourceName:    "random_string.mystery_message",
+				ImportState:            true,
+				ImportStateKind:        r.ImportBlockWithID,
+				ImportStateConfigExact: true,
+				Config:                 configWithImportBlock,
+				ResourceName:           "random_string.mystery_message",
 				ImportPlanChecks: r.ImportPlanChecks{
 					PreApply: []plancheck.PlanCheck{
 						plancheck.ExpectKnownValue(

helper/resource/testing.go

@@ -576,15 +576,15 @@ type TestStep struct {
 	// otherwise an error will be returned.
 	ConfigFile config.TestStepConfigFunc
 
-	// ConfigExact indicates that the test framework should use the exact
+	// ImportStateConfigExact indicates that the test framework should use the exact
 	// content of the Config, ConfigFile, or ConfigDirectory inputs and should
 	// not modify it at test run time.
 	//
 	// The default is false. At test run time, the test framework will generate
 	// specific kinds of configuration, such as import blocks, and append them
 	// to the given Config, ConfigFile, or ConfigDirectory inputs. Using this
 	// default improves test readability and removes duplication of setup.
-	ConfigExact bool
+	ImportStateConfigExact bool
 
 	// ConfigVariables is a map defining variables for use in conjunction
 	// with Terraform configuration. If this map is populated then it

helper/resource/testing_new_import_state.go

@@ -123,7 +123,7 @@ func testStepNewImportState(ctx context.Context, t testing.T, helper *plugintest
 	}.Exec())
 
 	switch {
-	case step.ConfigExact:
+	case step.ImportStateConfigExact:
 		break
 
 	case kind.plannable() && kind.resourceIdentity():

internal/teststep/directory.go

@@ -13,7 +13,6 @@ import (
 
 var _ Config = configurationDirectory{}
 
-// not threadsafe
 type configurationDirectory struct {
 	directory string