Skip to content

Commit 7e59fd9

Browse files
bbasatabbasata
authored
Replace deprecated linters (#440)
1 parent 46594ea commit 7e59fd9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+3
-202
lines changed

‎.golangci.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ issues:
55
linters:
66
disable-all: true
77
enable:
8+
- copyloopvar
89
- durationcheck
910
- errcheck
10-
- exportloopref
1111
- forcetypeassert
1212
- gofmt
1313
- gosimple
@@ -18,10 +18,10 @@ linters:
1818
- paralleltest
1919
- predeclared
2020
- staticcheck
21-
- tenv
2221
- unconvert
2322
- unparam
2423
- unused
24+
- usetesting
2525
- govet
2626

2727
run:

‎compare/values_differ_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ func TestValuesDiffer_CompareValues(t *testing.T) {
4747
}
4848

4949
for name, testCase := range testCases {
50-
name, testCase := name, testCase
51-
5250
t.Run(name, func(t *testing.T) {
5351
t.Parallel()
5452

‎compare/values_same_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ func TestValuesSame_CompareValues(t *testing.T) {
4949
}
5050

5151
for name, testCase := range testCases {
52-
name, testCase := name, testCase
53-
5452
t.Run(name, func(t *testing.T) {
5553
t.Parallel()
5654

‎config/directory_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ func TestTestStepConfigFunc_Exec_Directory(t *testing.T) {
3939
}
4040

4141
for name, testCase := range testCases {
42-
name, testCase := name, testCase
43-
4442
t.Run(name, func(t *testing.T) {
4543
t.Parallel()
4644

‎config/file_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ func TestTestStepConfigFunc_Exec_File(t *testing.T) {
3939
}
4040

4141
for name, testCase := range testCases {
42-
name, testCase := name, testCase
43-
4442
t.Run(name, func(t *testing.T) {
4543
t.Parallel()
4644

‎config/variable_test.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,6 @@ func TestMarshalJSON(t *testing.T) {
273273
}
274274

275275
for name, testCase := range testCases {
276-
name, testCase := name, testCase
277-
278276
t.Run(name, func(t *testing.T) {
279277
t.Parallel()
280278

@@ -321,8 +319,6 @@ func TestVariablesWrite(t *testing.T) {
321319
}
322320

323321
for name, testCase := range testCases {
324-
name, testCase := name, testCase
325-
326322
t.Run(name, func(t *testing.T) {
327323
t.Parallel()
328324

‎helper/acctest/random_test.go‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ func TestRandSSHKeyPair(t *testing.T) {
9696
}
9797

9898
for name, testCase := range testCases {
99-
name, testCase := name, testCase
100-
10199
t.Run(name, func(t *testing.T) {
102100
t.Parallel()
103101

@@ -198,7 +196,6 @@ func TestInverseMask(t *testing.T) {
198196
}
199197

200198
for tName, tCase := range testCases {
201-
tName, tCase := tName, tCase
202199
t.Run(tName, func(t *testing.T) {
203200
t.Parallel()
204201

‎helper/resource/plugin_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ func TestProtoV5ProviderFactoriesMerge(t *testing.T) {
7979
}
8080

8181
for name, testCase := range testCases {
82-
name, testCase := name, testCase
83-
8482
t.Run(name, func(t *testing.T) {
8583
t.Parallel()
8684

@@ -154,8 +152,6 @@ func TestProtoV6ProviderFactoriesMerge(t *testing.T) {
154152
}
155153

156154
for name, testCase := range testCases {
157-
name, testCase := name, testCase
158-
159155
t.Run(name, func(t *testing.T) {
160156
t.Parallel()
161157

@@ -229,8 +225,6 @@ func TestSdkProviderFactoriesMerge(t *testing.T) {
229225
}
230226

231227
for name, testCase := range testCases {
232-
name, testCase := name, testCase
233-
234228
t.Run(name, func(t *testing.T) {
235229
t.Parallel()
236230

‎helper/resource/testcase_providers_test.go‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ provider "test" {}`,
231231
}
232232

233233
for name, test := range tests {
234-
name, test := name, test
235-
236234
t.Run(name, func(t *testing.T) {
237235
t.Parallel()
238236

‎helper/resource/testcase_validate_test.go‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ func TestTestCaseHasExternalProviders(t *testing.T) {
3636
}
3737

3838
for name, test := range tests {
39-
name, test := name, test
40-
4139
t.Run(name, func(t *testing.T) {
4240
t.Parallel()
4341

@@ -104,8 +102,6 @@ func TestTestCaseHasProviders(t *testing.T) {
104102
}
105103

106104
for name, test := range tests {
107-
name, test := name, test
108-
109105
t.Run(name, func(t *testing.T) {
110106
t.Parallel()
111107

@@ -184,8 +180,6 @@ func TestTestCaseValidate(t *testing.T) {
184180
}
185181

186182
for name, test := range tests {
187-
name, test := name, test
188-
189183
t.Run(name, func(t *testing.T) {
190184
t.Parallel()
191185

0 commit comments

Comments
 (0)