Rename test functions for consistency and for running by pattern

Author: bbasata

helper/resource/importstate/import_block_as_first_step_test.go

@@ -18,7 +18,7 @@ import (
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-func Test_ImportBlock_AsFirstStep(t *testing.T) {
+func TestImportBlock_AsFirstStep(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{

helper/resource/importstate/import_block_in_config_directory_test.go

@@ -16,7 +16,7 @@ import (
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-func Test_ImportBlock_InConfigDirectory(t *testing.T) {
+func TestImportBlock_InConfigDirectory(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{

helper/resource/importstate/import_block_in_config_file_test.go

@@ -16,7 +16,7 @@ import (
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-func Test_ImportBlock_InConfigFile(t *testing.T) {
+func TestImportBlock_InConfigFile(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{

helper/resource/importstate/import_block_with_id_test.go

@@ -21,7 +21,7 @@ import (
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-func Test_TestStep_ImportBlockId(t *testing.T) {
+func TestImportBlock_WithID(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -52,7 +52,7 @@ func Test_TestStep_ImportBlockId(t *testing.T) {
 	})
 }
 
-func TestTest_TestStep_ImportBlockId_ExpectError(t *testing.T) {
+func TestImportBlock_WithID_ExpectError(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -89,7 +89,7 @@ func TestTest_TestStep_ImportBlockId_ExpectError(t *testing.T) {
 	})
 }
 
-func TestTest_TestStep_ImportBlockId_FailWhenPlannableImportIsNotSupported(t *testing.T) {
+func TestImportBlock_WithID_FailWhenNotSupported(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -128,7 +128,7 @@ func TestTest_TestStep_ImportBlockId_FailWhenPlannableImportIsNotSupported(t *te
 	})
 }
 
-func TestTest_TestStep_ImportBlockId_SkipDataSourceState(t *testing.T) {
+func TestImportBlock_WithID_SkipsDataSources(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -172,9 +172,7 @@ func TestTest_TestStep_ImportBlockId_SkipDataSourceState(t *testing.T) {
 	})
 }
 
-// These tests currently pass but only because the `getState` function which is used on the imported resource
-// to do the state comparison doesn't return an error if there is no state in the working directory
-func TestTest_TestStep_ImportBlockId_ImportStateVerifyIgnore_Real_Example(t *testing.T) {
+func TestImportBlock_WithID_WithBlankOptionalAttribute_GeneratesCorrectPlan(t *testing.T) {
 	/*
 			This test tries to imitate a real world example of behaviour we often see in the AzureRM provider which requires
 			the use of `ImportStateVerifyIgnore` when testing the import of a resource using the import command.
@@ -296,7 +294,7 @@ func TestTest_TestStep_ImportBlockId_ImportStateVerifyIgnore_Real_Example(t *tes
 	})
 }
 
-func TestTest_TestStep_ImportBlockId_ImportStateVerifyIgnore(t *testing.T) {
+func TestImportBlock_WithID_WithBlankComputedAttribute_GeneratesCorrectPlan(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{

helper/resource/importstate/import_command_as_first_step_test.go

@@ -17,7 +17,7 @@ import (
 	r "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-func Test_ImportCommand_AsFirstStep(t *testing.T) {
+func TestImportCommand_AsFirstStep(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{

helper/resource/importstate/import_command_with_id_test.go

@@ -20,7 +20,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-testing/tfversion"
 )
 
-func Test_TestStep_ImportStateCheck_SkipDataSourceState(t *testing.T) {
+func TestImportCommand_ImportStateCheckSkipsDataSources(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -123,7 +123,7 @@ func Test_TestStep_ImportStateCheck_SkipDataSourceState(t *testing.T) {
 	})
 }
 
-func Test_TestStep_ImportStateVerify(t *testing.T) {
+func TestImportCommand_ImportStateVerify(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -197,7 +197,7 @@ func Test_TestStep_ImportStateVerify(t *testing.T) {
 	})
 }
 
-func Test_TestStep_ImportStateVerifyIgnore(t *testing.T) {
+func TestImportCommand_ImportStateVerify_Ignore(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{
@@ -281,7 +281,7 @@ func Test_TestStep_ImportStateVerifyIgnore(t *testing.T) {
 	})
 }
 
-func Test_TestStep_ExpectError_ImportState(t *testing.T) {
+func TestImportCommand_ExpectError(t *testing.T) {
 	t.Parallel()
 
 	r.UnitTest(t, r.TestCase{