helper/resource: Changelogs and test for #602#606
Conversation
|
Interesting, the newly added alpha is causing some consistent test failures 😅 === RUN TestTest_TestStep_ProviderFactories_Import_External_WithoutPersistNonMatch_WithPersistWorkingDir
teststep_providers_test.go:2968: TestCase error running init: exit status 1
Error: Failed to query available provider packages
Could not retrieve the list of available versions for provider
hashicorp/random: could not connect to registry.terraform.io: error reading
discovery document body: context canceled
To see which modules are currently depending on hashicorp/random and what
versions are specified, run the following command:
terraform providersI'll need to figure out how I can recreate this on my local machine, as I'm not seeing failures there 👀 , there has been a change recently to that Go module, but unsure if it's related ATM: hashicorp/terraform#38064 This test failure is almost certainly unrelated to the change in #602 , this PR just happens to be the bearer of bad news 😆 |
There was a problem hiding this comment.
I'll add an approval from my end in regards to the added test and changelogs related to #602
Took a crack at understanding the consistent failures from 1.15.0-alpha but it looks like it may be coming from a go module changed (thanks for looking into that further! )
Makes sense to not merge this until we at least know what is producing the consistent failures.
4409fe8 to
e5c6d79
Compare
|
Alright, I've reverted my temporary changes on this PR and left the I'm going to take my further attempts to clarify the error into a separate draft PR. This PR is ready for review 👍🏻 Funny enough, one of the 1.15 tests has finally passed, so race condition confirmed 😆 |
Related Issue
Follow-up to #602 , cc @BBBmau
Description
This PR just includes changelogs and a test for the only change that was unrelated to the special compatibility flag we have.
If you comment out the destroy plan code added in #602, the new test will error with:
--- FAIL: Test_Destroy_Checks_Avoid_Stale_Plan (0.42s) /Users/austin.valle/code/terraform-plugin-testing/helper/resource/testing_new_config_test.go:915: Step 1/1 error: Error running destroy: exit status 1 Error: Saved plan is stale The given plan file can no longer be applied because the state was changed by another operation after the plan was created. FAIL FAIL github.com/hashicorp/terraform-plugin-testing/helper/resource 1.252sRollback Plan
Changes to Security Controls
No