Apply suggestions from code review

bendbennett · bflad · web-flow · commit 20773a8b3382 · 2022-12-22T11:53:18.000Z
Co-authored-by: Brian Flad &lt;bflad417@gmail.com&gt;
diff --git a/internal/provider/data_source_archive_file.go b/internal/provider/data_source_archive_file.go
@@ -163,7 +163,7 @@ func archive(ctx context.Context, model fileModel) error {
 		archiver.SetOutputFileMode(outputFileMode)
 	}
 
-	switch true {
+	switch {
 	case !model.SourceDir.IsNull():
 		excludeList := make([]string, len(model.Excludes.Elements()))
 
diff --git a/internal/provider/data_source_archive_file_test.go b/internal/provider/data_source_archive_file_test.go
@@ -87,8 +87,7 @@ func TestAccArchiveFile_Basic(t *testing.T) {
 }
 
 func TestDataSource_UpgradeFromVersion2_2_0_ContentConfig(t *testing.T) {
-	td := testTempDir(t)
-	defer os.RemoveAll(td)
+	td := t.TempDir()
 
 	f := filepath.Join(td, "zip_file_acc_test_upgrade_content_config.zip")
 

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ func archive(ctx context.Context, model fileModel) error {`
`163`	`163`	`archiver.SetOutputFileMode(outputFileMode)`
`164`	`164`	`}`
`165`	`165`
`166`		`- switch true {`
	`166`	`+ switch {`
`167`	`167`	`case !model.SourceDir.IsNull():`
`168`	`168`	`excludeList := make([]string, len(model.Excludes.Elements()))`
`169`	`169`
Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,7 @@ func TestAccArchiveFile_Basic(t *testing.T) {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`func TestDataSource_UpgradeFromVersion2_2_0_ContentConfig(t *testing.T) {`
`90`		`- td := testTempDir(t)`
`91`		`- defer os.RemoveAll(td)`
	`90`	`+ td := t.TempDir()`
`92`	`91`
`93`	`92`	`f := filepath.Join(td, "zip_file_acc_test_upgrade_content_config.zip")`
`94`	`93`