Skip to content

Commit 0088e02

Browse files
jar-bjar-b
committed
r/aws_sfn_state_machine(test): parallelize all tests, tidy up
```console % make t K=sfn T=TestAccSFNStateMachine_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-ri-sfn 🌿... TF_ACC=1 go1.24.6 test ./internal/service/sfn/... -v -count 1 -parallel 20 -run='TestAccSFNStateMachine_' -timeout 360m -vet=off 2025/09/17 16:11:08 Creating Terraform AWS Provider (SDKv2-style)... 2025/09/17 16:11:08 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccSFNStateMachine_Identity_Basic === PAUSE TestAccSFNStateMachine_Identity_Basic === RUN TestAccSFNStateMachine_Identity_RegionOverride === PAUSE TestAccSFNStateMachine_Identity_RegionOverride === RUN TestAccSFNStateMachine_Identity_ExistingResource === PAUSE TestAccSFNStateMachine_Identity_ExistingResource === RUN TestAccSFNStateMachine_createUpdate === PAUSE TestAccSFNStateMachine_createUpdate === RUN TestAccSFNStateMachine_expressUpdate === PAUSE TestAccSFNStateMachine_expressUpdate === RUN TestAccSFNStateMachine_standardUpdate === PAUSE TestAccSFNStateMachine_standardUpdate === RUN TestAccSFNStateMachine_nameGenerated === PAUSE TestAccSFNStateMachine_nameGenerated === RUN TestAccSFNStateMachine_namePrefix === PAUSE TestAccSFNStateMachine_namePrefix === RUN TestAccSFNStateMachine_publish === PAUSE TestAccSFNStateMachine_publish === RUN TestAccSFNStateMachine_tags === PAUSE TestAccSFNStateMachine_tags === RUN TestAccSFNStateMachine_tracing === PAUSE TestAccSFNStateMachine_tracing === RUN TestAccSFNStateMachine_disappears === PAUSE TestAccSFNStateMachine_disappears === RUN TestAccSFNStateMachine_expressLogging === PAUSE TestAccSFNStateMachine_expressLogging === RUN TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey === PAUSE TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey === RUN TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey === PAUSE TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey === RUN TestAccSFNStateMachine_definitionValidation === PAUSE TestAccSFNStateMachine_definitionValidation === CONT TestAccSFNStateMachine_Identity_Basic === CONT TestAccSFNStateMachine_publish === CONT TestAccSFNStateMachine_createUpdate === CONT TestAccSFNStateMachine_expressUpdate === CONT TestAccSFNStateMachine_namePrefix === CONT TestAccSFNStateMachine_nameGenerated === CONT TestAccSFNStateMachine_standardUpdate === CONT TestAccSFNStateMachine_definitionValidation === CONT TestAccSFNStateMachine_expressLogging === CONT TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey === CONT TestAccSFNStateMachine_tracing === CONT TestAccSFNStateMachine_disappears === CONT TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey === CONT TestAccSFNStateMachine_Identity_ExistingResource === CONT TestAccSFNStateMachine_Identity_RegionOverride === CONT TestAccSFNStateMachine_tags --- PASS: TestAccSFNStateMachine_definitionValidation (101.52s) --- PASS: TestAccSFNStateMachine_Identity_RegionOverride (105.76s) --- PASS: TestAccSFNStateMachine_publish (106.49s) --- PASS: TestAccSFNStateMachine_standardUpdate (122.84s) --- PASS: TestAccSFNStateMachine_expressLogging (127.79s) --- PASS: TestAccSFNStateMachine_createUpdate (131.38s) --- PASS: TestAccSFNStateMachine_tracing (134.65s) --- PASS: TestAccSFNStateMachine_Identity_ExistingResource (145.92s) --- PASS: TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey (163.70s) --- PASS: TestAccSFNStateMachine_Identity_Basic (204.70s) --- PASS: TestAccSFNStateMachine_nameGenerated (227.22s) --- PASS: TestAccSFNStateMachine_expressUpdate (227.77s) --- PASS: TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey (243.77s) --- PASS: TestAccSFNStateMachine_tags (247.24s) --- PASS: TestAccSFNStateMachine_namePrefix (288.10s) --- PASS: TestAccSFNStateMachine_disappears (351.03s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 357.668s ```
1 parent 64a88df commit 0088e02

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

‎internal/service/sfn/state_machine_test.go‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func TestAccSFNStateMachine_nameGenerated(t *testing.T) {
221221
Steps: []resource.TestStep{
222222
{
223223
Config: testAccStateMachineConfig_nameGenerated(rName),
224-
Check: resource.ComposeTestCheckFunc(
224+
Check: resource.ComposeAggregateTestCheckFunc(
225225
testAccCheckStateMachineExists(ctx, resourceName, &sm),
226226
acctest.CheckResourceAttrNameGenerated(resourceName, names.AttrName),
227227
resource.TestCheckResourceAttr(resourceName, names.AttrNamePrefix, id.UniqueIdPrefix),
@@ -250,7 +250,7 @@ func TestAccSFNStateMachine_namePrefix(t *testing.T) {
250250
Steps: []resource.TestStep{
251251
{
252252
Config: testAccStateMachineConfig_namePrefix(rName, "tf-acc-test-prefix-"),
253-
Check: resource.ComposeTestCheckFunc(
253+
Check: resource.ComposeAggregateTestCheckFunc(
254254
testAccCheckStateMachineExists(ctx, resourceName, &sm),
255255
acctest.CheckResourceAttrNameFromPrefix(resourceName, names.AttrName, "tf-acc-test-prefix-"),
256256
resource.TestCheckResourceAttr(resourceName, names.AttrNamePrefix, "tf-acc-test-prefix-"),
@@ -279,7 +279,7 @@ func TestAccSFNStateMachine_publish(t *testing.T) {
279279
Steps: []resource.TestStep{
280280
{
281281
Config: testAccStateMachineConfig_publish(rName),
282-
Check: resource.ComposeTestCheckFunc(
282+
Check: resource.ComposeAggregateTestCheckFunc(
283283
testAccCheckStateMachineExists(ctx, resourceName, &sm),
284284
resource.TestCheckResourceAttr(resourceName, "publish", acctest.CtTrue),
285285
resource.TestCheckResourceAttrSet(resourceName, "state_machine_version_arn"),
@@ -309,7 +309,7 @@ func TestAccSFNStateMachine_tags(t *testing.T) {
309309
Steps: []resource.TestStep{
310310
{
311311
Config: testAccStateMachineConfig_tags1(rName, acctest.CtKey1, acctest.CtValue1),
312-
Check: resource.ComposeTestCheckFunc(
312+
Check: resource.ComposeAggregateTestCheckFunc(
313313
testAccCheckStateMachineExists(ctx, resourceName, &sm),
314314
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
315315
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsKey1, acctest.CtValue1),
@@ -322,7 +322,7 @@ func TestAccSFNStateMachine_tags(t *testing.T) {
322322
},
323323
{
324324
Config: testAccStateMachineConfig_tags2(rName, acctest.CtKey1, acctest.CtValue1Updated, acctest.CtKey2, acctest.CtValue2),
325-
Check: resource.ComposeTestCheckFunc(
325+
Check: resource.ComposeAggregateTestCheckFunc(
326326
testAccCheckStateMachineExists(ctx, resourceName, &sm),
327327
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "2"),
328328
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsKey1, acctest.CtValue1Updated),
@@ -331,7 +331,7 @@ func TestAccSFNStateMachine_tags(t *testing.T) {
331331
},
332332
{
333333
Config: testAccStateMachineConfig_tags1(rName, acctest.CtKey2, acctest.CtValue2),
334-
Check: resource.ComposeTestCheckFunc(
334+
Check: resource.ComposeAggregateTestCheckFunc(
335335
testAccCheckStateMachineExists(ctx, resourceName, &sm),
336336
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
337337
resource.TestCheckResourceAttr(resourceName, acctest.CtTagsKey2, acctest.CtValue2),
@@ -355,7 +355,7 @@ func TestAccSFNStateMachine_tracing(t *testing.T) {
355355
Steps: []resource.TestStep{
356356
{
357357
Config: testAccStateMachineConfig_tracingDisable(rName),
358-
Check: resource.ComposeTestCheckFunc(
358+
Check: resource.ComposeAggregateTestCheckFunc(
359359
testAccCheckStateMachineExists(ctx, resourceName, &sm),
360360
resource.TestCheckResourceAttr(resourceName, "tracing_configuration.#", "1"),
361361
resource.TestCheckResourceAttr(resourceName, "tracing_configuration.0.enabled", acctest.CtFalse),
@@ -368,7 +368,7 @@ func TestAccSFNStateMachine_tracing(t *testing.T) {
368368
},
369369
{
370370
Config: testAccStateMachineConfig_tracingEnable(rName),
371-
Check: resource.ComposeTestCheckFunc(
371+
Check: resource.ComposeAggregateTestCheckFunc(
372372
testAccCheckStateMachineExists(ctx, resourceName, &sm),
373373
resource.TestCheckResourceAttr(resourceName, "tracing_configuration.#", "1"),
374374
resource.TestCheckResourceAttr(resourceName, "tracing_configuration.0.enabled", acctest.CtTrue),
@@ -392,7 +392,7 @@ func TestAccSFNStateMachine_disappears(t *testing.T) {
392392
Steps: []resource.TestStep{
393393
{
394394
Config: testAccStateMachineConfig_basic(rName, 5),
395-
Check: resource.ComposeTestCheckFunc(
395+
Check: resource.ComposeAggregateTestCheckFunc(
396396
testAccCheckStateMachineExists(ctx, resourceName, &sm),
397397
acctest.CheckResourceDisappears(ctx, acctest.Provider, tfsfn.ResourceStateMachine(), resourceName),
398398
),
@@ -416,7 +416,7 @@ func TestAccSFNStateMachine_expressLogging(t *testing.T) {
416416
Steps: []resource.TestStep{
417417
{
418418
Config: testAccStateMachineConfig_expressLogConfiguration(rName, string(awstypes.LogLevelError)),
419-
Check: resource.ComposeTestCheckFunc(
419+
Check: resource.ComposeAggregateTestCheckFunc(
420420
testAccCheckStateMachineExists(ctx, resourceName, &sm),
421421
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
422422
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -430,7 +430,7 @@ func TestAccSFNStateMachine_expressLogging(t *testing.T) {
430430
},
431431
{
432432
Config: testAccStateMachineConfig_expressLogConfiguration(rName, string(awstypes.LogLevelAll)),
433-
Check: resource.ComposeTestCheckFunc(
433+
Check: resource.ComposeAggregateTestCheckFunc(
434434
testAccCheckStateMachineExists(ctx, resourceName, &sm),
435435
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
436436
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -456,15 +456,15 @@ func TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey(t *test
456456
reusePeriodSeconds1 := 900
457457
reusePeriodSeconds2 := 450
458458

459-
resource.Test(t, resource.TestCase{
459+
resource.ParallelTest(t, resource.TestCase{
460460
PreCheck: func() { acctest.PreCheck(ctx, t) },
461461
ErrorCheck: acctest.ErrorCheck(t, names.SFNServiceID),
462462
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
463463
CheckDestroy: testAccCheckStateMachineDestroy(ctx),
464464
Steps: []resource.TestStep{
465465
{
466466
Config: testAccStateMachineConfig_encryptionConfigurationCustomerManagedKMSKey_1(rName, string(awstypes.EncryptionTypeCustomerManagedKmsKey), reusePeriodSeconds1),
467-
Check: resource.ComposeTestCheckFunc(
467+
Check: resource.ComposeAggregateTestCheckFunc(
468468
testAccCheckStateMachineExists(ctx, resourceName, &sm),
469469
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
470470
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -487,7 +487,7 @@ func TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey(t *test
487487
//Update periodReuseSeconds
488488
{
489489
Config: testAccStateMachineConfig_encryptionConfigurationCustomerManagedKMSKey_1(rName, string(awstypes.EncryptionTypeCustomerManagedKmsKey), reusePeriodSeconds2),
490-
Check: resource.ComposeTestCheckFunc(
490+
Check: resource.ComposeAggregateTestCheckFunc(
491491
testAccCheckStateMachineExists(ctx, resourceName, &sm),
492492
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
493493
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -505,7 +505,7 @@ func TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey(t *test
505505
//Update kmsKeyId
506506
{
507507
Config: testAccStateMachineConfig_encryptionConfigurationCustomerManagedKMSKey_2(rName, string(awstypes.EncryptionTypeCustomerManagedKmsKey), reusePeriodSeconds2),
508-
Check: resource.ComposeTestCheckFunc(
508+
Check: resource.ComposeAggregateTestCheckFunc(
509509
testAccCheckStateMachineExists(ctx, resourceName, &sm),
510510
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
511511
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -523,7 +523,7 @@ func TestAccSFNStateMachine_encryptionConfigurationCustomerManagedKMSKey(t *test
523523
//Update Encryption Key Type
524524
{
525525
Config: testAccStateMachineConfig_encryptionConfigurationServiceOwnedKey(rName, string(awstypes.EncryptionTypeAwsOwnedKey)),
526-
Check: resource.ComposeTestCheckFunc(
526+
Check: resource.ComposeAggregateTestCheckFunc(
527527
testAccCheckStateMachineExists(ctx, resourceName, &sm),
528528
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
529529
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -547,15 +547,15 @@ func TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey(t *testing.T)
547547
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
548548
reusePeriodSeconds := 900
549549

550-
resource.Test(t, resource.TestCase{
550+
resource.ParallelTest(t, resource.TestCase{
551551
PreCheck: func() { acctest.PreCheck(ctx, t) },
552552
ErrorCheck: acctest.ErrorCheck(t, names.SFNServiceID),
553553
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
554554
CheckDestroy: testAccCheckStateMachineDestroy(ctx),
555555
Steps: []resource.TestStep{
556556
{
557557
Config: testAccStateMachineConfig_encryptionConfigurationServiceOwnedKey(rName, string(awstypes.EncryptionTypeAwsOwnedKey)),
558-
Check: resource.ComposeTestCheckFunc(
558+
Check: resource.ComposeAggregateTestCheckFunc(
559559
testAccCheckStateMachineExists(ctx, resourceName, &sm),
560560
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
561561
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
@@ -575,7 +575,7 @@ func TestAccSFNStateMachine_encryptionConfigurationServiceOwnedKey(t *testing.T)
575575
//Update Encryption Type
576576
{
577577
Config: testAccStateMachineConfig_encryptionConfigurationCustomerManagedKMSKey_1(rName, string(awstypes.EncryptionTypeCustomerManagedKmsKey), reusePeriodSeconds),
578-
Check: resource.ComposeTestCheckFunc(
578+
Check: resource.ComposeAggregateTestCheckFunc(
579579
testAccCheckStateMachineExists(ctx, resourceName, &sm),
580580
resource.TestCheckResourceAttr(resourceName, names.AttrStatus, string(awstypes.StateMachineStatusActive)),
581581
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),

0 commit comments

Comments
 (0)