Skip to content

Commit 0ad814f

Browse files
author
Christopher Robert Sherman
committed
add changelog, make linter happy
1 parent 2986c05 commit 0ad814f

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.changelog/44471.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
resource/aws_s3_access_point: Fix tagging operations for S3 Express One Zone Directory Bucket Access Points by routing requests to the correct `s3express-control` API endpoint
3+
```

internal/service/s3control/tags_gen_test.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,29 +6,31 @@ package s3control
66
import "testing"
77

88
func TestIsDirectoryBucketARN(t *testing.T) {
9+
t.Parallel()
10+
911
testCases := []struct {
1012
name string
1113
arn string
1214
expected bool
1315
}{
1416
{
1517
name: "Standard S3 bucket ARN",
16-
arn: "arn:aws:s3:::my-bucket",
18+
arn: "arn:partition:s3:::my-bucket",
1719
expected: false,
1820
},
1921
{
2022
name: "S3 Control Access Point ARN",
21-
arn: "arn:aws:s3:us-east-1:123456789012:accesspoint/my-access-point",
23+
arn: "arn:partition:s3:region:123456789012:accesspoint/my-access-point",
2224
expected: false,
2325
},
2426
{
2527
name: "Directory Bucket ARN (S3 Express)",
26-
arn: "arn:aws:s3express:us-east-1:123456789012:bucket/my-directory-bucket--usw2-az1--x-s3",
28+
arn: "arn:partition:s3express:region:123456789012:bucket/my-directory-bucket--usw2-az1--x-s3",
2729
expected: true,
2830
},
2931
{
3032
name: "Directory Bucket Access Point ARN",
31-
arn: "arn:aws:s3express:us-east-1:123456789012:accesspoint/my-access-point",
33+
arn: "arn:partition:s3express:region:123456789012:accesspoint/my-access-point",
3234
expected: true,
3335
},
3436
{
@@ -45,6 +47,7 @@ func TestIsDirectoryBucketARN(t *testing.T) {
4547

4648
for _, tc := range testCases {
4749
t.Run(tc.name, func(t *testing.T) {
50+
t.Parallel()
4851
result := isDirectoryBucketARN(tc.arn)
4952
if result != tc.expected {
5053
t.Errorf("isDirectoryBucketARN(%q) = %v, expected %v", tc.arn, result, tc.expected)

0 commit comments

Comments
 (0)