Merge pull request #44449 from tabito-hara/b-aws_servicequotas_service_quota-add_error_handling

[bugfix] d/aws_servicequotas_service_quota: Fix panic when non-existing `quota_name` is specified

Author: ewbankkit

.changelog/44449.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_servicequotas_service_quota: Fixed a panic that occurred when a non-existing `quota_name` was provided
+```

internal/service/servicequotas/service_quota_data_source.go

@@ -128,7 +128,6 @@ func dataSourceServiceQuotaRead(ctx context.Context, d *schema.ResourceData, met
 	// A Service Quota will always have a default value, but will only have a current value if it has been set.
 	if quotaName != "" {
 		defaultQuota, err = findDefaultServiceQuotaByServiceCodeAndQuotaName(ctx, conn, serviceCode, quotaName)
-		quotaCode = aws.ToString(defaultQuota.QuotaCode)
 	} else {
 		defaultQuota, err = findDefaultServiceQuotaByServiceCodeAndQuotaCode(ctx, conn, serviceCode, quotaCode)
 	}
@@ -137,6 +136,10 @@ func dataSourceServiceQuotaRead(ctx context.Context, d *schema.ResourceData, met
 		return sdkdiag.AppendFromErr(diags, tfresource.SingularDataSourceFindError("Service Quotas Service Quota", err))
 	}
 
+	if quotaName != "" {
+		quotaCode = aws.ToString(defaultQuota.QuotaCode)
+	}
+
 	arn := aws.ToString(defaultQuota.QuotaArn)
 	d.SetId(arn)
 	d.Set("adjustable", defaultQuota.Adjustable)

internal/service/servicequotas/service_quota_data_source_test.go

@@ -151,6 +151,10 @@ func TestAccServiceQuotasServiceQuotaDataSource_quotaName(t *testing.T) {
 		ErrorCheck:               acctest.ErrorCheck(t, names.ServiceQuotasServiceID),
 		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
 		Steps: []resource.TestStep{
+			{
+				Config:      testAccServiceQuotaDataSourceConfig_name("vpc", setQuotaQuotaName+"nonexist"),
+				ExpectError: regexache.MustCompile(`Service Quotas Service Quota`),
+			},
 			{
 				Config: testAccServiceQuotaDataSourceConfig_name("vpc", setQuotaQuotaName),
 				Check: resource.ComposeAggregateTestCheckFunc(