Skip to content

Commit 269594d

Browse files
committed
cleanup errors
1 parent dfe5f5a commit 269594d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

internal/service/emrserverless/application.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,6 @@ func resourceApplicationCreate(ctx context.Context, d *schema.ResourceData, meta
436436
input.MonitoringConfiguration = expandMonitoringConfiguration(v.([]any)[0].(map[string]any))
437437
}
438438

439-
output, err := conn.CreateApplication(ctx, input)
440439
if v, ok := d.GetOk("runtime_configuration"); ok && len(v.([]any)) > 0 {
441440
input.RuntimeConfiguration = expandRuntimeConfiguration(v.([]any))
442441
}
@@ -587,7 +586,6 @@ func resourceApplicationUpdate(ctx context.Context, d *schema.ResourceData, meta
587586
input.MonitoringConfiguration = expandMonitoringConfiguration(v.([]any)[0].(map[string]any))
588587
}
589588

590-
_, err := conn.UpdateApplication(ctx, input)
591589
if v, ok := d.GetOk("runtime_configuration"); ok && len(v.([]any)) > 0 {
592590
input.RuntimeConfiguration = expandRuntimeConfiguration(v.([]any))
593591
}

internal/service/emrserverless/application_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -965,18 +965,18 @@ func TestAccEMRServerlessApplication_monitoringConfiguration(t *testing.T) {
965965
ctx := acctest.Context(t)
966966
var application types.Application
967967
resourceName := "aws_emrserverless_application.test"
968-
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
968+
rName := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
969969

970970
resource.ParallelTest(t, resource.TestCase{
971971
PreCheck: func() { acctest.PreCheck(ctx, t) },
972972
ErrorCheck: acctest.ErrorCheck(t, names.EMRServerlessServiceID),
973973
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
974-
CheckDestroy: testAccCheckApplicationDestroy(ctx),
974+
CheckDestroy: testAccCheckApplicationDestroy(ctx, t),
975975
Steps: []resource.TestStep{
976976
{
977977
Config: testAccApplicationConfig_monitoringConfiguration(rName),
978978
Check: resource.ComposeTestCheckFunc(
979-
testAccCheckApplicationExists(ctx, resourceName, &application),
979+
testAccCheckApplicationExists(ctx, t, resourceName, &application),
980980
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.#", "1"),
981981
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.0.cloudwatch_logging_configuration.#", "1"),
982982
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.0.cloudwatch_logging_configuration.0.enabled", acctest.CtTrue),
@@ -995,7 +995,7 @@ func TestAccEMRServerlessApplication_monitoringConfiguration(t *testing.T) {
995995
{
996996
Config: testAccApplicationConfig_monitoringConfigurationUpdated(rName),
997997
Check: resource.ComposeTestCheckFunc(
998-
testAccCheckApplicationExists(ctx, resourceName, &application),
998+
testAccCheckApplicationExists(ctx, t, resourceName, &application),
999999
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.#", "1"),
10001000
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.0.cloudwatch_logging_configuration.#", "1"),
10011001
resource.TestCheckResourceAttr(resourceName, "monitoring_configuration.0.cloudwatch_logging_configuration.0.enabled", acctest.CtFalse),

0 commit comments

Comments
 (0)