Add the PRO roles to aws_quicksight_account_subscriptionresource (#44638)

* Add pro roles
* Update documentation
* Add changelog

Author: anurag-hashicorp

.changelog/44638.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_quicksight_account_subscription: Add `admin_pro_group`, `author_pro_group`, and `reader_pro_group` arguments
+```
+
+```release-note:note
+resource/aws_quicksight_account_subscription: Because we cannot easily test all this functionality, it is best effort and we ask for community help in testing
+```

internal/service/quicksight/account_subscription.go

@@ -64,6 +64,13 @@ func resourceAccountSubscription() *schema.Resource {
 					Elem:     &schema.Schema{Type: schema.TypeString},
 					ForceNew: true,
 				},
+				"admin_pro_group": {
+					Type:     schema.TypeList,
+					Optional: true,
+					MinItems: 1,
+					Elem:     &schema.Schema{Type: schema.TypeString},
+					ForceNew: true,
+				},
 				"authentication_method": {
 					Type:             schema.TypeString,
 					Required:         true,
@@ -77,6 +84,13 @@ func resourceAccountSubscription() *schema.Resource {
 					Elem:     &schema.Schema{Type: schema.TypeString},
 					ForceNew: true,
 				},
+				"author_pro_group": {
+					Type:     schema.TypeList,
+					Optional: true,
+					MinItems: 1,
+					Elem:     &schema.Schema{Type: schema.TypeString},
+					ForceNew: true,
+				},
 				names.AttrAWSAccountID: quicksightschema.AWSAccountIDSchema(),
 				"contact_number": {
 					Type:     schema.TypeString,
@@ -126,6 +140,13 @@ func resourceAccountSubscription() *schema.Resource {
 					MinItems: 1,
 					Elem:     &schema.Schema{Type: schema.TypeString},
 				},
+				"reader_pro_group": {
+					Type:     schema.TypeList,
+					Optional: true,
+					ForceNew: true,
+					MinItems: 1,
+					Elem:     &schema.Schema{Type: schema.TypeString},
+				},
 				"realm": {
 					Type:     schema.TypeString,
 					Optional: true,
@@ -161,14 +182,26 @@ func resourceAccountSubscriptionCreate(ctx context.Context, d *schema.ResourceDa
 		input.AdminGroup = flex.ExpandStringValueList(v.([]any))
 	}
 
+	if v, ok := d.GetOk("admin_pro_group"); ok && len(v.([]any)) > 0 {
+		input.AdminProGroup = flex.ExpandStringValueList(v.([]any))
+	}
+
 	if v, ok := d.GetOk("author_group"); ok && len(v.([]any)) > 0 {
 		input.AuthorGroup = flex.ExpandStringValueList(v.([]any))
 	}
 
+	if v, ok := d.GetOk("author_pro_group"); ok && len(v.([]any)) > 0 {
+		input.AuthorProGroup = flex.ExpandStringValueList(v.([]any))
+	}
+
 	if v, ok := d.GetOk("reader_group"); ok && len(v.([]any)) > 0 {
 		input.ReaderGroup = flex.ExpandStringValueList(v.([]any))
 	}
 
+	if v, ok := d.GetOk("reader_pro_group"); ok && len(v.([]any)) > 0 {
+		input.ReaderProGroup = flex.ExpandStringValueList(v.([]any))
+	}
+
 	if v, ok := d.GetOk("contact_number"); ok {
 		input.ContactNumber = aws.String(v.(string))
 	}

website/docs/r/quicksight_account_subscription.html.markdown

@@ -10,7 +10,7 @@ description: |-
 
 Terraform resource for managing an AWS QuickSight Account Subscription.
 
-~> Due to the absence of the `admin_group`, `author_group`, and `reader_group` fields in the [`DescribeAccountSettings`](https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAccountSettings.html) API response, changes made to these groups post-subscription will not be detected by this resource.
+~> Due to the absence of the `admin_group`, `author_group`, `reader_group`, `admin_pro_group`, `author_pro_group`, and `reader_pro_group` fields in the [`DescribeAccountSettings`](https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAccountSettings.html) API response, changes made to these groups post-subscription will not be detected by this resource.
 
 ## Example Usage
 
@@ -36,7 +36,9 @@ The following arguments are optional:
 
 * `active_directory_name` - (Optional) Name of your Active Directory. This field is required if `ACTIVE_DIRECTORY` is the selected authentication method of the new Amazon QuickSight account.
 * `admin_group` - (Optional) Admin group associated with your Active Directory or IAM Identity Center account. This field is required if `ACTIVE_DIRECTORY` or `IAM_IDENTITY_CENTER` is the selected authentication method of the new Amazon QuickSight account.
+* `admin_pro_group` - (Optional) Admin PRO group associated with your Active Directory or IAM Identity Center account.
 * `author_group` - (Optional) Author group associated with your Active Directory or IAM Identity Center account.
+* `author_pro_group` - (Optional) Author PRO group associated with your Active Directory or IAM Identity Center account.
 * `aws_account_id` - (Optional, Forces new resource) AWS account ID. Defaults to automatically determined account ID of the Terraform AWS provider.
 * `contact_number` - (Optional) A 10-digit phone number for the author of the Amazon QuickSight account to use for future communications. This field is required if `ENTERPPRISE_AND_Q` is the selected edition of the new Amazon QuickSight account.
 * `directory_id` - (Optional) Active Directory ID that is associated with your Amazon QuickSight account.
@@ -45,6 +47,7 @@ The following arguments are optional:
 * `iam_identity_center_instance_arn` - (Optional) The Amazon Resource Name (ARN) for the IAM Identity Center instance.
 * `last_name` - (Optional) Last name of the author of the Amazon QuickSight account to use for future communications. This field is required if `ENTERPPRISE_AND_Q` is the selected edition of the new Amazon QuickSight account.
 * `reader_group` - (Optional) Reader group associated with your Active Directory or IAM Identity Center account.
+* `reader_pro_group` - (Optional) Reader PRO group associated with your Active Directory or IAM Identity Center account.
 * `realm` - (Optional) Realm of the Active Directory that is associated with your Amazon QuickSight account.
 * `region` - (Optional) Region where this resource will be [managed](https://docs.aws.amazon.com/general/latest/gr/rande.html#regional-endpoints). Defaults to the Region set in the [provider configuration](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#aws-configuration-reference).