Skip to content

Commit 37e6ef8

Browse files
authored
account: enable go-vcr support (#44700)
* account: enable `go-vcr` support Enables `go-vcr` for the `account` service. ```console % make testacc PKG=account VCR_MODE=RECORD_ONLY VCR_PATH=/tmp/account-vcr-testdata/ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-go-vcr-account 🌿... TF_ACC=1 go1.24.8 test ./internal/service/account/... -v -count 1 -parallel 20 -timeout 360m -vet=off 2025/10/17 16:23:38 Creating Terraform AWS Provider (SDKv2-style)... 2025/10/17 16:23:38 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccAccount_serial/Region/AccountID region_test.go:69: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. panic.go:636: provider meta not found for test TestAccAccount_serial/Region/AccountID panic.go:636: randomness source not found for test TestAccAccount_serial/Region/AccountID === RUN TestAccAccount_serial/Region/basic region_test.go:24: Step 1/3 error: Error running apply: exit status 1 Error: enabling Account Region (ap-southeast-3): operation error Account: EnableRegion, https response error StatusCode: 403, RequestID: 8bfd32c6-d078-49af-bb46-04238374fea1, AccessDeniedException: User: arn:aws:sts::<redacted>:assumed-role/<redacted> is not authorized to perform: account:EnableRegion on resource: arn:aws:account::<redacted>:account with an explicit deny in a service control policy with aws_account_region.test, on terraform_plugin_test.tf line 12, in resource "aws_account_region" "test": 12: resource "aws_account_region" "test" { panic.go:636: randomness source not found for test TestAccAccount_serial/Region/basic --- FAIL: TestAccAccount_serial (59.65s) --- PASS: TestAccAccount_serial/AlternateContact (29.70s) --- PASS: TestAccAccount_serial/AlternateContact/basic (19.58s) --- PASS: TestAccAccount_serial/AlternateContact/disappears (10.12s) --- SKIP: TestAccAccount_serial/AlternateContact/AccountID (0.00s) --- PASS: TestAccAccount_serial/PrimaryContact (26.36s) --- PASS: TestAccAccount_serial/PrimaryContact/basic (17.61s) --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceBasic (8.75s) --- SKIP: TestAccAccount_serial/PrimaryContact/dataSourceAccountID (0.00s) --- FAIL: TestAccAccount_serial/Region (3.60s) --- SKIP: TestAccAccount_serial/Region/AccountID (0.00s) --- FAIL: TestAccAccount_serial/Region/basic (3.60s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/account 66.853s ``` * docs: tweak go-vcr agent guide
1 parent e91401b commit 37e6ef8

File tree

8 files changed

+50
-56
lines changed

8 files changed

+50
-56
lines changed

docs/ai-agent-guides/go-vcr-migration.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ Follow the steps below to enable support for a single service.
1111
```console
1212
% make testacc PKG=polly VCR_MODE=REPLAY_ONLY VCR_PATH=/tmp/polly-vcr-testdata/
1313

14+
Enables `go-vcr` for the `<service-name>` service.
15+
1416
<-- full results here -->
1517
```

internal/service/account/alternate_contact.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"github.com/aws/aws-sdk-go-v2/service/account"
1616
"github.com/aws/aws-sdk-go-v2/service/account/types"
1717
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
18-
sdkretry "github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
1918
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
2019
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
2120
"github.com/hashicorp/terraform-provider-aws/internal/conns"
@@ -133,7 +132,7 @@ func resourceAlternateContactRead(ctx context.Context, d *schema.ResourceData, m
133132

134133
output, err := findAlternateContactByTwoPartKey(ctx, conn, accountID, contactType)
135134

136-
if !d.IsNewResource() && tfresource.NotFound(err) {
135+
if !d.IsNewResource() && retry.NotFound(err) {
137136
log.Printf("[WARN] Account Alternate Contact (%s) not found, removing from state", d.Id())
138137
d.SetId("")
139138
return diags
@@ -247,9 +246,8 @@ func findAlternateContactByTwoPartKey(ctx context.Context, conn *account.Client,
247246
output, err := conn.GetAlternateContact(ctx, &input)
248247

249248
if errs.IsA[*types.ResourceNotFoundException](err) {
250-
return nil, &sdkretry.NotFoundError{
251-
LastError: err,
252-
LastRequest: input,
249+
return nil, &retry.NotFoundError{
250+
LastError: err,
253251
}
254252
}
255253

internal/service/account/alternate_contact_test.go

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,11 @@ import (
99
"testing"
1010

1111
"github.com/aws/aws-sdk-go-v2/service/account/types"
12-
sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
1312
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
1413
"github.com/hashicorp/terraform-plugin-testing/terraform"
1514
"github.com/hashicorp/terraform-provider-aws/internal/acctest"
16-
"github.com/hashicorp/terraform-provider-aws/internal/conns"
15+
"github.com/hashicorp/terraform-provider-aws/internal/retry"
1716
tfaccount "github.com/hashicorp/terraform-provider-aws/internal/service/account"
18-
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
1917
"github.com/hashicorp/terraform-provider-aws/names"
2018
)
2119

@@ -25,19 +23,19 @@ func testAccAlternateContact_basic(t *testing.T) {
2523
domain := acctest.RandomDomainName()
2624
emailAddress1 := acctest.RandomEmailAddress(domain)
2725
emailAddress2 := acctest.RandomEmailAddress(domain)
28-
rName1 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
29-
rName2 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
26+
rName1 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
27+
rName2 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
3028

31-
resource.Test(t, resource.TestCase{
29+
acctest.Test(ctx, t, resource.TestCase{
3230
PreCheck: func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
3331
ErrorCheck: acctest.ErrorCheck(t, names.AccountServiceID),
3432
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
35-
CheckDestroy: testAccCheckAlternateContactDestroy(ctx),
33+
CheckDestroy: testAccCheckAlternateContactDestroy(ctx, t),
3634
Steps: []resource.TestStep{
3735
{
3836
Config: testAccAlternateContactConfig_basic(rName1, emailAddress1),
3937
Check: resource.ComposeAggregateTestCheckFunc(
40-
testAccCheckAlternateContactExists(ctx, resourceName),
38+
testAccCheckAlternateContactExists(ctx, t, resourceName),
4139
resource.TestCheckResourceAttr(resourceName, names.AttrAccountID, ""),
4240
resource.TestCheckResourceAttr(resourceName, "alternate_contact_type", "OPERATIONS"),
4341
resource.TestCheckResourceAttr(resourceName, "email_address", emailAddress1),
@@ -54,7 +52,7 @@ func testAccAlternateContact_basic(t *testing.T) {
5452
{
5553
Config: testAccAlternateContactConfig_basic(rName2, emailAddress2),
5654
Check: resource.ComposeAggregateTestCheckFunc(
57-
testAccCheckAlternateContactExists(ctx, resourceName),
55+
testAccCheckAlternateContactExists(ctx, t, resourceName),
5856
resource.TestCheckResourceAttr(resourceName, names.AttrAccountID, ""),
5957
resource.TestCheckResourceAttr(resourceName, "alternate_contact_type", "OPERATIONS"),
6058
resource.TestCheckResourceAttr(resourceName, "email_address", emailAddress2),
@@ -72,18 +70,18 @@ func testAccAlternateContact_disappears(t *testing.T) {
7270
resourceName := "aws_account_alternate_contact.test"
7371
domain := acctest.RandomDomainName()
7472
emailAddress := acctest.RandomEmailAddress(domain)
75-
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
73+
rName := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
7674

77-
resource.Test(t, resource.TestCase{
75+
acctest.Test(ctx, t, resource.TestCase{
7876
PreCheck: func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
7977
ErrorCheck: acctest.ErrorCheck(t, names.AccountServiceID),
8078
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
81-
CheckDestroy: testAccCheckAlternateContactDestroy(ctx),
79+
CheckDestroy: testAccCheckAlternateContactDestroy(ctx, t),
8280
Steps: []resource.TestStep{
8381
{
8482
Config: testAccAlternateContactConfig_basic(rName, emailAddress),
8583
Check: resource.ComposeAggregateTestCheckFunc(
86-
testAccCheckAlternateContactExists(ctx, resourceName),
84+
testAccCheckAlternateContactExists(ctx, t, resourceName),
8785
acctest.CheckResourceDisappears(ctx, acctest.Provider, tfaccount.ResourceAlternateContact(), resourceName),
8886
),
8987
ExpectNonEmptyPlan: true,
@@ -98,10 +96,10 @@ func testAccAlternateContact_accountID(t *testing.T) { // nosemgrep:ci.account-i
9896
domain := acctest.RandomDomainName()
9997
emailAddress1 := acctest.RandomEmailAddress(domain)
10098
emailAddress2 := acctest.RandomEmailAddress(domain)
101-
rName1 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
102-
rName2 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
99+
rName1 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
100+
rName2 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
103101

104-
resource.Test(t, resource.TestCase{
102+
acctest.Test(ctx, t, resource.TestCase{
105103
PreCheck: func() {
106104
acctest.PreCheck(ctx, t)
107105
acctest.PreCheckAlternateAccount(t)
@@ -110,12 +108,12 @@ func testAccAlternateContact_accountID(t *testing.T) { // nosemgrep:ci.account-i
110108
},
111109
ErrorCheck: acctest.ErrorCheck(t, names.AccountServiceID),
112110
ProtoV5ProviderFactories: acctest.ProtoV5FactoriesAlternate(ctx, t),
113-
CheckDestroy: testAccCheckAlternateContactDestroy(ctx),
111+
CheckDestroy: testAccCheckAlternateContactDestroy(ctx, t),
114112
Steps: []resource.TestStep{
115113
{
116114
Config: testAccAlternateContactConfig_organization(rName1, emailAddress1),
117115
Check: resource.ComposeAggregateTestCheckFunc(
118-
testAccCheckAlternateContactExists(ctx, resourceName),
116+
testAccCheckAlternateContactExists(ctx, t, resourceName),
119117
resource.TestCheckResourceAttrSet(resourceName, names.AttrAccountID),
120118
resource.TestCheckResourceAttr(resourceName, "alternate_contact_type", "OPERATIONS"),
121119
resource.TestCheckResourceAttr(resourceName, "email_address", emailAddress1),
@@ -132,7 +130,7 @@ func testAccAlternateContact_accountID(t *testing.T) { // nosemgrep:ci.account-i
132130
{
133131
Config: testAccAlternateContactConfig_organization(rName2, emailAddress2),
134132
Check: resource.ComposeAggregateTestCheckFunc(
135-
testAccCheckAlternateContactExists(ctx, resourceName),
133+
testAccCheckAlternateContactExists(ctx, t, resourceName),
136134
resource.TestCheckResourceAttrSet(resourceName, names.AttrAccountID),
137135
resource.TestCheckResourceAttr(resourceName, "alternate_contact_type", "OPERATIONS"),
138136
resource.TestCheckResourceAttr(resourceName, "email_address", emailAddress2),
@@ -145,9 +143,9 @@ func testAccAlternateContact_accountID(t *testing.T) { // nosemgrep:ci.account-i
145143
})
146144
}
147145

148-
func testAccCheckAlternateContactDestroy(ctx context.Context) resource.TestCheckFunc {
146+
func testAccCheckAlternateContactDestroy(ctx context.Context, t *testing.T) resource.TestCheckFunc {
149147
return func(s *terraform.State) error {
150-
conn := acctest.Provider.Meta().(*conns.AWSClient).AccountClient(ctx)
148+
conn := acctest.ProviderMeta(ctx, t).AccountClient(ctx)
151149

152150
for _, rs := range s.RootModule().Resources {
153151
if rs.Type != "aws_account_alternate_contact" {
@@ -162,7 +160,7 @@ func testAccCheckAlternateContactDestroy(ctx context.Context) resource.TestCheck
162160

163161
_, err = tfaccount.FindAlternateContactByTwoPartKey(ctx, conn, accountID, contactType)
164162

165-
if tfresource.NotFound(err) {
163+
if retry.NotFound(err) {
166164
continue
167165
}
168166

@@ -177,7 +175,7 @@ func testAccCheckAlternateContactDestroy(ctx context.Context) resource.TestCheck
177175
}
178176
}
179177

180-
func testAccCheckAlternateContactExists(ctx context.Context, n string) resource.TestCheckFunc {
178+
func testAccCheckAlternateContactExists(ctx context.Context, t *testing.T, n string) resource.TestCheckFunc {
181179
return func(s *terraform.State) error {
182180
rs, ok := s.RootModule().Resources[n]
183181
if !ok {
@@ -194,7 +192,7 @@ func testAccCheckAlternateContactExists(ctx context.Context, n string) resource.
194192
return err
195193
}
196194

197-
conn := acctest.Provider.Meta().(*conns.AWSClient).AccountClient(ctx)
195+
conn := acctest.ProviderMeta(ctx, t).AccountClient(ctx)
198196

199197
_, err = tfaccount.FindAlternateContactByTwoPartKey(ctx, conn, accountID, contactType)
200198

@@ -234,15 +232,15 @@ resource "aws_account_alternate_contact" "test" {
234232
}
235233

236234
func testAccPreCheck(ctx context.Context, t *testing.T) {
237-
conn := acctest.Provider.Meta().(*conns.AWSClient).AccountClient(ctx)
235+
conn := acctest.ProviderMeta(ctx, t).AccountClient(ctx)
238236

239237
_, err := tfaccount.FindAlternateContactByTwoPartKey(ctx, conn, "", string(types.AlternateContactTypeOperations))
240238

241239
if acctest.PreCheckSkipError(err) {
242240
t.Skipf("skipping acceptance testing: %s", err)
243241
}
244242

245-
if err != nil && !tfresource.NotFound(err) {
243+
if err != nil && !retry.NotFound(err) {
246244
t.Fatalf("unexpected PreCheck error: %s", err)
247245
}
248246
}

internal/service/account/primary_contact.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import (
1212
"github.com/aws/aws-sdk-go-v2/service/account"
1313
"github.com/aws/aws-sdk-go-v2/service/account/types"
1414
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
15-
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
1615
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1716
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
1817
"github.com/hashicorp/terraform-provider-aws/internal/conns"
1918
"github.com/hashicorp/terraform-provider-aws/internal/errs"
2019
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
20+
"github.com/hashicorp/terraform-provider-aws/internal/retry"
2121
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
2222
"github.com/hashicorp/terraform-provider-aws/internal/verify"
2323
"github.com/hashicorp/terraform-provider-aws/names"
@@ -163,7 +163,7 @@ func resourcePrimaryContactRead(ctx context.Context, d *schema.ResourceData, met
163163

164164
contactInformation, err := findContactInformation(ctx, conn, d.Get(names.AttrAccountID).(string))
165165

166-
if !d.IsNewResource() && tfresource.NotFound(err) {
166+
if !d.IsNewResource() && retry.NotFound(err) {
167167
log.Printf("[WARN] Account Primary Contact (%s) not found, removing from state", d.Id())
168168
d.SetId("")
169169
return diags
@@ -200,8 +200,7 @@ func findContactInformation(ctx context.Context, conn *account.Client, accountID
200200

201201
if errs.IsA[*types.ResourceNotFoundException](err) {
202202
return nil, &retry.NotFoundError{
203-
LastError: err,
204-
LastRequest: input,
203+
LastError: err,
205204
}
206205
}
207206

internal/service/account/primary_contact_data_source_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func testAccPrimaryContactDataSource_basic(t *testing.T) {
1616
resourceName := "aws_account_primary_contact.test"
1717
dataSourceName := "data.aws_account_primary_contact.test"
1818

19-
resource.Test(t, resource.TestCase{
19+
acctest.Test(ctx, t, resource.TestCase{
2020
PreCheck: func() { acctest.PreCheck(ctx, t) },
2121
ErrorCheck: acctest.ErrorCheck(t, names.AccountServiceID),
2222
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
@@ -48,7 +48,7 @@ func testAccPrimaryContactDataSource_accountID(t *testing.T) {
4848
resourceName := "aws_account_primary_contact.test"
4949
dataSourceName := "data.aws_account_primary_contact.test"
5050

51-
resource.Test(t, resource.TestCase{
51+
acctest.Test(ctx, t, resource.TestCase{
5252
PreCheck: func() {
5353
acctest.PreCheck(ctx, t)
5454
acctest.PreCheckAlternateAccount(t)

internal/service/account/primary_contact_test.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,20 @@ import (
88
"fmt"
99
"testing"
1010

11-
sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
1211
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
1312
"github.com/hashicorp/terraform-plugin-testing/terraform"
1413
"github.com/hashicorp/terraform-provider-aws/internal/acctest"
15-
"github.com/hashicorp/terraform-provider-aws/internal/conns"
1614
tfaccount "github.com/hashicorp/terraform-provider-aws/internal/service/account"
1715
"github.com/hashicorp/terraform-provider-aws/names"
1816
)
1917

2018
func testAccPrimaryContact_basic(t *testing.T) {
2119
ctx := acctest.Context(t)
2220
resourceName := "aws_account_primary_contact.test"
23-
rName1 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
24-
rName2 := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
21+
rName1 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
22+
rName2 := acctest.RandomWithPrefix(t, acctest.ResourcePrefix)
2523

26-
resource.Test(t, resource.TestCase{
24+
acctest.Test(ctx, t, resource.TestCase{
2725
PreCheck: func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
2826
ErrorCheck: acctest.ErrorCheck(t, names.AccountServiceID),
2927
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
@@ -32,7 +30,7 @@ func testAccPrimaryContact_basic(t *testing.T) {
3230
{
3331
Config: testAccPrimaryConfig_basic(rName1),
3432
Check: resource.ComposeAggregateTestCheckFunc(
35-
testAccCheckPrimaryContactExists(ctx, resourceName),
33+
testAccCheckPrimaryContactExists(ctx, t, resourceName),
3634
resource.TestCheckResourceAttr(resourceName, names.AttrAccountID, ""),
3735
resource.TestCheckResourceAttr(resourceName, "address_line_1", "123 Any Street"),
3836
resource.TestCheckResourceAttr(resourceName, "city", "Seattle"),
@@ -54,7 +52,7 @@ func testAccPrimaryContact_basic(t *testing.T) {
5452
{
5553
Config: testAccPrimaryConfig_basic(rName2),
5654
Check: resource.ComposeAggregateTestCheckFunc(
57-
testAccCheckPrimaryContactExists(ctx, resourceName),
55+
testAccCheckPrimaryContactExists(ctx, t, resourceName),
5856
resource.TestCheckResourceAttr(resourceName, names.AttrAccountID, ""),
5957
resource.TestCheckResourceAttr(resourceName, "address_line_1", "123 Any Street"),
6058
resource.TestCheckResourceAttr(resourceName, "city", "Seattle"),
@@ -72,7 +70,7 @@ func testAccPrimaryContact_basic(t *testing.T) {
7270
})
7371
}
7472

75-
func testAccCheckPrimaryContactExists(ctx context.Context, n string) resource.TestCheckFunc {
73+
func testAccCheckPrimaryContactExists(ctx context.Context, t *testing.T, n string) resource.TestCheckFunc {
7674
return func(s *terraform.State) error {
7775
rs, ok := s.RootModule().Resources[n]
7876
if !ok {
@@ -83,7 +81,7 @@ func testAccCheckPrimaryContactExists(ctx context.Context, n string) resource.Te
8381
return fmt.Errorf("No Account Primary Contact ID is set")
8482
}
8583

86-
conn := acctest.Provider.Meta().(*conns.AWSClient).AccountClient(ctx)
84+
conn := acctest.ProviderMeta(ctx, t).AccountClient(ctx)
8785

8886
_, err := tfaccount.FindContactInformation(ctx, conn, rs.Primary.Attributes[names.AttrAccountID])
8987

internal/service/account/region.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ import (
1212
"github.com/aws/aws-sdk-go-v2/service/account"
1313
"github.com/aws/aws-sdk-go-v2/service/account/types"
1414
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
15-
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
1615
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1716
"github.com/hashicorp/terraform-provider-aws/internal/conns"
1817
"github.com/hashicorp/terraform-provider-aws/internal/enum"
1918
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
2019
"github.com/hashicorp/terraform-provider-aws/internal/flex"
20+
"github.com/hashicorp/terraform-provider-aws/internal/retry"
2121
"github.com/hashicorp/terraform-provider-aws/internal/tfresource"
2222
"github.com/hashicorp/terraform-provider-aws/internal/verify"
2323
"github.com/hashicorp/terraform-provider-aws/names"
@@ -193,11 +193,11 @@ func findRegionOptStatus(ctx context.Context, conn *account.Client, accountID, r
193193
return output, nil
194194
}
195195

196-
func statusRegionOptStatus(ctx context.Context, conn *account.Client, accountID, region string) retry.StateRefreshFunc {
197-
return func() (any, string, error) {
196+
func statusRegionOptStatus(conn *account.Client, accountID, region string) retry.StateRefreshFunc {
197+
return func(ctx context.Context) (any, string, error) {
198198
output, err := findRegionOptStatus(ctx, conn, accountID, region)
199199

200-
if tfresource.NotFound(err) {
200+
if retry.NotFound(err) {
201201
return nil, "", nil
202202
}
203203

@@ -213,7 +213,7 @@ func waitRegionEnabled(ctx context.Context, conn *account.Client, accountID, reg
213213
stateConf := &retry.StateChangeConf{
214214
Pending: enum.Slice(types.RegionOptStatusEnabling),
215215
Target: enum.Slice(types.RegionOptStatusEnabled),
216-
Refresh: statusRegionOptStatus(ctx, conn, accountID, region),
216+
Refresh: statusRegionOptStatus(conn, accountID, region),
217217
Timeout: timeout,
218218
PollInterval: 30 * time.Second,
219219
}
@@ -231,7 +231,7 @@ func waitRegionDisabled(ctx context.Context, conn *account.Client, accountID, re
231231
stateConf := &retry.StateChangeConf{
232232
Pending: enum.Slice(types.RegionOptStatusDisabling),
233233
Target: enum.Slice(types.RegionOptStatusDisabled),
234-
Refresh: statusRegionOptStatus(ctx, conn, accountID, region),
234+
Refresh: statusRegionOptStatus(conn, accountID, region),
235235
Timeout: timeout,
236236
PollInterval: 30 * time.Second,
237237
}

internal/service/account/region_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"github.com/hashicorp/aws-sdk-go-base/v2/endpoints"
1313
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
1414
"github.com/hashicorp/terraform-provider-aws/internal/acctest"
15-
"github.com/hashicorp/terraform-provider-aws/internal/conns"
1615
tfaccount "github.com/hashicorp/terraform-provider-aws/internal/service/account"
1716
"github.com/hashicorp/terraform-provider-aws/names"
1817
)
@@ -22,7 +21,7 @@ func testAccRegion_basic(t *testing.T) {
2221
resourceName := "aws_account_region.test"
2322
regionName := endpoints.ApSoutheast3RegionID
2423

25-
resource.Test(t, resource.TestCase{
24+
acctest.Test(ctx, t, resource.TestCase{
2625
PreCheck: func() {
2726
acctest.PreCheck(ctx, t)
2827
testAccPreCheckRegionDisabled(ctx, t, regionName)
@@ -64,7 +63,7 @@ func testAccRegion_accountID(t *testing.T) { // nosemgrep:ci.account-in-func-nam
6463
resourceName := "aws_account_region.test"
6564
regionName := endpoints.ApSoutheast3RegionID
6665

67-
resource.Test(t, resource.TestCase{
66+
acctest.Test(ctx, t, resource.TestCase{
6867
PreCheck: func() {
6968
acctest.PreCheck(ctx, t)
7069
acctest.PreCheckAlternateAccount(t)
@@ -105,7 +104,7 @@ func testAccRegion_accountID(t *testing.T) { // nosemgrep:ci.account-in-func-nam
105104
func testAccPreCheckRegionDisabled(ctx context.Context, t *testing.T, region string) {
106105
t.Helper()
107106

108-
conn := acctest.Provider.Meta().(*conns.AWSClient).AccountClient(ctx)
107+
conn := acctest.ProviderMeta(ctx, t).AccountClient(ctx)
109108

110109
output, err := tfaccount.FindRegionOptStatus(ctx, conn, "", region)
111110

0 commit comments

Comments
 (0)