r/aws_servicecatalog_portfolio_share: tidy up

```console
% AWS_ALTERNATE_PROFILE=terraform_team1_dev make t K=servicecatalog T=TestAccServiceCatalog_serial/PortfolioShare
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_servicecatalog_portfolio_share-sequential-processing 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalog_serial/PortfolioShare'  -timeout 360m -vet=off
2025/10/08 15:15:43 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/08 15:15:43 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccServiceCatalog_serial (218.61s)
    --- PASS: TestAccServiceCatalog_serial/PortfolioShare (218.61s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/basic (39.27s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/sharePrincipals (0.47s)
        --- SKIP: TestAccServiceCatalog_serial/PortfolioShare/organizationalUnit (2.42s)
        --- PASS: TestAccServiceCatalog_serial/PortfolioShare/disappears (176.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     225.373s
```

Author: jar-b

internal/service/servicecatalog/portfolio_share.go

@@ -107,7 +107,7 @@ func resourcePortfolioShareCreate(ctx context.Context, d *schema.ResourceData, m
 	var diags diag.Diagnostics
 	conn := meta.(*conns.AWSClient).ServiceCatalogClient(ctx)
 
-	input := &servicecatalog.CreatePortfolioShareInput{
+	input := servicecatalog.CreatePortfolioShareInput{
 		PortfolioId:     aws.String(d.Get("portfolio_id").(string)),
 		SharePrincipals: d.Get("share_principals").(bool),
 		AcceptLanguage:  aws.String(d.Get("accept_language").(string)),
@@ -140,7 +140,7 @@ func resourcePortfolioShareCreate(ctx context.Context, d *schema.ResourceData, m
 	err := tfresource.Retry(ctx, d.Timeout(schema.TimeoutCreate), func(ctx context.Context) *tfresource.RetryError {
 		var err error
 
-		output, err = conn.CreatePortfolioShare(ctx, input)
+		output, err = conn.CreatePortfolioShare(ctx, &input)
 
 		if errs.IsAErrorMessageContains[*awstypes.InvalidParametersException](err, "profile does not exist") {
 			return tfresource.RetryableError(err)
@@ -224,7 +224,7 @@ func resourcePortfolioShareUpdate(ctx context.Context, d *schema.ResourceData, m
 	var diags diag.Diagnostics
 	conn := meta.(*conns.AWSClient).ServiceCatalogClient(ctx)
 
-	input := &servicecatalog.UpdatePortfolioShareInput{
+	input := servicecatalog.UpdatePortfolioShareInput{
 		PortfolioId:    aws.String(d.Get("portfolio_id").(string)),
 		AcceptLanguage: aws.String(d.Get("accept_language").(string)),
 	}
@@ -254,7 +254,7 @@ func resourcePortfolioShareUpdate(ctx context.Context, d *schema.ResourceData, m
 	}
 
 	err := tfresource.Retry(ctx, d.Timeout(schema.TimeoutUpdate), func(ctx context.Context) *tfresource.RetryError {
-		_, err := conn.UpdatePortfolioShare(ctx, input)
+		_, err := conn.UpdatePortfolioShare(ctx, &input)
 
 		if errs.IsAErrorMessageContains[*awstypes.InvalidParametersException](err, "profile does not exist") {
 			return tfresource.RetryableError(err)
@@ -278,7 +278,7 @@ func resourcePortfolioShareDelete(ctx context.Context, d *schema.ResourceData, m
 	var diags diag.Diagnostics
 	conn := meta.(*conns.AWSClient).ServiceCatalogClient(ctx)
 
-	input := &servicecatalog.DeletePortfolioShareInput{
+	input := servicecatalog.DeletePortfolioShareInput{
 		PortfolioId: aws.String(d.Get("portfolio_id").(string)),
 	}
 
@@ -305,7 +305,7 @@ func resourcePortfolioShareDelete(ctx context.Context, d *schema.ResourceData, m
 	conns.GlobalMutexKV.Lock(portfolioShareMutexKey)
 	defer conns.GlobalMutexKV.Unlock(portfolioShareMutexKey)
 
-	output, err := conn.DeletePortfolioShare(ctx, input)
+	output, err := conn.DeletePortfolioShare(ctx, &input)
 
 	if errs.IsA[*awstypes.ResourceNotFoundException](err) {
 		return diags

internal/service/servicecatalog/wait.go

@@ -167,10 +167,10 @@ func waitPortfolioShareReady(ctx context.Context, conn *servicecatalog.Client, p
 	return nil, err
 }
 
-func waitPortfolioShareCreatedWithToken(ctx context.Context, conn *servicecatalog.Client, token string, acceptRequired bool, timeout time.Duration) (*servicecatalog.DescribePortfolioShareStatusOutput, error) {
+func waitPortfolioShareCreatedWithToken(ctx context.Context, conn *servicecatalog.Client, token string, waitForAcceptance bool, timeout time.Duration) (*servicecatalog.DescribePortfolioShareStatusOutput, error) {
 	targets := enum.Slice(awstypes.ShareStatusCompleted)
 
-	if !acceptRequired {
+	if !waitForAcceptance {
 		targets = append(targets, string(awstypes.ShareStatusInProgress))
 	}