Skip to content

Commit 7f85b68

Browse files
committed
Remove TestAccECSService_AvailabilityZoneRebalancing_UpgradeV6_8_0_ acceptance tests
1 parent 59863e5 commit 7f85b68

File tree

1 file changed

+3
-109
lines changed

1 file changed

+3
-109
lines changed

internal/service/ecs/service_test.go

Lines changed: 3 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,7 +1106,7 @@ func TestAccECSService_BlueGreenDeployment_sigintRollback(t *testing.T) {
11061106
Config: testAccServiceConfig_blueGreenDeployment_withHookBehavior(rName, false),
11071107
PreConfig: func() {
11081108
go func() {
1109-
_ = exec.Command("go", "run", "test-fixtures/sigint_helper.go", "30").Start() //lintignore:XR007
1109+
_ = exec.Command("go", "run", "test-fixtures/sigint_helper.go", "30").Start() // lintignore:XR007
11101110
}()
11111111
},
11121112
ExpectError: regexache.MustCompile("execution halted|context canceled"),
@@ -2656,7 +2656,7 @@ func TestAccECSService_AvailabilityZoneRebalancing(t *testing.T) {
26562656
CheckDestroy: testAccCheckServiceDestroy(ctx),
26572657
Steps: []resource.TestStep{
26582658
{
2659-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, awstypes.AvailabilityZoneRebalancingEnabled),
2659+
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, "null"),
26602660
Check: resource.ComposeTestCheckFunc(
26612661
testAccCheckServiceExists(ctx, resourceName, &service),
26622662
),
@@ -2670,7 +2670,7 @@ func TestAccECSService_AvailabilityZoneRebalancing(t *testing.T) {
26702670
},
26712671
},
26722672
{
2673-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, "null"),
2673+
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, awstypes.AvailabilityZoneRebalancingEnabled),
26742674
Check: resource.ComposeTestCheckFunc(
26752675
testAccCheckServiceExists(ctx, resourceName, &service),
26762676
),
@@ -2729,112 +2729,6 @@ func TestAccECSService_AvailabilityZoneRebalancing(t *testing.T) {
27292729
})
27302730
}
27312731

2732-
func TestAccECSService_AvailabilityZoneRebalancing_UpgradeV6_8_0_configured(t *testing.T) {
2733-
ctx := acctest.Context(t)
2734-
var service awstypes.Service
2735-
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
2736-
resourceName := "aws_ecs_service.test"
2737-
2738-
resource.ParallelTest(t, resource.TestCase{
2739-
PreCheck: func() { acctest.PreCheck(ctx, t) },
2740-
ErrorCheck: acctest.ErrorCheck(t, names.ECSServiceID),
2741-
CheckDestroy: testAccCheckServiceDestroy(ctx),
2742-
Steps: []resource.TestStep{
2743-
{
2744-
ExternalProviders: map[string]resource.ExternalProvider{
2745-
"aws": {
2746-
Source: "hashicorp/aws",
2747-
VersionConstraint: "6.8.0",
2748-
},
2749-
},
2750-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, awstypes.AvailabilityZoneRebalancingEnabled),
2751-
Check: resource.ComposeTestCheckFunc(
2752-
testAccCheckServiceExists(ctx, resourceName, &service),
2753-
),
2754-
ConfigPlanChecks: resource.ConfigPlanChecks{
2755-
PreApply: []plancheck.PlanCheck{
2756-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionCreate),
2757-
},
2758-
},
2759-
ConfigStateChecks: []statecheck.StateCheck{
2760-
statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("availability_zone_rebalancing"), tfknownvalue.StringExact(awstypes.AvailabilityZoneRebalancingEnabled)),
2761-
},
2762-
},
2763-
{
2764-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
2765-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, awstypes.AvailabilityZoneRebalancingEnabled),
2766-
Check: resource.ComposeTestCheckFunc(
2767-
testAccCheckServiceExists(ctx, resourceName, &service),
2768-
),
2769-
ConfigPlanChecks: resource.ConfigPlanChecks{
2770-
PreApply: []plancheck.PlanCheck{
2771-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
2772-
},
2773-
PostApplyPostRefresh: []plancheck.PlanCheck{
2774-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
2775-
},
2776-
},
2777-
ConfigStateChecks: []statecheck.StateCheck{
2778-
statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("availability_zone_rebalancing"), tfknownvalue.StringExact(awstypes.AvailabilityZoneRebalancingEnabled)),
2779-
},
2780-
},
2781-
},
2782-
})
2783-
}
2784-
2785-
func TestAccECSService_AvailabilityZoneRebalancing_UpgradeV6_8_0_unconfigured(t *testing.T) {
2786-
ctx := acctest.Context(t)
2787-
var service awstypes.Service
2788-
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
2789-
resourceName := "aws_ecs_service.test"
2790-
2791-
resource.ParallelTest(t, resource.TestCase{
2792-
PreCheck: func() { acctest.PreCheck(ctx, t) },
2793-
ErrorCheck: acctest.ErrorCheck(t, names.ECSServiceID),
2794-
CheckDestroy: testAccCheckServiceDestroy(ctx),
2795-
Steps: []resource.TestStep{
2796-
{
2797-
ExternalProviders: map[string]resource.ExternalProvider{
2798-
"aws": {
2799-
Source: "hashicorp/aws",
2800-
VersionConstraint: "6.8.0",
2801-
},
2802-
},
2803-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, "null"),
2804-
Check: resource.ComposeTestCheckFunc(
2805-
testAccCheckServiceExists(ctx, resourceName, &service),
2806-
),
2807-
ConfigPlanChecks: resource.ConfigPlanChecks{
2808-
PreApply: []plancheck.PlanCheck{
2809-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionCreate),
2810-
},
2811-
},
2812-
ConfigStateChecks: []statecheck.StateCheck{
2813-
statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("availability_zone_rebalancing"), tfknownvalue.StringExact(awstypes.AvailabilityZoneRebalancingDisabled)),
2814-
},
2815-
},
2816-
{
2817-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
2818-
Config: testAccServiceConfig_availabilityZoneRebalancing(rName, "null"),
2819-
Check: resource.ComposeTestCheckFunc(
2820-
testAccCheckServiceExists(ctx, resourceName, &service),
2821-
),
2822-
ConfigPlanChecks: resource.ConfigPlanChecks{
2823-
PreApply: []plancheck.PlanCheck{
2824-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
2825-
},
2826-
PostApplyPostRefresh: []plancheck.PlanCheck{
2827-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
2828-
},
2829-
},
2830-
ConfigStateChecks: []statecheck.StateCheck{
2831-
statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("availability_zone_rebalancing"), tfknownvalue.StringExact(awstypes.AvailabilityZoneRebalancingDisabled)),
2832-
},
2833-
},
2834-
},
2835-
})
2836-
}
2837-
28382732
func testAccCheckServiceDestroy(ctx context.Context) resource.TestCheckFunc {
28392733
return func(s *terraform.State) error {
28402734
conn := acctest.Provider.Meta().(*conns.AWSClient).ECSClient(ctx)

0 commit comments

Comments
 (0)