Skip to content

Commit 851e6ce

Browse files
committed
Generates Identity_ExistingResource_NoRefresh_NoChange test for SDK resource types with v6.0 null values error
1 parent a2a53ee commit 851e6ce

File tree

3 files changed

+110
-53
lines changed

3 files changed

+110
-53
lines changed

internal/generate/identitytests/resource_test.go.gtpl

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -862,6 +862,59 @@ func {{ template "testname" . }}_Identity_RegionOverride(t *testing.T) {
862862
},
863863
})
864864
}
865+
866+
func {{ template "testname" . }}_Identity_ExistingResource_NoRefresh_NoChange(t *testing.T) {
867+
{{- template "Init" . }}
868+
869+
{{ template "Test" . }}(ctx, t, resource.TestCase{
870+
{{ template "TestCaseSetupNoProviders" . }}
871+
AdditionalCLIOptions: &resource.AdditionalCLIOptions{
872+
Plan: resource.PlanOptions{
873+
NoRefresh: true,
874+
},
875+
},
876+
Steps: []resource.TestStep{
877+
{{ $step := 1 -}}
878+
// Step {{ $step }}: Create pre-Identity
879+
{
880+
ConfigDirectory: config.StaticDirectory("testdata/{{ .Name }}/basic_v5.100.0/"),
881+
ConfigVariables: config.Variables{ {{ if .Generator }}
882+
acctest.CtRName: config.StringVariable(rName),{{ end }}
883+
{{ template "AdditionalTfVars" . }}
884+
},
885+
{{ if .HasExistsFunc -}}
886+
Check: resource.ComposeAggregateTestCheckFunc(
887+
{{- template "ExistsCheck" . -}}
888+
),
889+
{{ end -}}
890+
ConfigStateChecks: []statecheck.StateCheck{
891+
tfstatecheck.ExpectNoIdentity(resourceName),
892+
},
893+
},
894+
895+
// Step {{ ($step = inc $step) | print }}: Current version
896+
{
897+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
898+
ConfigDirectory: config.StaticDirectory("testdata/{{ .Name }}/basic/"),
899+
ConfigVariables: config.Variables{ {{ if .Generator }}
900+
acctest.CtRName: config.StringVariable(rName),{{ end }}
901+
{{ template "AdditionalTfVars" . }}
902+
},
903+
ConfigPlanChecks: resource.ConfigPlanChecks{
904+
PreApply: []plancheck.PlanCheck{
905+
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
906+
},
907+
PostApplyPostRefresh: []plancheck.PlanCheck{
908+
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
909+
},
910+
},
911+
ConfigStateChecks: []statecheck.StateCheck{
912+
tfstatecheck.ExpectNoIdentity(resourceName),
913+
},
914+
},
915+
},
916+
})
917+
}
865918
{{ else if .PreIdentityVersion }}
866919
{{ if .PreIdentityVersion.GreaterThanOrEqual (NewVersion "6.0.0") }}
867920
// Resource Identity was added after v{{ .PreIdentityVersion }}

internal/service/iam/role_identity_gen_test.go

Lines changed: 57 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/iam/role_test.go

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1034,59 +1034,6 @@ func TestAccIAMRole_Identity_ExistingResource_NoRefresh_WithChange(t *testing.T)
10341034
})
10351035
}
10361036

1037-
func TestAccIAMRole_Identity_ExistingResource_NoRefresh_NoChange(t *testing.T) {
1038-
ctx := acctest.Context(t)
1039-
var conf awstypes.Role
1040-
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
1041-
resourceName := "aws_iam_role.test"
1042-
1043-
resource.ParallelTest(t, resource.TestCase{
1044-
PreCheck: func() { acctest.PreCheck(ctx, t) },
1045-
ErrorCheck: acctest.ErrorCheck(t, names.IAMServiceID),
1046-
CheckDestroy: testAccCheckRoleDestroy(ctx),
1047-
AdditionalCLIOptions: &resource.AdditionalCLIOptions{
1048-
Plan: resource.PlanOptions{
1049-
NoRefresh: true,
1050-
},
1051-
},
1052-
Steps: []resource.TestStep{
1053-
{
1054-
ExternalProviders: map[string]resource.ExternalProvider{
1055-
"aws": {
1056-
Source: "hashicorp/aws",
1057-
VersionConstraint: "5.100.0",
1058-
},
1059-
},
1060-
Config: testAccRoleConfig_basic(rName),
1061-
Check: resource.ComposeAggregateTestCheckFunc(
1062-
testAccCheckRoleExists(ctx, resourceName, &conf),
1063-
),
1064-
ConfigStateChecks: []statecheck.StateCheck{
1065-
tfstatecheck.ExpectNoIdentity(resourceName),
1066-
},
1067-
},
1068-
{
1069-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
1070-
Config: testAccRoleConfig_basic(rName),
1071-
Check: resource.ComposeAggregateTestCheckFunc(
1072-
testAccCheckRoleExists(ctx, resourceName, &conf),
1073-
),
1074-
ConfigPlanChecks: resource.ConfigPlanChecks{
1075-
PreApply: []plancheck.PlanCheck{
1076-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
1077-
},
1078-
PostApplyPostRefresh: []plancheck.PlanCheck{
1079-
plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
1080-
},
1081-
},
1082-
ConfigStateChecks: []statecheck.StateCheck{
1083-
tfstatecheck.ExpectNoIdentity(resourceName),
1084-
},
1085-
},
1086-
},
1087-
})
1088-
}
1089-
10901037
func TestAccIAMRole_Identity_ExistingResource_NoRefresh_OnError(t *testing.T) {
10911038
ctx := acctest.Context(t)
10921039
var conf awstypes.Role

0 commit comments

Comments
 (0)