Skip to content

Commit 8757ded

Browse files
authored
Merge pull request #44348 from hashicorp/f-go-vcr-polly
polly: enable `go-vcr` support
2 parents 8929855 + 23f0113 commit 8757ded

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# Adding `go-vcr` Support
2+
3+
You are working on the [Terraform AWS Provider](https://github.com/hashicorp/terraform-provider-aws), specifically focused on enabling support for `go-vcr`.
4+
5+
Follow the steps below to enable support for a single service.
6+
7+
- The working branch name should begin with `f-go-vcr-` and be suffixed with the name of the service being updated, e.g. `f-go-vcr-s3`. If the current branch does not match this convention, create one. Ensure the branch is rebased with the `main` branch.
8+
- Follow the steps on [this page](../go-vcr.md) to enable `go-vcr` for the target service.
9+
- Once all acceptace tests are passing, commit the changes with a message like "service-name: enable `go-vcr` support", replacing `service-name` with the target service. Be sure to include the COMPLETE output from acceptance testing in the commit body, wrapped in a `console` code block. e.g.
10+
11+
```console
12+
% make testacc PKG=polly VCR_MODE=REPLAY_ONLY VCR_PATH=/tmp/polly-vcr-testdata/
13+
14+
<-- full results here -->
15+
```

internal/service/polly/voices_data_source_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func TestAccPollyVoicesDataSource_basic(t *testing.T) {
1717
ctx := acctest.Context(t)
1818
dataSourceName := "data.aws_polly_voices.test"
1919

20-
resource.ParallelTest(t, resource.TestCase{
20+
acctest.ParallelTest(ctx, t, resource.TestCase{
2121
PreCheck: func() {
2222
acctest.PreCheck(ctx, t)
2323
acctest.PreCheckPartitionHasService(t, names.PollyEndpointID)
@@ -45,7 +45,7 @@ func TestAccPollyVoicesDataSource_languageCode(t *testing.T) {
4545
ctx := acctest.Context(t)
4646
dataSourceName := "data.aws_polly_voices.test"
4747

48-
resource.ParallelTest(t, resource.TestCase{
48+
acctest.ParallelTest(ctx, t, resource.TestCase{
4949
PreCheck: func() {
5050
acctest.PreCheck(ctx, t)
5151
acctest.PreCheckPartitionHasService(t, names.PollyEndpointID)

0 commit comments

Comments
 (0)