fixed linter check

Author: ab-cs13

internal/service/odb/db_node_data_source_test.go

@@ -43,6 +43,11 @@ func TestAccODBDBNodeDataSource_basic(t *testing.T) {
 	if testing.Short() {
 		t.Skip("skipping long-running test in short mode")
 	}
+	publicKey, _, err := sdkacctest.RandSSHKeyPair(acctest.DefaultEmailAddress)
+	if err != nil {
+		t.Fatal(err)
+		return
+	}
 	var dbNode odb.GetDbNodeOutput
 	dataSourceName := "data.aws_odb_db_node.test"
 	resource.ParallelTest(t, resource.TestCase{
@@ -54,7 +59,7 @@ func TestAccODBDBNodeDataSource_basic(t *testing.T) {
 		CheckDestroy:             dbNodeDataSourceTestEntity.testAccCheckDBNodeDestroyed(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: dbNodeDataSourceTestEntity.dbNodeDataSourceBasicConfig(),
+				Config: dbNodeDataSourceTestEntity.dbNodeDataSourceBasicConfig(publicKey),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					dbNodeDataSourceTestEntity.testAccCheckDBNodeExists(ctx, dataSourceName, &dbNode),
 				),
@@ -126,8 +131,8 @@ func (testDbNodeDataSourceTest) findVmCluster(ctx context.Context, conn *odb.Cli
 	return nil
 }
 
-func (testDbNodeDataSourceTest) dbNodeDataSourceBasicConfig() string {
-	vmClusterConfig := dbNodeDataSourceTestEntity.vmClusterBasicConfig()
+func (testDbNodeDataSourceTest) dbNodeDataSourceBasicConfig(publicKey string) string {
+	vmClusterConfig := dbNodeDataSourceTestEntity.vmClusterBasicConfig(publicKey)
 
 	return fmt.Sprintf(`
 %s
@@ -144,14 +149,10 @@ data "aws_odb_db_node" "test" {
 `, vmClusterConfig)
 }
 
-func (testDbNodeDataSourceTest) vmClusterBasicConfig() string {
+func (testDbNodeDataSourceTest) vmClusterBasicConfig(publicKey string) string {
 	exaInfraDisplayName := sdkacctest.RandomWithPrefix(dbNodeDataSourceTestEntity.exaDisplayNamePrefix)
 	oracleDBNetDisplayName := sdkacctest.RandomWithPrefix(dbNodeDataSourceTestEntity.oracleDBNetworkDisplayNamePrefix)
 	vmcDisplayName := sdkacctest.RandomWithPrefix(dbNodeDataSourceTestEntity.vmClusterDisplayNamePrefix)
-	publicKey, _, err := sdkacctest.RandSSHKeyPair(acctest.DefaultEmailAddress)
-	if err != nil {
-		panic(err)
-	}
 	dsTfCodeVmCluster := fmt.Sprintf(`
 
 

internal/service/odb/db_nodes_list_data_source_test.go

@@ -44,7 +44,11 @@ func TestAccODBDBNodesListDataSource_basic(t *testing.T) {
 	if testing.Short() {
 		t.Skip("skipping long-running test in short mode")
 	}
-
+	publicKey, _, err := sdkacctest.RandSSHKeyPair(acctest.DefaultEmailAddress)
+	if err != nil {
+		t.Fatal(err)
+		return
+	}
 	var dbNodesList odb.ListDbNodesOutput
 	dbNodesListsDataSourceName := "data.aws_odb_db_nodes_list.test"
 	vmClusterListsResourceName := "aws_odb_cloud_vm_cluster.test"
@@ -58,7 +62,7 @@ func TestAccODBDBNodesListDataSource_basic(t *testing.T) {
 		CheckDestroy:             dbNodesListDataSourceTestEntity.testAccCheckDBNodesDestroyed(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: dbNodesListDataSourceTestEntity.basicDBNodesListDataSource(),
+				Config: dbNodesListDataSourceTestEntity.basicDBNodesListDataSource(publicKey),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					dbNodesListDataSourceTestEntity.testAccCheckDBNodesListExists(ctx, vmClusterListsResourceName, &dbNodesList),
 					resource.TestCheckResourceAttr(dbNodesListsDataSourceName, "aws_odb_db_nodes_list.db_nodes.#", strconv.Itoa(len(dbNodesList.DbNodes))),
@@ -133,8 +137,8 @@ func (dbNodesListDataSourceTest) findVmCluster(ctx context.Context, conn *odb.Cl
 	return output.CloudVmCluster, nil
 }
 
-func (dbNodesListDataSourceTest) basicDBNodesListDataSource() string {
-	vmCluster := dbNodesListDataSourceTestEntity.vmClusterBasic()
+func (dbNodesListDataSourceTest) basicDBNodesListDataSource(publicKey string) string {
+	vmCluster := dbNodesListDataSourceTestEntity.vmClusterBasic(publicKey)
 	return fmt.Sprintf(`
 
 	%s
@@ -145,14 +149,10 @@ data "aws_odb_db_nodes_list" "test" {
 `, vmCluster)
 }
 
-func (dbNodesListDataSourceTest) vmClusterBasic() string {
+func (dbNodesListDataSourceTest) vmClusterBasic(publicKey string) string {
 	odbNetRName := sdkacctest.RandomWithPrefix(dbNodesListDataSourceTestEntity.oracleDBNetworkDisplayNamePrefix)
 	exaInfraRName := sdkacctest.RandomWithPrefix(dbNodesListDataSourceTestEntity.exadataInfraDisplayNamePrefix)
 	vmcDisplayName := sdkacctest.RandomWithPrefix(dbNodesListDataSourceTestEntity.vmClusterDisplayNamePrefix)
-	publicKey, _, err := sdkacctest.RandSSHKeyPair(acctest.DefaultEmailAddress)
-	if err != nil {
-		panic(err)
-	}
 	return fmt.Sprintf(`
 
 resource "aws_odb_network" "test" {

internal/service/odb/db_server_data_source_test.go

@@ -34,7 +34,7 @@ var dbServerDataSourceTestEntity = testDbServerDataSourceTest{
 }
 
 // Acceptance test access AWS and cost money to run.
-func TestAccODBDBServerDataSource(t *testing.T) {
+func TestAccODBDBServerDataSource_basic(t *testing.T) {
 	ctx := acctest.Context(t)
 	if testing.Short() {
 		t.Skip("skipping long-running test in short mode")

website/docs/d/odb_db_node.html.markdown

@@ -19,7 +19,7 @@ You can find out more about Oracle Database@AWS from [User Guide](https://docs.a
 ```terraform
 data "aws_odb_db_node" "example" {
   cloud_vm_cluster_id = "cloud_vm_cluster_id"
-  id = "db_node_id"
+  id                  = "db_node_id"
 }
 ```
 
@@ -28,7 +28,7 @@ data "aws_odb_db_node" "example" {
 The following arguments are required:
 
 * `cloud_vm_cluster_id` - (Required) The unique identifier of the cloud vm cluster.
-* `id` - (Required) The unique identifier of db node associated with vm cluster. 
+* `id` - (Required) The unique identifier of db node associated with vm cluster.
 
 The following arguments are optional:
 
@@ -64,4 +64,4 @@ This data source exports the following attributes in addition to the arguments a
 * `vnic2_id` - The OCID of the second VNIC.
 * `vnic_id` - The OCID of the VNIC.
 * `private_ip_address` - The private IP address assigned to the DB node.
-* `floating_ip_address` - The floating IP address assigned to the DB node.
+* `floating_ip_address` - The floating IP address assigned to the DB node.

website/docs/d/odb_db_nodes_list.html.markdown

@@ -65,4 +65,4 @@ This data source exports the following attributes in addition to the arguments a
 * `time_maintenance_window_start` - The start date and time of the maintenance window.
 * `total_cpu_core_count` - The total number of CPU cores reserved on the DB node.
 * `vnic_2_id` - The OCID of the second VNIC.
-* `vnic_id` - The OCID of the VNIC.
+* `vnic_id` - The OCID of the VNIC.

website/docs/d/odb_db_server.html.markdown

@@ -19,7 +19,7 @@ You can find out more about Oracle Database@AWS from [User Guide](https://docs.a
 ```terraform
 data "aws_odb_db_server" "example" {
   cloud_exadata_infrastructure_id = "exadata_infra_id"
-  id = "db_server_id"
+  id                              = "db_server_id"
 }
 ```
 
@@ -56,4 +56,4 @@ This data source exports the following attributes in addition to the arguments a
 * `memory_size_in_gbs` - The allocated memory in GBs on the database server.
 * `shape` - The shape of the database server. The shape determines the amount of CPU, storage, and memory resources available.
 * `created_at` - The date and time when the database server was created.
-* `vm_cluster_ids` - The OCID of the VM clusters that are associated with the database server.
+* `vm_cluster_ids` - The OCID of the VM clusters that are associated with the database server.

website/docs/d/odb_db_servers_list.html.markdown

@@ -59,4 +59,4 @@ This data source exports the following attributes in addition to the arguments a
 * `shape` - The hardware system model of the Exadata infrastructure that the database server is hosted on. The shape determines the amount of CPU, storage, and memory resources available.
 * `status` - The current status of the database server.
 * `status_reason` - Additional information about the status of the database server.
-* `vm_cluster_ids` - The IDs of the VM clusters that are associated with the database server.
+* `vm_cluster_ids` - The IDs of the VM clusters that are associated with the database server.