linter fix and review feedback.

Author: ab-cs13

internal/service/odb/cloud_vm_cluster.go

@@ -6,7 +6,7 @@ package odb
 import (
 	"context"
 	"errors"
-	"regexp"
+	"github.com/YakDriver/regexache"
 	"strings"
 	"time"
 
@@ -74,7 +74,7 @@ func (r *resourceCloudVmCluster) Schema(ctx context.Context, req resource.Schema
 	diskRedundancyType := fwtypes.StringEnumType[odbtypes.DiskRedundancy]()
 	computeModelType := fwtypes.StringEnumType[odbtypes.ComputeModel]()
 	giVersionValidator := []validator.String{
-		stringvalidator.RegexMatches(regexp.MustCompile(MajorGiVersionPattern), "Gi version must be of the format 19.0.0.0"),
+		stringvalidator.RegexMatches(regexache.MustCompile(MajorGiVersionPattern), "Gi version must be of the format 19.0.0.0"),
 	}
 	resp.Schema = schema.Schema{
 		Attributes: map[string]schema.Attribute{
@@ -489,8 +489,8 @@ func (r *resourceCloudVmCluster) Create(ctx context.Context, req resource.Create
 	plan.HostnamePrefix = types.StringValue(hostnamePrefix)
 	plan.HostnamePrefixComputed = types.StringValue(*createdVmCluster.Hostname)
 	//scan listener port not returned by API directly
-	plan.ScanListenerPortTcp = types.Int32PointerValue(createdVmCluster.ListenerPort)
-	plan.GiVersionComputed = types.StringPointerValue(createdVmCluster.GiVersion)
+	plan.ScanListenerPortTcp = flex.Int32ToFramework(ctx, createdVmCluster.ListenerPort)
+	plan.GiVersionComputed = flex.StringToFramework(ctx, createdVmCluster.GiVersion)
 	giVersionMajor, err := getMajorGiVersion(createdVmCluster.GiVersion)
 	if err != nil {
 		resp.Diagnostics.AddError(
@@ -499,7 +499,7 @@ func (r *resourceCloudVmCluster) Create(ctx context.Context, req resource.Create
 		)
 		return
 	}
-	plan.GiVersion = types.StringPointerValue(giVersionMajor)
+	plan.GiVersion = flex.StringToFramework(ctx, giVersionMajor)
 	resp.Diagnostics.Append(flex.Flatten(ctx, createdVmCluster, &plan)...)
 	if resp.Diagnostics.HasError() {
 		return
@@ -532,8 +532,8 @@ func (r *resourceCloudVmCluster) Read(ctx context.Context, req resource.ReadRequ
 	state.HostnamePrefix = types.StringValue(hostnamePrefix)
 	state.HostnamePrefixComputed = types.StringValue(*out.Hostname)
 	//scan listener port not returned by API directly
-	state.ScanListenerPortTcp = types.Int32PointerValue(out.ListenerPort)
-	state.GiVersionComputed = types.StringPointerValue(out.GiVersion)
+	state.ScanListenerPortTcp = flex.Int32ToFramework(ctx, out.ListenerPort)
+	state.GiVersionComputed = flex.StringToFramework(ctx, out.GiVersion)
 	giVersionMajor, err := getMajorGiVersion(out.GiVersion)
 	if err != nil {
 		resp.Diagnostics.AddError(
@@ -542,7 +542,7 @@ func (r *resourceCloudVmCluster) Read(ctx context.Context, req resource.ReadRequ
 		)
 		return
 	}
-	state.GiVersion = types.StringPointerValue(giVersionMajor)
+	state.GiVersion = flex.StringToFramework(ctx, giVersionMajor)
 	resp.Diagnostics.Append(flex.Flatten(ctx, out, &state)...)
 	if resp.Diagnostics.HasError() {
 		return
@@ -656,7 +656,7 @@ func FindCloudVmClusterForResourceByID(ctx context.Context, conn *odb.Client, id
 func getMajorGiVersion(giVersionComputed *string) (*string, error) {
 	giVersionMajor := strings.Split(*giVersionComputed, ".")[0]
 	giVersionMajor = giVersionMajor + ".0.0.0"
-	regxGiVersionMajor := regexp.MustCompile(MajorGiVersionPattern)
+	regxGiVersionMajor := regexache.MustCompile(MajorGiVersionPattern)
 	if !regxGiVersionMajor.MatchString(giVersionMajor) {
 		err := errors.New("gi_version major retrieved from gi_version_computed does not match the pattern 19.0.0.0")
 		return nil, err

internal/service/odb/cloud_vm_cluster_test.go

@@ -173,7 +173,7 @@ func TestAccODBCloudVmCluster_taggingTest(t *testing.T) {
 	})
 }
 
-func TestAccODBCloudVmClusterReal_basic(t *testing.T) {
+func TestAccODBCloudVmCluster_real(t *testing.T) {
 	ctx := acctest.Context(t)
 	if testing.Short() {
 		t.Skip("skipping long-running test in short mode")