aws_appconfig_application: add additional test

Author: johnsonaj

internal/service/appconfig/application_data_source_test.go

@@ -14,7 +14,7 @@ import (
 	"github.com/hashicorp/terraform-provider-aws/names"
 )
 
-func TestAccAppConfigApplicationDataSource_basic(t *testing.T) {
+func TestAccAppConfigApplicationDataSource_basic_name(t *testing.T) {
 	ctx := acctest.Context(t)
 	rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
 	dataSourceName := "data.aws_appconfig_application.test"
@@ -30,7 +30,7 @@ func TestAccAppConfigApplicationDataSource_basic(t *testing.T) {
 		CheckDestroy:             testAccCheckApplicationDestroy(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccApplicationDataSourceConfig_basic(rName),
+				Config: testAccApplicationDataSourceConfig_name(rName),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckApplicationExists(ctx, dataSourceName),
 					resource.TestCheckResourceAttrPair(dataSourceName, names.AttrDescription, resourceName, names.AttrDescription),
@@ -43,15 +43,56 @@ func TestAccAppConfigApplicationDataSource_basic(t *testing.T) {
 	})
 }
 
-func testAccApplicationDataSourceConfig_basic(rName string) string {
+func TestAccAppConfigApplicationDataSource_basic_id(t *testing.T) {
+	ctx := acctest.Context(t)
+	rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
+	dataSourceName := "data.aws_appconfig_application.test"
+	resourceName := "aws_appconfig_application.test"
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck: func() {
+			acctest.PreCheck(ctx, t)
+			acctest.PreCheckPartitionHasService(t, names.AppConfigEndpointID)
+		},
+		ErrorCheck:               acctest.ErrorCheck(t, names.AppConfigServiceID),
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
+		CheckDestroy:             testAccCheckApplicationDestroy(ctx),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccApplicationDataSourceConfig_id(rName),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					testAccCheckApplicationExists(ctx, dataSourceName),
+					resource.TestCheckResourceAttrPair(dataSourceName, names.AttrDescription, resourceName, names.AttrDescription),
+					resource.TestCheckResourceAttrPair(dataSourceName, names.AttrID, resourceName, names.AttrID),
+					resource.TestMatchResourceAttr(dataSourceName, names.AttrID, regexache.MustCompile(`[a-z\d]{4,7}`)),
+					resource.TestCheckResourceAttrPair(dataSourceName, names.AttrName, resourceName, names.AttrName),
+				),
+			},
+		},
+	})
+}
+
+func testAccApplicationDataSourceConfig_baseConfig(rName string) string {
 	return fmt.Sprintf(`
 resource "aws_appconfig_application" "test" {
   name        = %[1]q
   description = "Example AppConfig Application"
 }
+`, rName)
+}
 
+func testAccApplicationDataSourceConfig_name(rName string) string {
+	return acctest.ConfigCompose(testAccApplicationDataSourceConfig_baseConfig(rName), `
 data "aws_appconfig_application" "test" {
   name = aws_appconfig_application.test.name
 }
-`, rName)
+`)
+}
+
+func testAccApplicationDataSourceConfig_id(rName string) string {
+	return acctest.ConfigCompose(testAccApplicationDataSourceConfig_baseConfig(rName), `
+data "aws_appconfig_application" "test" {
+  id = aws_appconfig_application.test.id
+}
+`)
 }