Skip to content

Commit 9a4f00f

Browse files
authored
Add ARN-based resource identity to ivschat (#43697)
Add resource identity to ARN-based resources in ivschat. This includes: `aws_ivschat_room` `aws_ivschat_logging_configuration` ```console % make testacc PKG=ivschat TESTS="TestAccIVSChat.*_Identity" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/ivschat/... -v -count 1 -parallel 20 -run='TestAccIVSChat.*_Identity' -timeout 360m -vet=off 2025/08/04 10:53:08 Creating Terraform AWS Provider (SDKv2-style)... 2025/08/04 10:53:08 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccIVSChatRoom_Identity_Basic (29.39s) --- PASS: TestAccIVSChatRoom_Identity_RegionOverride (35.98s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_RegionOverride (38.33s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_Basic (39.75s) --- PASS: TestAccIVSChatRoom_Identity_ExistingResource (45.62s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_ExistingResource (58.05s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ivschat 64.651s ``` ```console % make testacc PKG=ivschat TESTS="TestAccIVSChatLoggingConfiguration|TestAccIVSChatRoom" make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/ivschat/... -v -count 1 -parallel 20 -run='TestAccIVSChatLoggingConfiguration|TestAccIVSChatRoom' -timeout 360m -vet=off 2025/08/04 11:11:22 Creating Terraform AWS Provider (SDKv2-style)... 2025/08/04 11:11:22 Initializing Terraform AWS Provider (SDKv2-style)... --- PASS: TestAccIVSChatLoggingConfiguration_failure_invalidDestination (10.79s) --- PASS: TestAccIVSChatRoom_disappears (32.19s) --- PASS: TestAccIVSChatRoom_basic (35.51s) --- PASS: TestAccIVSChatLoggingConfiguration_basic_cloudwatch (38.33s) --- PASS: TestAccIVSChatLoggingConfiguration_disappears (41.37s) --- PASS: TestAccIVSChatLoggingConfiguration_basic_s3 (42.32s) --- PASS: TestAccIVSChatRoom_Identity_Basic (48.28s) --- PASS: TestAccIVSChatRoom_Identity_RegionOverride (56.38s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_Basic (56.53s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_RegionOverride (58.06s) --- PASS: TestAccIVSChatLoggingConfiguration_update_s3 (58.71s) --- PASS: TestAccIVSChatRoom_update_remove_messageReviewHandler_uri (62.22s) --- PASS: TestAccIVSChatRoom_tags (62.46s) --- PASS: TestAccIVSChatRoom_Identity_ExistingResource (62.91s) --- PASS: TestAccIVSChatRoom_update (64.96s) --- PASS: TestAccIVSChatLoggingConfiguration_Identity_ExistingResource (70.92s) --- PASS: TestAccIVSChatLoggingConfiguration_tags (72.23s) --- PASS: TestAccIVSChatLoggingConfiguration_basic_firehose (78.55s) --- PASS: TestAccIVSChatRoom_loggingConfiguration (87.28s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ivschat 93.092s ```
1 parent 4adef3e commit 9a4f00f

File tree

15 files changed

+708
-8
lines changed

15 files changed

+708
-8
lines changed

.changelog/43697.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
```release-note:enhancement
2+
resource/aws_ivschat_room: Add resource identity support
3+
```
4+
```release-note:enhancement
5+
resource/aws_ivschat_logging_configuration: Add resource identity support
6+
```

internal/service/ivschat/generate.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
//go:generate go run ../../generate/tags/main.go -ListTags -ServiceTagsMap -UpdateTags -KVTValues
55
//go:generate go run ../../generate/servicepackage/main.go
6+
//go:generate go run ../../generate/identitytests/main.go
67
// ONLY generate directives and package declaration! Do not add anything else to this file.
78

89
package ivschat

internal/service/ivschat/logging_configuration.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,16 @@ import (
2525

2626
// @SDKResource("aws_ivschat_logging_configuration", name="Logging Configuration")
2727
// @Tags(identifierAttribute="id")
28+
// @ArnIdentity
29+
// @Testing(existsType="github.com/aws/aws-sdk-go-v2/service/ivschat;ivschat.GetLoggingConfigurationOutput")
30+
// @Testing(preIdentityVersion="v6.5.0")
2831
func ResourceLoggingConfiguration() *schema.Resource {
2932
return &schema.Resource{
3033
CreateWithoutTimeout: resourceLoggingConfigurationCreate,
3134
ReadWithoutTimeout: resourceLoggingConfigurationRead,
3235
UpdateWithoutTimeout: resourceLoggingConfigurationUpdate,
3336
DeleteWithoutTimeout: resourceLoggingConfigurationDelete,
3437

35-
Importer: &schema.ResourceImporter{
36-
StateContext: schema.ImportStatePassthroughContext,
37-
},
38-
3938
Timeouts: &schema.ResourceTimeout{
4039
Create: schema.DefaultTimeout(5 * time.Minute),
4140
Update: schema.DefaultTimeout(5 * time.Minute),

internal/service/ivschat/logging_configuration_identity_gen_test.go

Lines changed: 283 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/ivschat/room.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ import (
2727

2828
// @SDKResource("aws_ivschat_room", name="Room")
2929
// @Tags(identifierAttribute="id")
30+
// @ArnIdentity
31+
// @Testing(existsType="github.com/aws/aws-sdk-go-v2/service/ivschat;ivschat.GetRoomOutput")
32+
// @Testing(preIdentityVersion="v6.5.0")
33+
// @Testing(generator=false)
3034
func ResourceRoom() *schema.Resource {
3135
return &schema.Resource{
3236
CreateWithoutTimeout: resourceRoomCreate,
3337
ReadWithoutTimeout: resourceRoomRead,
3438
UpdateWithoutTimeout: resourceRoomUpdate,
3539
DeleteWithoutTimeout: resourceRoomDelete,
3640

37-
Importer: &schema.ResourceImporter{
38-
StateContext: schema.ImportStatePassthroughContext,
39-
},
40-
4141
Timeouts: &schema.ResourceTimeout{
4242
Create: schema.DefaultTimeout(5 * time.Minute),
4343
Update: schema.DefaultTimeout(5 * time.Minute),

0 commit comments

Comments
 (0)