Merge pull request #42740 from drewtul/b-webacl-update-lots-of-rules

Use HasChanges over HasChangesExcept for performnce

Author: ewbankkit

.changelog/42740.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_wafv2_web_acl: Fix performance of update when the WebACL has a large number of rules
+```

internal/service/wafv2/web_acl.go

@@ -384,7 +384,21 @@ func resourceWebACLUpdate(ctx context.Context, d *schema.ResourceData, meta any)
 	var diags diag.Diagnostics
 	conn := meta.(*conns.AWSClient).WAFV2Client(ctx)
 
-	if d.HasChangesExcept(names.AttrTags, names.AttrTagsAll) {
+	// https://github.com/hashicorp/terraform-provider-aws/pull/42740.
+	// if d.HasChangesExcept(names.AttrTags, names.AttrTagsAll) {
+	if d.HasChanges(
+		"association_config",
+		"captcha_config",
+		"challenge_config",
+		"custom_response_body",
+		"data_protection_config",
+		names.AttrDefaultAction,
+		names.AttrDescription,
+		"rule_json",
+		names.AttrRule,
+		"token_domains",
+		"visibility_config",
+	) {
 		aclName := d.Get(names.AttrName).(string)
 		aclScope := d.Get(names.AttrScope).(string)
 		aclLockToken := d.Get("lock_token").(string)