Skip to content

Commit b5482b9

Browse files
committed
Update semgrep config to anchor paths
1 parent 4817c6b commit b5482b9

File tree

5 files changed

+28
-28
lines changed

5 files changed

+28
-28
lines changed

internal/generate/acctestconsts/semgrep.gtpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ rules:
66
message: Use the constant `acctest.Ct{{ .Constant }}` for the string literal "{{ .Literal }}" in test files
77
paths:
88
include:
9-
- "internal/service/**/*_test.go"
9+
- "/internal/service/**/*_test.go"
1010
{{- if .AltLiteral }}
1111
pattern-either:
1212
- pattern: '"{{ .Literal }}"'

internal/generate/attrconsts/semgrep.gtpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ rules:
77
message: Use the constant `names.Attr{{ .Constant }}` for the string literal "{{ .Literal }}"
88
paths:
99
include:
10-
- "internal/service/**/*.go"
10+
- "/internal/service/**/*.go"
1111
patterns:
1212
- pattern: '"{{ .Literal }}"'
1313
- pattern-not-regex: '"{{ .Literal }}":\s+test\w+,'

internal/generate/servicesemgrep/cae.tmpl

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ rules:
66
message: Do not use "AWS" in func name inside AWS Provider
77
paths:
88
include:
9-
- internal
9+
- "/internal"
1010
exclude:
11-
- internal/service/securitylake/aws_log_source.go
12-
- internal/service/securitylake/aws_log_source_test.go
13-
- internal/service/*/service_endpoints_gen_test.go
11+
- "/internal/service/securitylake/aws_log_source.go"
12+
- "/internal/service/securitylake/aws_log_source_test.go"
13+
- "/internal/service/*/service_endpoints_gen_test.go"
1414
patterns:
1515
- pattern: func $NAME( ... ) { ... }
1616
- metavariable-pattern:
@@ -25,10 +25,10 @@ rules:
2525
message: Do not use "AWS" in const name inside AWS Provider
2626
paths:
2727
include:
28-
- internal
28+
- "/internal"
2929
exclude:
30-
- internal/service/securitylake/aws_log_source.go
31-
- internal/service/*/service_endpoints_gen_test.go
30+
- "/internal/service/securitylake/aws_log_source.go"
31+
- "/internal/service/*/service_endpoints_gen_test.go"
3232
patterns:
3333
- pattern: const $NAME = ...
3434
- metavariable-pattern:
@@ -43,11 +43,11 @@ rules:
4343
message: Do not use "AWS" in var name inside AWS Provider
4444
paths:
4545
include:
46-
- internal
46+
- "/internal"
4747
exclude:
48-
- internal/service/securitylake/aws_log_source.go
49-
- internal/service/securitylake/exports_test.go
50-
- internal/service/*/service_endpoints_gen_test.go
48+
- "/internal/service/securitylake/aws_log_source.go"
49+
- "/internal/service/securitylake/exports_test.go"
50+
- "/internal/service/*/service_endpoints_gen_test.go"
5151
patterns:
5252
- pattern: var $NAME = ...
5353
- metavariable-pattern:
@@ -63,7 +63,7 @@ rules:
6363
message: Use correct caps in func name (i.e., HTTPS or https, not Https) (see list at https://github.com/hashicorp/terraform-provider-aws/blob/main/names/caps.md)
6464
paths:
6565
include:
66-
- internal
66+
- "/internal"
6767
patterns:
6868
- pattern: func $NAME( ... ) { ... }
6969
- metavariable-pattern:
@@ -78,7 +78,7 @@ rules:
7878
message: Use correct caps in const name (i.e., HTTPS or https, not Https) (see list at https://github.com/hashicorp/terraform-provider-aws/blob/main/names/caps.md)
7979
paths:
8080
include:
81-
- internal
81+
- "/internal"
8282
patterns:
8383
- pattern: const $NAME = ...
8484
- metavariable-pattern:
@@ -92,7 +92,7 @@ rules:
9292
message: Use correct caps in var name (i.e., HTTPS or https, not Https) (see list at https://github.com/hashicorp/terraform-provider-aws/blob/main/names/caps.md)
9393
paths:
9494
include:
95-
- internal
95+
- "/internal"
9696
patterns:
9797
- pattern: var $NAME = ...
9898
- metavariable-pattern:
@@ -107,7 +107,7 @@ rules:
107107
message: Do not use "EC2" in func name inside ec2 package
108108
paths:
109109
include:
110-
- internal/service/ec2
110+
- "/internal/service/ec2"
111111
patterns:
112112
- pattern: func $NAME( ... )
113113
- metavariable-pattern:
@@ -123,7 +123,7 @@ rules:
123123
message: Do not use "EC2" in const name inside ec2 package
124124
paths:
125125
include:
126-
- internal/service/ec2
126+
- "/internal/service/ec2"
127127
patterns:
128128
- pattern: const $NAME = ...
129129
- metavariable-pattern:
@@ -137,7 +137,7 @@ rules:
137137
message: Do not use "EC2" in var name inside ec2 package
138138
paths:
139139
include:
140-
- internal/service/ec2
140+
- "/internal/service/ec2"
141141
patterns:
142142
- pattern: var $NAME = ...
143143
- metavariable-pattern:

internal/generate/servicesemgrep/configs.tmpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ rules:
66
message: "Config funcs should follow form testAcc<Resource>Config_<testDetail>"
77
paths:
88
include:
9-
- internal/service/**/*_test.go
9+
- "/internal/service/**/*_test.go"
1010
patterns:
1111
- pattern-inside: "[]resource.TestStep{ ... }"
1212
- pattern: "{..., $KEY:$VALUE, ...}"
@@ -28,7 +28,7 @@ rules:
2828
message: "Config funcs should follow form testAcc<Resource>Config_<testDetail>"
2929
paths:
3030
include:
31-
- internal/service/**/*_test.go
31+
- "/internal/service/**/*_test.go"
3232
patterns:
3333
- pattern-inside: "[]resource.TestStep{ ... }"
3434
- pattern: "{..., $KEY: acctest.ConfigCompose(..., $VALUE, ...), ...}"
@@ -49,7 +49,7 @@ rules:
4949
message: "Config funcs should not begin with 'testAccCheck'"
5050
paths:
5151
include:
52-
- internal/service/**/*_test.go
52+
- "/internal/service/**/*_test.go"
5353
patterns:
5454
- pattern-inside: "[]resource.TestStep{ ... }"
5555
- pattern: "{..., $KEY:$VALUE, ...}"
@@ -69,7 +69,7 @@ rules:
6969
message: "Config funcs should not begin with 'testAccCheck'"
7070
paths:
7171
include:
72-
- internal/service/**/*_test.go
72+
- "/internal/service/**/*_test.go"
7373
patterns:
7474
- pattern-inside: "[]resource.TestStep{ ... }"
7575
- pattern: "{..., $KEY: acctest.ConfigCompose(..., $VALUE, ...), ...}"

internal/generate/servicesemgrep/service.tmpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
message: Do not use "{{ .ServiceAlias }}" in func name inside {{ .ProviderPackage }} package
77
paths:
88
include:
9-
- internal/service/{{ .ProviderPackage }}
9+
- "/internal/service/{{ .ProviderPackage }}"
1010
exclude:
11-
- internal/service/{{ .ProviderPackage }}/list_pages_gen.go
11+
- "/internal/service/{{ .ProviderPackage }}/list_pages_gen.go"
1212
patterns:
1313
- pattern: func $NAME( ... )
1414
- metavariable-pattern:
@@ -49,7 +49,7 @@
4949
message: Include "{{ .ServiceAlias }}" in test name
5050
paths:
5151
include:
52-
- internal/service/{{ .ProviderPackage }}/{{ .FilePrefix }}*_test.go
52+
- "/internal/service/{{ .ProviderPackage }}/{{ .FilePrefix }}*_test.go"
5353
patterns:
5454
- pattern: func $NAME( ... )
5555
- metavariable-pattern:
@@ -66,7 +66,7 @@
6666
message: Do not use "{{ .ServiceAlias }}" in const name inside {{ .ProviderPackage }} package
6767
paths:
6868
include:
69-
- internal/service/{{ .ProviderPackage }}
69+
- "/internal/service/{{ .ProviderPackage }}"
7070
patterns:
7171
- pattern: const $NAME = ...
7272
- metavariable-pattern:
@@ -92,7 +92,7 @@
9292
message: Do not use "{{ .ServiceAlias }}" in var name inside {{ .ProviderPackage }} package
9393
paths:
9494
include:
95-
- internal/service/{{ .ProviderPackage }}
95+
- "/internal/service/{{ .ProviderPackage }}"
9696
patterns:
9797
- pattern: var $NAME = ...
9898
- metavariable-pattern:

0 commit comments

Comments
 (0)