Skip to content

Commit c242a3d

Browse files
Add parameterized resource identity to aws_connect_phone_number (#44365)
* r/aws_connect_phone_number: add resource identity ➜ terraform-provider-aws (f-ri-connect-phone-number) ✗ make testacc PKG=connect TESTS=TestAccConnectPhoneNumber_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-ri-connect-phone-number 🌿... TF_ACC=1 go1.24.6 test ./internal/service/connect/... -v -count 1 -parallel 20 -run='TestAccConnectPhoneNumber_' -timeout 360m -vet=off 2025/09/19 11:12:21 Creating Terraform AWS Provider (SDKv2-style)... 2025/09/19 11:12:21 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccConnectPhoneNumber_Identity_Basic === PAUSE TestAccConnectPhoneNumber_Identity_Basic === RUN TestAccConnectPhoneNumber_Identity_RegionOverride === PAUSE TestAccConnectPhoneNumber_Identity_RegionOverride === RUN TestAccConnectPhoneNumber_Identity_ExistingResource === PAUSE TestAccConnectPhoneNumber_Identity_ExistingResource === CONT TestAccConnectPhoneNumber_Identity_Basic === CONT TestAccConnectPhoneNumber_Identity_ExistingResource === CONT TestAccConnectPhoneNumber_Identity_RegionOverride --- PASS: TestAccConnectPhoneNumber_Identity_RegionOverride (115.97s) --- PASS: TestAccConnectPhoneNumber_Identity_Basic (119.83s) --- PASS: TestAccConnectPhoneNumber_Identity_ExistingResource (133.68s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 138.903s * Add changelog * Fix: Documentation markdown
1 parent 71008b5 commit c242a3d

File tree

11 files changed

+464
-11
lines changed

11 files changed

+464
-11
lines changed

.changelog/44365.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
resource/aws_connect_phone_number: Add resource identity support
3+
```

internal/service/connect/connect_test.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,16 @@ func TestAccConnect_serial(t *testing.T) {
8282
"dataSource_basic": testAccLambdaFunctionAssociationDataSource_basic,
8383
},
8484
"PhoneNumber": {
85-
acctest.CtBasic: testAccPhoneNumber_basic,
86-
acctest.CtDisappears: testAccPhoneNumber_disappears,
87-
"tags": testAccPhoneNumber_tags,
88-
"description": testAccPhoneNumber_description,
89-
"prefix": testAccPhoneNumber_prefix,
90-
"targetARN": testAccPhoneNumber_targetARN,
85+
acctest.CtBasic: testAccPhoneNumber_basic,
86+
acctest.CtDisappears: testAccPhoneNumber_disappears,
87+
"tags": testAccPhoneNumber_tags,
88+
"description": testAccPhoneNumber_description,
89+
"prefix": testAccPhoneNumber_prefix,
90+
"targetARN": testAccPhoneNumber_targetARN,
91+
"identityBasic": testAccConnectPhoneNumber_Identity_Basic,
92+
"identityExistingResource": testAccConnectPhoneNumber_Identity_ExistingResource,
93+
"identityExistingResourceNoRefresh": testAccConnectPhoneNumber_Identity_ExistingResource_NoRefresh_NoChange,
94+
"identityRegionOverride": testAccConnectPhoneNumber_Identity_RegionOverride,
9195
},
9296
"PhoneNumberContactFlowAssociation": {
9397
acctest.CtBasic: testAccPhoneNumberContactFlowAssociation_basic,

internal/service/connect/generate.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
//go:generate go run ../../generate/tags/main.go -KVTValues -ServiceTagsMap -UpdateTags
55
//go:generate go run ../../generate/servicepackage/main.go
6+
//go:generate go run ../../generate/identitytests/main.go
67
// ONLY generate directives and package declaration! Do not add anything else to this file.
78

89
package connect

internal/service/connect/phone_number.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,17 @@ import (
2929

3030
// @SDKResource("aws_connect_phone_number", name="Phone Number")
3131
// @Tags(identifierAttribute="arn")
32+
// @IdentityAttribute("id")
33+
// @Testing(preIdentityVersion="v6.14.1")
34+
// @Testing(serialize=true)
35+
// @Testing(existsType="github.com/aws/aws-sdk-go-v2/service/connect/types;types.ClaimedPhoneNumberSummary")
3236
func resourcePhoneNumber() *schema.Resource {
3337
return &schema.Resource{
3438
CreateWithoutTimeout: resourcePhoneNumberCreate,
3539
ReadWithoutTimeout: resourcePhoneNumberRead,
3640
UpdateWithoutTimeout: resourcePhoneNumberUpdate,
3741
DeleteWithoutTimeout: resourcePhoneNumberDelete,
3842

39-
Importer: &schema.ResourceImporter{
40-
StateContext: schema.ImportStatePassthroughContext,
41-
},
42-
4343
Timeouts: &schema.ResourceTimeout{
4444
Create: schema.DefaultTimeout(2 * time.Minute),
4545
Update: schema.DefaultTimeout(2 * time.Minute),

internal/service/connect/phone_number_identity_gen_test.go

Lines changed: 321 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/connect/service_package_gen.go

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)