Skip to content

Commit ee254eb

Browse files
committed
Updates aws_athena_database sweeper registration
1 parent 6ee68d5 commit ee254eb

File tree

1 file changed

+11
-28
lines changed

1 file changed

+11
-28
lines changed

internal/service/athena/sweep.go

Lines changed: 11 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@ func RegisterSweepers() {
2929
},
3030
})
3131

32-
resource.AddTestSweepers("aws_athena_database", &resource.Sweeper{
33-
Name: "aws_athena_database",
34-
F: sweepDatabases,
35-
})
32+
awsv2.Register("aws_athena_database", sweepDatabases)
3633

3734
resource.AddTestSweepers("aws_athena_workgroup", &resource.Sweeper{
3835
Name: "aws_athena_workgroup",
@@ -124,27 +121,16 @@ func sweepDataCatalogs(region string) error {
124121
return nil
125122
}
126123

127-
func sweepDatabases(region string) error {
128-
ctx := sweep.Context(region)
129-
client, err := sweep.SharedRegionalSweepClient(ctx, region)
130-
if err != nil {
131-
return fmt.Errorf("getting client: %w", err)
132-
}
124+
func sweepDatabases(ctx context.Context, client *conns.AWSClient) ([]sweep.Sweepable, error) {
133125
conn := client.AthenaClient(ctx)
134-
input := &athena.ListDataCatalogsInput{}
135-
sweepResources := make([]sweep.Sweepable, 0)
126+
var sweepResources []sweep.Sweepable
136127

137-
pages := athena.NewListDataCatalogsPaginator(conn, input)
128+
input := athena.ListDataCatalogsInput{}
129+
pages := athena.NewListDataCatalogsPaginator(conn, &input)
138130
for pages.HasMorePages() {
139131
page, err := pages.NextPage(ctx)
140-
141-
if awsv2.SkipSweepError(err) {
142-
log.Printf("[WARN] Skipping Athena Database sweep for %s: %s", region, err)
143-
return nil
144-
}
145-
146132
if err != nil {
147-
return fmt.Errorf("error listing Athena Data Catalogs (%s): %w", region, err)
133+
return nil, err
148134
}
149135

150136
for _, v := range page.DataCatalogsSummary {
@@ -158,7 +144,10 @@ func sweepDatabases(region string) error {
158144
page, err := pages.NextPage(ctx)
159145

160146
if err != nil {
161-
log.Printf("[WARN] Skipping Athena Database sweep for Data Catalog %q in %s: %s", catalogName, region, err)
147+
tflog.Warn(ctx, "Skipping resource", map[string]any{
148+
"error": err.Error(),
149+
"catalog_name": catalogName,
150+
})
162151
break
163152
}
164153

@@ -181,13 +170,7 @@ func sweepDatabases(region string) error {
181170
}
182171
}
183172

184-
err = sweep.SweepOrchestrator(ctx, sweepResources)
185-
186-
if err != nil {
187-
return fmt.Errorf("error sweeping Athena Databases (%s): %w", region, err)
188-
}
189-
190-
return nil
173+
return sweepResources, nil
191174
}
192175

193176
func sweepWorkGroups(region string) error {

0 commit comments

Comments
 (0)