d/aws_iam_roles: Use 'inttypes.IsZero'.

Author: ewbankkit

internal/service/iam/roles_data_source.go

@@ -5,7 +5,6 @@ package iam
 
 import (
 	"context"
-	"reflect"
 
 	"github.com/YakDriver/regexache"
 	"github.com/aws/aws-sdk-go-v2/aws"
@@ -16,6 +15,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"github.com/hashicorp/terraform-provider-aws/internal/conns"
 	"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
+	inttypes "github.com/hashicorp/terraform-provider-aws/internal/types"
 	"github.com/hashicorp/terraform-provider-aws/names"
 )
 
@@ -68,7 +68,7 @@ func dataSourceRolesRead(ctx context.Context, d *schema.ResourceData, meta any)
 		}
 
 		for _, role := range page.Roles {
-			if reflect.ValueOf(role).IsZero() {
+			if p := &role; inttypes.IsZero(p) {
 				continue
 			}
 
@@ -89,13 +89,8 @@ func dataSourceRolesRead(ctx context.Context, d *schema.ResourceData, meta any)
 		nms = append(nms, aws.ToString(r.RoleName))
 	}
 
-	if err := d.Set(names.AttrARNs, arns); err != nil {
-		return sdkdiag.AppendErrorf(diags, "setting arns: %s", err)
-	}
-
-	if err := d.Set(names.AttrNames, nms); err != nil {
-		return sdkdiag.AppendErrorf(diags, "setting names: %s", err)
-	}
+	d.Set(names.AttrARNs, arns)
+	d.Set(names.AttrNames, nms)
 
 	return diags
 }

internal/service/iam/roles_data_source_test.go

@@ -143,7 +143,7 @@ resource "aws_iam_role" "test" {
     {
       "Action": "sts:AssumeRole",
       "Principal": {
-        "Service": data.aws_service_principal.ec2.name
+        "Service": "${data.aws_service_principal.ec2.name}"
       },
       "Effect": "Allow",
       "Sid": ""
@@ -179,7 +179,7 @@ resource "aws_iam_role" "test" {
     {
       "Action": "sts:AssumeRole",
       "Principal": {
-        "Service": data.aws_service_principal.ec2.name
+        "Service": "${data.aws_service_principal.ec2.name}"
       },
       "Effect": "Allow",
       "Sid": ""
@@ -220,7 +220,7 @@ resource "aws_iam_role" "test" {
     {
       "Action": "sts:AssumeRole",
       "Principal": {
-        "Service": data.aws_service_principal.ec2.name
+        "Service": "${data.aws_service_principal.ec2.name}"
       },
       "Effect": "Allow",
       "Sid": ""