Skip to content

Fix framework identity interceptor #44518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 8, 2025
Merged

Fix framework identity interceptor #44518

merged 5 commits into from
Oct 8, 2025

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 1, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Relates #44375

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@YakDriver YakDriver requested a review from a team as a code owner October 1, 2025 15:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/M Managed by automation to categorize the size of a PR. labels Oct 1, 2025
jar-b
jar-b previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make t K=ec2 T=TestAccVPCSecurityGroupIngressRule_Identity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-identity-for-framework 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCSecurityGroupIngressRule_Identity'  -timeout 360m -vet=off
2025/10/08 10:02:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/08 10:02:46 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_RegionOverride (31.91s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_Basic (37.47s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_ExistingResource_NoRefresh_NoChange (52.26s)
--- PASS: TestAccVPCSecurityGroupIngressRule_Identity_ExistingResource (60.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        68.051s

jar-b
jar-b reviewed Oct 8, 2025
View reviewed changes
@YakDriver @jar-b
Update .changelog/44518.txt
ab11f94 
Co-authored-by: Jared Baker <[email protected]>
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Oct 8, 2025
jar-b
jar-b reviewed Oct 8, 2025
View reviewed changes
@YakDriver YakDriver merged commit 414ba49 into main Oct 8, 2025
55 checks passed
@YakDriver YakDriver deleted the b-identity-for-framework branch October 8, 2025 18:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.16.0 milestone Oct 8, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 8, 2025
Update CHANGELOG.md for #44518
20eda8a
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

This functionality has been released in v6.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @jar-b