Skip to content

Revert "Bump github.com/hashicorp/terraform-plugin-framework from 1.16.0 to 1.16.1 in the terraform-devex group across 1 directory" #44520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Revert "Bump github.com/hashicorp/terraform-plugin-framework from 1.16.0 to 1.16.1 in the terraform-devex group across 1 directory" #44520

merged 1 commit into from
Oct 1, 2025

Conversation

@jar-b
Copy link
Member

@jar-b jar-b commented Oct 1, 2025 •
edited
Loading

Reverts #44493

The additional error diagnostics added in this version have uncovered some discrepancies between how the AWS provider implemented resource identity support for Plugin Framework resources, and the expectations held by the upstream library. Specifically, the library assumes that a resource implements the ResourceWithIdentity interface when identity is fully supported, and always returns a non-nil schema.

In versions v6.0.0 to current, the provider has implemented an IdentitySchema method on all Plugin Framework resources by wrapping the base resource implementation, therefore satisfying the ResourceWithIdentity interface. A resource was only considered supported when the schema contained greater than 0 attributes.

This difference in assumptions went undetected to this point because the upstream library allowed null identities to be written to state, as would be the case with any resource which the provider considered "unimplemented" but plugin framework would treat as implemented with an empty identity schema (0 attributes). With the introduction of new error diagnostics for this case, the provider will need to refactor how Plugin Framework resources are wrapped before proceeding with the upgrade of this package.

Relates hashicorp/terraform-plugin-framework#1193

Example of a newly failing test with this library upgrade.

% make t K=lambda T=TestAccLambdaFunctionRecursionConfig_basic
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-identity-interceptor-fw 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionRecursionConfig_basic'  -timeout 360m -vet=off
2025/10/01 15:26:04 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 15:26:04 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaFunctionRecursionConfig_basic
=== PAUSE TestAccLambdaFunctionRecursionConfig_basic
=== CONT  TestAccLambdaFunctionRecursionConfig_basic
    function_recursion_config_test.go:36: Step 1/2 error: Error running apply: exit status 1

        Error: Missing Resource Identity After Create

          with aws_lambda_function_recursion_config.test,
          on terraform_plugin_test.tf line 41, in resource "aws_lambda_function_recursion_config" "test":
          41: resource "aws_lambda_function_recursion_config" "test" {

        The Terraform Provider unexpectedly returned no resource identity data after
        having no errors in the resource create. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
--- FAIL: TestAccLambdaFunctionRecursionConfig_basic (30.13s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lambda     36.818s

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR. labels Oct 1, 2025
@jar-b jar-b marked this pull request as ready for review October 1, 2025 20:10
@jar-b jar-b requested a review from a team as a code owner October 1, 2025 20:10
@jar-b jar-b merged commit 19dc074 into main Oct 1, 2025
60 checks passed
@jar-b jar-b deleted the revert-44493-dependabot/go_modules/terraform-devex-bc5cc30695 branch October 1, 2025 22:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.15.0 milestone Oct 1, 2025
@jar-b jar-b mentioned this pull request Oct 2, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

This functionality has been released in v6.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

No one assigned

Labels

size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

v6.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jar-b @YakDriver