diff --git a/.changelog/44570.txt b/.changelog/44570.txt new file mode 100644 index 000000000000..b9f331ff9d73 --- /dev/null +++ b/.changelog/44570.txt @@ -0,0 +1,3 @@ +```release-note:enhancement +resource/aws_sagemaker_notebook_instance: Add `notebook-al2023-v1` to valid `platform_identifier` values +``` diff --git a/internal/service/sagemaker/notebook_instance.go b/internal/service/sagemaker/notebook_instance.go index 0bb3527eb2c9..54d8dc43a63d 100644 --- a/internal/service/sagemaker/notebook_instance.go +++ b/internal/service/sagemaker/notebook_instance.go @@ -115,7 +115,7 @@ func resourceNotebookInstance() *schema.Resource { Optional: true, Computed: true, ForceNew: true, - ValidateFunc: validation.StringMatch(regexache.MustCompile(`^(notebook-al1-v1|notebook-al2-v1|notebook-al2-v2|notebook-al2-v3)$`), ""), + ValidateFunc: validation.StringMatch(regexache.MustCompile(`^(notebook-al1-v1|notebook-al2-v1|notebook-al2-v2|notebook-al2-v3|notebook-al2023-v1)$`), ""), }, names.AttrRoleARN: { Type: schema.TypeString, diff --git a/internal/service/sagemaker/notebook_instance_test.go b/internal/service/sagemaker/notebook_instance_test.go index 606efd497d47..5418913848e2 100644 --- a/internal/service/sagemaker/notebook_instance_test.go +++ b/internal/service/sagemaker/notebook_instance_test.go @@ -50,7 +50,7 @@ func TestAccSageMakerNotebookInstance_basic(t *testing.T) { resource.TestCheckResourceAttr(resourceName, "instance_metadata_service_configuration.0.minimum_instance_metadata_service_version", "2"), resource.TestCheckResourceAttr(resourceName, names.AttrInstanceType, "ml.t2.medium"), resource.TestCheckResourceAttr(resourceName, names.AttrName, rName), - resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v2"), + resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v3"), resource.TestCheckResourceAttrPair(resourceName, names.AttrRoleARN, "aws_iam_role.test", names.AttrARN), resource.TestCheckResourceAttr(resourceName, "root_access", "Enabled"), resource.TestCheckResourceAttr(resourceName, "security_groups.#", "0"), @@ -409,10 +409,10 @@ func TestAccSageMakerNotebookInstance_Platform_identifier(t *testing.T) { CheckDestroy: testAccCheckNotebookInstanceDestroy(ctx), Steps: []resource.TestStep{ { - Config: testAccNotebookInstanceConfig_platformIdentifier(rName, "notebook-al2-v1"), + Config: testAccNotebookInstanceConfig_platformIdentifier(rName, "notebook-al2-v3"), Check: resource.ComposeTestCheckFunc( testAccCheckNotebookInstanceExists(ctx, resourceName, ¬ebook), - resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v1"), + resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v3"), ), }, { @@ -421,17 +421,10 @@ func TestAccSageMakerNotebookInstance_Platform_identifier(t *testing.T) { ImportStateVerify: true, }, { - Config: testAccNotebookInstanceConfig_platformIdentifier(rName, "notebook-al2-v2"), - Check: resource.ComposeTestCheckFunc( - testAccCheckNotebookInstanceExists(ctx, resourceName, ¬ebook), - resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v2"), - ), - }, - { - Config: testAccNotebookInstanceConfig_platformIdentifier(rName, "notebook-al2-v3"), + Config: testAccNotebookInstanceConfig_platformIdentifier(rName, "notebook-al2023-v1"), Check: resource.ComposeTestCheckFunc( testAccCheckNotebookInstanceExists(ctx, resourceName, ¬ebook), - resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2-v3"), + resource.TestCheckResourceAttr(resourceName, "platform_identifier", "notebook-al2023-v1"), ), }, }, diff --git a/website/docs/r/sagemaker_notebook_instance.html.markdown b/website/docs/r/sagemaker_notebook_instance.html.markdown index 5ddc9fde8207..35d10fc5070a 100644 --- a/website/docs/r/sagemaker_notebook_instance.html.markdown +++ b/website/docs/r/sagemaker_notebook_instance.html.markdown @@ -57,7 +57,7 @@ This resource supports the following arguments: * `name` - (Required) The name of the notebook instance (must be unique). * `role_arn` - (Required) The ARN of the IAM role to be used by the notebook instance which allows SageMaker AI to call other services on your behalf. * `instance_type` - (Required) The name of ML compute instance type. -* `platform_identifier` - (Optional) The platform identifier of the notebook instance runtime environment. This value can be either `notebook-al1-v1`, `notebook-al2-v1`, `notebook-al2-v2`, or `notebook-al2-v3`, depending on which version of Amazon Linux you require. +* `platform_identifier` - (Optional) The platform identifier of the notebook instance runtime environment. This value can be either `notebook-al1-v1`(deprecated), `notebook-al2-v1`(deprecated), `notebook-al2-v2`(deprecated), `notebook-al2-v3`, or `notebook-al2023-v1`, depending on which version of Amazon Linux you require. Defaults to `notebook-al2-v3`. * `volume_size` - (Optional) The size, in GB, of the ML storage volume to attach to the notebook instance. The default value is 5 GB. * `subnet_id` - (Optional) The VPC subnet ID. * `security_groups` - (Optional) The associated security groups.