Skip to content

b-aws_ivschat_room: Increase maximum message rate validation to 100 #44572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

b-aws_ivschat_room: Increase maximum message rate validation to 100 #44572

wants to merge 2 commits into from
+4 −1

Conversation

djdabs
Copy link

@djdabs djdabs commented Oct 7, 2025 •
edited
Loading

Rollback Plan

Set back to 10

Changes to Security Controls

None

Description

Bumping up validation for ivs chat room from 10 messages to 100.

The AWS API supports up to 100: https://docs.aws.amazon.com/ivs/latest/ChatAPIReference/API_CreateRoom.html#API_CreateRoom_RequestSyntax

@djdabs djdabs requested a review from a team as a code owner October 7, 2025 18:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ivschat Issues and PRs that pertain to the ivschat service. size/XS Managed by automation to categorize the size of a PR. labels Oct 7, 2025
@djdabs djdabs changed the title IVS Chat: Increase maximum message rate validation to 100 b-aws_ivschat_room: Increase maximum message rate validation to 100 Oct 7, 2025
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 9, 2025
jar-b
jar-b approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t K=ivschat T=TestAccIVSChatRoom_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 patch-1 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ivschat/... -v -count 1 -parallel 20 -run='TestAccIVSChatRoom_'  -timeout 360m -vet=off
2025/10/09 10:10:13 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/09 10:10:13 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccIVSChatRoom_disappears (21.83s)
--- PASS: TestAccIVSChatRoom_basic (27.74s)
--- PASS: TestAccIVSChatRoom_Identity_Basic (35.47s)
--- PASS: TestAccIVSChatRoom_Identity_RegionOverride (39.75s)
--- PASS: TestAccIVSChatRoom_tags (46.33s)
--- PASS: TestAccIVSChatRoom_update_remove_messageReviewHandler_uri (48.65s)
--- PASS: TestAccIVSChatRoom_Identity_ExistingResource_NoRefresh_NoChange (48.75s)
--- PASS: TestAccIVSChatRoom_Identity_ExistingResource (52.52s)
--- PASS: TestAccIVSChatRoom_update (53.22s)
--- PASS: TestAccIVSChatRoom_loggingConfiguration (73.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivschat    80.079s

@jar-b
Copy link
Member

jar-b commented Oct 9, 2025 •
edited
Loading

Thank you for your contribution, @djdabs 🎉

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 9, 2025
ewbankkit
ewbankkit approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ivschat Issues and PRs that pertain to the ivschat service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djdabs @jar-b @ewbankkit