Skip to content

Commit bff6480

Browse files
committed
Fix for panic when attempting to read resource identifier after creating resource has failed.
1 parent ef97dde commit bff6480

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

internal/generic/resource.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,11 @@ func (r *genericResource) Create(ctx context.Context, request resource.CreateReq
394394

395395
err = waiter.Wait(ctx, &cloudcontrol.GetResourceRequestStatusInput{RequestToken: output.ProgressEvent.RequestToken}, r.createTimeout)
396396

397-
id := aws.ToString(progressEvent.Identifier)
397+
// If the resource failed to create, then Identifier may be a nil ptr
398+
var id string
399+
if progressEvent.Identifier != nil {
400+
id = aws.ToString(progressEvent.Identifier)
401+
}
398402

399403
if err != nil {
400404
response.Diagnostics.Append(ServiceOperationWaiterErrorDiag("Cloud Control API", "CreateResource", err))

0 commit comments

Comments
 (0)