Skip to content

fix: notify when goimports is not on the PATH #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: notify when goimports is not on the PATH #2195

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ab7e31
fix: update reference goimports
scottschreckengaust Feb 6, 2025
aa0b26b
add a check for goimports
scottschreckengaust Feb 6, 2025
3cd6fc1
Update the comment for make step
scottschreckengaust Feb 6, 2025
c5f0d68
add dollar sign to PATH
scottschreckengaust Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,21 @@ help: ## Display this help
build: prereq-go ## Build the provider
$(GO_VER) install

plural-data-sources: prereq-go ## Generate plural data sources
plural-data-sources: prereq-go prereq-goimports ## Generate plural data sources
rm -f internal/*/*/*_plural_data_source_gen.go
rm -f internal/*/*/*_plural_data_source_gen_test.go
$(GO_VER) generate internal/provider/plural_data_sources.go
goimports -w internal/*/*/*_plural_data_source_gen.go
goimports -w internal/*/*/*_plural_data_source_gen_test.go

singular-data-sources: prereq-go ## Generate singular data sources
singular-data-sources: prereq-go prereq-goimports ## Generate singular data sources
rm -f internal/*/*/*_singular_data_source_gen.go
rm -f internal/*/*/*_singular_data_source_gen_test.go
$(GO_VER) generate internal/provider/singular_data_sources.go
goimports -w internal/*/*/*_singular_data_source_gen.go
goimports -w internal/*/*/*_singular_data_source_gen_test.go

resources: prereq-go ## Generate resources
resources: prereq-go prereq-goimports ## Generate resources
rm -f internal/*/*/*_resource_gen.go
rm -f internal/*/*/*_resource_gen_test.go
$(GO_VER) generate internal/provider/resources.go
Expand Down Expand Up @@ -83,3 +83,9 @@ prereq-go: # If $(GO_VER) is not installed, install it
$(GO_VER) download ; \
echo "make: $(GO_VER) ready" ; \
fi

prereq-goimports: # If the goimports cannot be found, notify the user with how to fix
@if ! type "goimports" > /dev/null 2>&1 ; then \
echo 'WARNING: GOPATH/bin missing from PATH. HINT: "export PATH=$$PATH:$$($(GO_VER) env GOPATH)/bin"' ; \
which goimports; \
fi