Feature: Add support for automatic assignment policy#1851
Closed
pckls wants to merge 1 commit intohashicorp:mainfrom
Closed
Feature: Add support for automatic assignment policy#1851pckls wants to merge 1 commit intohashicorp:mainfrom
pckls wants to merge 1 commit intohashicorp:mainfrom
Conversation
Author
|
I've raised this as a draft PR to discuss with peers and hopefully to get some feedback. I expect that the issue here is to do with the beta vs stable API/SDK and potentially requires fixing upstream. |
Author
|
Will attempt #1852 before implementing this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
First go at a fix for #1449. Originally my suggestion was to add a new resource, but once I tried to do this I realised it made more sense to just amend the existing
access_policy_assignment_policyresource.Changes to existing Resource / Data Source
Testing
I'm leaving this unchecked for now, because while I have run some local tests I think there is still more to do.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azuread_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #1449
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.