From 3e4e6782339e58aed813749f3eb8d94252a18e37 Mon Sep 17 00:00:00 2001 From: Baraa Basata Date: Tue, 29 Jul 2025 12:37:48 -0400 Subject: [PATCH 1/2] framework6provider: set identity in StateMover --- internal/framework5provider/move_state_resource.go | 1 + internal/framework6provider/move_state_resource.go | 1 + 2 files changed, 2 insertions(+) diff --git a/internal/framework5provider/move_state_resource.go b/internal/framework5provider/move_state_resource.go index 06888e8c..61020951 100644 --- a/internal/framework5provider/move_state_resource.go +++ b/internal/framework5provider/move_state_resource.go @@ -121,6 +121,7 @@ func (r MoveStateResource) MoveState(ctx context.Context) []resource.StateMover } resp.Diagnostics.Append(resp.TargetState.SetAttribute(ctx, path.Root("moved_random_string"), oldState.Result)...) + resp.Diagnostics.Append(resp.TargetIdentity.SetAttribute(ctx, path.Root("id"), oldState.Result)...) case "registry.terraform.io/hashicorp/framework": // Corner provider (testing identity moves) if req.SourceTypeName != "framework_identity" { resp.Diagnostics.AddError( diff --git a/internal/framework6provider/move_state_resource.go b/internal/framework6provider/move_state_resource.go index d1ed0043..560c08d8 100644 --- a/internal/framework6provider/move_state_resource.go +++ b/internal/framework6provider/move_state_resource.go @@ -121,6 +121,7 @@ func (r MoveStateResource) MoveState(ctx context.Context) []resource.StateMover } resp.Diagnostics.Append(resp.TargetState.SetAttribute(ctx, path.Root("moved_random_string"), oldState.Result)...) + resp.Diagnostics.Append(resp.TargetIdentity.SetAttribute(ctx, path.Root("id"), oldState.Result)...) case "registry.terraform.io/hashicorp/framework": // Corner provider (testing identity moves) if req.SourceTypeName != "framework_identity" { resp.Diagnostics.AddError( From 1c91ca913f4157f68d66da5fe8a86c9cd21c82ee Mon Sep 17 00:00:00 2001 From: Baraa Basata Date: Tue, 29 Jul 2025 12:38:20 -0400 Subject: [PATCH 2/2] tidy --- internal/framework5provider/provider.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/framework5provider/provider.go b/internal/framework5provider/provider.go index f5be218c..71391bc4 100644 --- a/internal/framework5provider/provider.go +++ b/internal/framework5provider/provider.go @@ -5,7 +5,6 @@ package framework import ( "context" - "fmt" "github.com/hashicorp/terraform-plugin-framework/datasource" "github.com/hashicorp/terraform-plugin-framework/ephemeral" @@ -149,7 +148,6 @@ func (p *testProvider) EphemeralResources(ctx context.Context) []func() ephemera } func (p *testProvider) ListResources(_ context.Context) []func() list.ListResource { - fmt.Println("ListResources called") return []func() list.ListResource{ NewListResourceAsListResource, }