The version field should be under configmanagement instead of under oci, deprecating the older field (#9648) (#6764)

* Adding Terraform resources for Tenancy APIs in GKEHub

* Segregating MembershipBinding and MembershipRBACRoleBinding to keep things simpler in the review

* Fixing the docu URIs

* Adding TF support for Tenancy API for Membership Binding

* Adding dependent membership binding to the same commit chain

* Making Scope un-updatable and replacing hard coded project number with the one from test env

* Making Scope RRBAC updatable

* Making Namespace immutable

* Adding update test cases

* Removing all memberships field from Scope since it is no longer supported

* Removing all_memberships field for Scope from all test cases

* Making naming in examples consistent across Tenancy APIs documentation

* Update mmv1/templates/terraform/examples/gkehub_membership_binding_basic.tf.erb



* Update mmv1/templates/terraform/examples/gkehub_membership_binding_basic.tf.erb



* Update mmv1/templates/terraform/examples/gkehub_membership_rbac_role_binding_basic.tf.erb



* Fixing typo in the resource name

* Adding state migrations for Membership

* Updating the feature_membership documentation with the current resource state. Adding membership_location field to the doc

* Fixing the version field to be directly under configmanagement instead of under the oci field

* Adding tests for the field version

* Changing version fields value to test upgradation

* Moving the version to under the parent field configmanagement

* Adding quotes around the fields name

---------


[upstream:897b7f18d1740bc864111c79fe56bf57c628ecc6]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9648.txt

@@ -0,0 +1,6 @@
+```release-note:enhancement
+gkehub2: added field `version` under `configmanagement` in `google_gke_hub_feature` resource
+```
+```release-note:deprecation
+gkehub2: deprecated field `configmanagement.config_sync.oci.version` in `google_gke_hub_feature` resource
+```

google-beta/services/gkehub2/resource_gke_hub_feature.go

@@ -167,6 +167,7 @@ func ResourceGKEHub2Feature() *schema.Resource {
 															"version": {
 																Type:        schema.TypeString,
 																Optional:    true,
+																Deprecated:  "The `configmanagement.config_sync.oci.version` field is deprecated and will be removed in a future major release. Please use `configmanagement.version` field to specify the version of ACM installed instead.",
 																Description: `Version of ACM installed`,
 															},
 														},
@@ -180,6 +181,11 @@ func ResourceGKEHub2Feature() *schema.Resource {
 											},
 										},
 									},
+									"version": {
+										Type:        schema.TypeString,
+										Optional:    true,
+										Description: `Version of ACM installed`,
+									},
 								},
 							},
 						},
@@ -1142,10 +1148,16 @@ func flattenGKEHub2FeatureFleetDefaultMemberConfigConfigmanagement(v interface{}
 		return nil
 	}
 	transformed := make(map[string]interface{})
+	transformed["version"] =
+		flattenGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementVersion(original["version"], d, config)
 	transformed["config_sync"] =
 		flattenGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementConfigSync(original["configSync"], d, config)
 	return []interface{}{transformed}
 }
+func flattenGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementVersion(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementConfigSync(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	if v == nil {
 		return nil
@@ -1860,6 +1872,13 @@ func expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagement(v interface{},
 	original := raw.(map[string]interface{})
 	transformed := make(map[string]interface{})
 
+	transformedVersion, err := expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementVersion(original["version"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedVersion); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["version"] = transformedVersion
+	}
+
 	transformedConfigSync, err := expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementConfigSync(original["config_sync"], d, config)
 	if err != nil {
 		return nil, err
@@ -1870,6 +1889,10 @@ func expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagement(v interface{},
 	return transformed, nil
 }
 
+func expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementVersion(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandGKEHub2FeatureFleetDefaultMemberConfigConfigmanagementConfigSync(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	l := v.([]interface{})
 	if len(l) == 0 || l[0] == nil {

google-beta/services/gkehub2/resource_gke_hub_feature_test.go

@@ -459,6 +459,7 @@ resource "google_gke_hub_feature" "feature" {
   location = "global"
   fleet_default_member_config {
     configmanagement {
+      version = "1.16.0"
       config_sync {
         source_format = "hierarchy"
         git {
@@ -485,6 +486,7 @@ resource "google_gke_hub_feature" "feature" {
   location = "global"
   fleet_default_member_config {
     configmanagement {
+      version = "1.16.1"
       config_sync {
         source_format = "unstructured"
         oci {

website/docs/r/gke_hub_feature.html.markdown

@@ -402,6 +402,10 @@ The following arguments are supported:
 
 <a name="nested_configmanagement"></a>The `configmanagement` block supports:
 
+* `version` -
+  (Optional)
+  Version of ACM installed
+
 * `config_sync` -
   (Optional)
   ConfigSync configuration for the cluster
@@ -482,9 +486,11 @@ The following arguments are supported:
   Period in seconds between consecutive syncs. Default: 15
 
 * `version` -
-  (Optional)
+  (Optional, Deprecated)
   Version of ACM installed
 
+  ~> **Warning:** The `configmanagement.config_sync.oci.version` field is deprecated and will be removed in a future major release. Please use `configmanagement.version` field to specify the version of ACM installed instead.
+
 <a name="nested_policycontroller"></a>The `policycontroller` block supports:
 
 * `version` -