Skip to content

Commit 01943b2

Browse files
treat project 404s correctly in project service read (#3354) (#1941)
Signed-off-by: Modular Magician <[email protected]>
1 parent 99beb07 commit 01943b2

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.changelog/3354.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
3+
```

google-beta/resource_google_project_service.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,16 +158,16 @@ func resourceGoogleProjectServiceRead(d *schema.ResourceData, meta interface{})
158158

159159
// Verify project for services still exists
160160
p, err := config.clientResourceManager.Projects.Get(project).Do()
161-
if err != nil {
162-
return err
163-
}
164-
if p.LifecycleState == "DELETE_REQUESTED" {
161+
if err == nil && p.LifecycleState == "DELETE_REQUESTED" {
165162
// Construct a 404 error for handleNotFoundError
166-
return &googleapi.Error{
163+
err = &googleapi.Error{
167164
Code: 404,
168165
Message: "Project deletion was requested",
169166
}
170167
}
168+
if err != nil {
169+
return handleNotFoundError(err, d, fmt.Sprintf("Project Service %s", d.Id()))
170+
}
171171

172172
servicesRaw, err := BatchRequestReadServices(project, d, config)
173173
if err != nil {

0 commit comments

Comments
 (0)