Add Azure odic support for BQ Omni connections (#7188) (#5150)

Signed-off-by: Modular Magician <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>

Author: modular-magician

.changelog/7188.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+bigquery: Added support for federated Azure identities to BigQuery Omni connections.
+```

google-beta/resource_bigquery_connection.go

@@ -85,6 +85,11 @@ func resourceBigqueryConnectionConnection() *schema.Resource {
 							Required:    true,
 							Description: `The id of customer's directory that host the data.`,
 						},
+						"federated_application_client_id": {
+							Type:        schema.TypeString,
+							Optional:    true,
+							Description: `The Azure Application (client) ID where the federated credentials will be hosted.`,
+						},
 						"application": {
 							Type:        schema.TypeString,
 							Computed:    true,
@@ -533,7 +538,8 @@ func resourceBigqueryConnectionConnectionUpdate(d *schema.ResourceData, meta int
 	}
 
 	if d.HasChange("azure") {
-		updateMask = append(updateMask, "azure")
+		updateMask = append(updateMask, "azure.customer_tenant_id",
+			"azure.federated_application_client_id")
 	}
 
 	if d.HasChange("cloud_spanner") {
@@ -743,6 +749,8 @@ func flattenBigqueryConnectionConnectionAzure(v interface{}, d *schema.ResourceD
 		flattenBigqueryConnectionConnectionAzureObjectId(original["objectId"], d, config)
 	transformed["customer_tenant_id"] =
 		flattenBigqueryConnectionConnectionAzureCustomerTenantId(original["customerTenantId"], d, config)
+	transformed["federated_application_client_id"] =
+		flattenBigqueryConnectionConnectionAzureFederatedApplicationClientId(original["federatedApplicationClientId"], d, config)
 	transformed["redirect_uri"] =
 		flattenBigqueryConnectionConnectionAzureRedirectUri(original["redirectUri"], d, config)
 	transformed["identity"] =
@@ -765,6 +773,10 @@ func flattenBigqueryConnectionConnectionAzureCustomerTenantId(v interface{}, d *
 	return v
 }
 
+func flattenBigqueryConnectionConnectionAzureFederatedApplicationClientId(v interface{}, d *schema.ResourceData, config *Config) interface{} {
+	return v
+}
+
 func flattenBigqueryConnectionConnectionAzureRedirectUri(v interface{}, d *schema.ResourceData, config *Config) interface{} {
 	return v
 }
@@ -1018,6 +1030,13 @@ func expandBigqueryConnectionConnectionAzure(v interface{}, d TerraformResourceD
 		transformed["customerTenantId"] = transformedCustomerTenantId
 	}
 
+	transformedFederatedApplicationClientId, err := expandBigqueryConnectionConnectionAzureFederatedApplicationClientId(original["federated_application_client_id"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedFederatedApplicationClientId); val.IsValid() && !isEmptyValue(val) {
+		transformed["federatedApplicationClientId"] = transformedFederatedApplicationClientId
+	}
+
 	transformedRedirectUri, err := expandBigqueryConnectionConnectionAzureRedirectUri(original["redirect_uri"], d, config)
 	if err != nil {
 		return nil, err
@@ -1051,6 +1070,10 @@ func expandBigqueryConnectionConnectionAzureCustomerTenantId(v interface{}, d Te
 	return v, nil
 }
 
+func expandBigqueryConnectionConnectionAzureFederatedApplicationClientId(v interface{}, d TerraformResourceData, config *Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandBigqueryConnectionConnectionAzureRedirectUri(v interface{}, d TerraformResourceData, config *Config) (interface{}, error) {
 	return v, nil
 }

google-beta/resource_bigquery_connection_generated_test.go

@@ -302,6 +302,7 @@ resource "google_bigquery_connection" "connection" {
    description   = "a riveting description"
    azure {
       customer_tenant_id = "tf-test-customer-tenant-id%{random_suffix}"
+      federated_application_client_id = "tf-test-b43eeeee-eeee-eeee-eeee-a480155501ce%{random_suffix}"
    }
 }
 `, context)

website/docs/r/bigquery_connection.html.markdown

@@ -188,6 +188,7 @@ resource "google_bigquery_connection" "connection" {
    description   = "a riveting description"
    azure {
       customer_tenant_id = "customer-tenant-id"
+      federated_application_client_id = "b43eeeee-eeee-eeee-eeee-a480155501ce"
    }
 }
 ```
@@ -338,6 +339,10 @@ The following arguments are supported:
   (Required)
   The id of customer's directory that host the data.
 
+* `federated_application_client_id` -
+  (Optional)
+  The Azure Application (client) ID where the federated credentials will be hosted.
+
 * `redirect_uri` -
   The URL user will be redirected to after granting consent during connection setup.