Skip to content

Commit 04ec1a6

Browse files
modular-magicianEdward Sun
andauthored
display_name not in response (#6867) (#4925)
* display_name not in response * use ignore_read instead Co-authored-by: Edward Sun <[email protected]> Signed-off-by: Modular Magician <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Edward Sun <[email protected]>
1 parent ae4d0f8 commit 04ec1a6

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.changelog/6867.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
alloydb: fixed permdiff on `display_name` of `google_alloydb_instance`
3+
```

google-beta/resource_alloydb_instance.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,6 @@ func resourceAlloydbInstanceRead(d *schema.ResourceData, meta interface{}) error
320320
if err := d.Set("state", flattenAlloydbInstanceState(res["state"], d, config)); err != nil {
321321
return fmt.Errorf("Error reading Instance: %s", err)
322322
}
323-
if err := d.Set("display_name", flattenAlloydbInstanceDisplayName(res["displayName"], d, config)); err != nil {
324-
return fmt.Errorf("Error reading Instance: %s", err)
325-
}
326323
if err := d.Set("gce_zone", flattenAlloydbInstanceGceZone(res["gceZone"], d, config)); err != nil {
327324
return fmt.Errorf("Error reading Instance: %s", err)
328325
}
@@ -569,10 +566,6 @@ func flattenAlloydbInstanceState(v interface{}, d *schema.ResourceData, config *
569566
return v
570567
}
571568

572-
func flattenAlloydbInstanceDisplayName(v interface{}, d *schema.ResourceData, config *Config) interface{} {
573-
return v
574-
}
575-
576569
func flattenAlloydbInstanceGceZone(v interface{}, d *schema.ResourceData, config *Config) interface{} {
577570
return v
578571
}

google-beta/resource_alloydb_instance_generated_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func TestAccAlloydbInstance_alloydbInstanceBasicExample(t *testing.T) {
4242
ResourceName: "google_alloydb_instance.default",
4343
ImportState: true,
4444
ImportStateVerify: true,
45-
ImportStateVerifyIgnore: []string{"cluster", "instance_id", "reconciling", "update_time"},
45+
ImportStateVerifyIgnore: []string{"display_name", "cluster", "instance_id", "reconciling", "update_time"},
4646
},
4747
},
4848
})

0 commit comments

Comments
 (0)