google_dataflow_job - retry on common API errors when waiting for job to update (#3612) (#2146)

modular-magician · web-flow · commit 0c7a289d649d · 2020-06-08T15:37:57.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/3612.txt b/.changelog/3612.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+dataflow: added retries in `google_dataflow_job` for common retryable API errors when waiting for job to update
+```
diff --git a/google-beta/resource_dataflow_job.go b/google-beta/resource_dataflow_job.go
@@ -522,6 +522,9 @@ func waitForDataflowJobToBeUpdated(d *schema.ResourceData, config *Config, repla
 
 		replacementJob, err := resourceDataflowJobGetJob(config, project, region, replacementJobID)
 		if err != nil {
+			if isRetryableError(err) {
+				return resource.RetryableError(err)
+			}
 			return resource.NonRetryableError(err)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+dataflow: added retries in `google_dataflow_job` for common retryable API errors when waiting for job to update
	`3`	+```
Original file line number	Diff line number	Diff line change
`@@ -522,6 +522,9 @@ func waitForDataflowJobToBeUpdated(d schema.ResourceData, config Config, repla`
`522`	`522`
`523`	`523`	`replacementJob, err := resourceDataflowJobGetJob(config, project, region, replacementJobID)`
`524`	`524`	`if err != nil {`
	`525`	`+ if isRetryableError(err) {`
	`526`	`+ return resource.RetryableError(err)`
	`527`	`+ }`
`525`	`528`	`return resource.NonRetryableError(err)`
`526`	`529`	`}`
`527`	`530`