Skip to content

Commit 1749df9

Browse files
Remove duplicated function memory parameter (#9843) (#6894)
* Update firebaseextensions example * Formatting fix [upstream:76fe6896fb2b1cb218d6de00c8a9f956b2da6de9] Signed-off-by: Modular Magician <[email protected]>
1 parent 85dd3f9 commit 1749df9

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

.changelog/9843.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
```release-note:none
2+
```

google-beta/services/firebaseextensions/resource_firebase_extensions_instance.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ emit, identified by their types.`,
9999
Optional: true,
100100
Description: `Params whose values are only available at deployment time.
101101
Unlike other params, these will not be set as environment variables on
102-
functions.`,
102+
functions. See a full list of system parameters at
103+
https://firebase.google.com/docs/extensions/publishers/parameters#system_parameters`,
103104
Elem: &schema.Schema{Type: schema.TypeString},
104105
},
105106
"create_time": {

google-beta/services/firebaseextensions/resource_firebase_extensions_instance_generated_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
7777
instance_id = "tf-test-storage-resize-images%{random_suffix}"
7878
config {
7979
extension_ref = "firebase/storage-resize-images"
80-
extension_version = "0.1.37"
80+
extension_version = "0.2.2"
8181
8282
# The following params apply to the firebase/storage-resize-images extension.
8383
# Different extensions may have different params
@@ -90,18 +90,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
9090
DO_BACKFILL = false
9191
IMG_SIZES = "200x200"
9292
IMG_BUCKET = google_storage_bucket.images.name
93-
LOCATION = "%{location}"
9493
}
9594
9695
system_params = {
96+
"firebaseextensions.v1beta.function/location" = "%{location}"
9797
"firebaseextensions.v1beta.function/maxInstances" = 3000
98-
"firebaseextensions.v1beta.function/memory" = 256
9998
"firebaseextensions.v1beta.function/minInstances" = 0
10099
"firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
101100
}
102101
103102
allowed_event_types = [
104-
"firebase.extensions.storage-resize-images.v1.complete"
103+
"firebase.extensions.storage-resize-images.v1.onCompletion"
105104
]
106105
107106
eventarc_channel = "projects/%{project_id}/locations/%{location}/channels/firebase"

google-beta/services/firebaseextensions/resource_firebase_extensions_instance_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
6666
instance_id = "tf-test-storage-resize-images%{random_suffix}"
6767
config {
6868
extension_ref = "firebase/storage-resize-images"
69-
extension_version = "0.1.37"
69+
extension_version = "0.2.2"
7070
7171
# The following params apply to the firebase/storage-resize-images extension.
7272
# Different extensions may have different params
@@ -79,18 +79,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
7979
DO_BACKFILL = false
8080
IMG_SIZES = "200x200"
8181
IMG_BUCKET = google_storage_bucket.images.name
82-
LOCATION = "%{location}"
8382
}
8483
8584
system_params = {
85+
"firebaseextensions.v1beta.function/location" = "%{location}"
8686
"firebaseextensions.v1beta.function/maxInstances" = 3000
87-
"firebaseextensions.v1beta.function/memory" = 256
8887
"firebaseextensions.v1beta.function/minInstances" = 0
8988
"firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
9089
}
9190
9291
allowed_event_types = [
93-
"firebase.extensions.storage-resize-images.v1.complete"
92+
"firebase.extensions.storage-resize-images.v1.onCompletion"
9493
]
9594
9695
eventarc_channel = "projects/%{project_id}/locations/%{location}/channels/firebase"
@@ -118,7 +117,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
118117
instance_id = "tf-test-storage-resize-images%{random_suffix}"
119118
config {
120119
extension_ref = "firebase/storage-resize-images"
121-
extension_version = "0.1.37"
120+
extension_version = "0.2.2"
122121
123122
# The following params apply to the firebase/storage-resize-images extension.
124123
# Different extensions may have different params
@@ -132,13 +131,12 @@ resource "google_firebase_extensions_instance" "resize_image" {
132131
DO_BACKFILL = true
133132
IMG_SIZES = "400x400"
134133
IMG_BUCKET = google_storage_bucket.images.name
135-
LOCATION = "%{location}"
136134
}
137135
138136
system_params = {
137+
"firebaseextensions.v1beta.function/location" = "%{location}"
139138
# Changed params
140139
"firebaseextensions.v1beta.function/maxInstances" = 100
141-
"firebaseextensions.v1beta.function/memory" = 128
142140
"firebaseextensions.v1beta.function/minInstances" = 0
143141
"firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
144142
}

website/docs/r/firebase_extensions_instance.html.markdown

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ resource "google_firebase_extensions_instance" "resize_image" {
5050
instance_id = "storage-resize-images"
5151
config {
5252
extension_ref = "firebase/storage-resize-images"
53-
extension_version = "0.1.37"
53+
extension_version = "0.2.2"
5454
5555
# The following params apply to the firebase/storage-resize-images extension.
5656
# Different extensions may have different params
@@ -63,18 +63,17 @@ resource "google_firebase_extensions_instance" "resize_image" {
6363
DO_BACKFILL = false
6464
IMG_SIZES = "200x200"
6565
IMG_BUCKET = google_storage_bucket.images.name
66-
LOCATION = ""
6766
}
6867
6968
system_params = {
69+
"firebaseextensions.v1beta.function/location" = ""
7070
"firebaseextensions.v1beta.function/maxInstances" = 3000
71-
"firebaseextensions.v1beta.function/memory" = 256
7271
"firebaseextensions.v1beta.function/minInstances" = 0
7372
"firebaseextensions.v1beta.function/vpcConnectorEgressSettings" = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED"
7473
}
7574
7675
allowed_event_types = [
77-
"firebase.extensions.storage-resize-images.v1.complete"
76+
"firebase.extensions.storage-resize-images.v1.onCompletion"
7877
]
7978
8079
eventarc_channel = "projects/my-project-name/locations//channels/firebase"
@@ -116,7 +115,8 @@ The following arguments are supported:
116115
(Optional)
117116
Params whose values are only available at deployment time.
118117
Unlike other params, these will not be set as environment variables on
119-
functions.
118+
functions. See a full list of system parameters at
119+
https://firebase.google.com/docs/extensions/publishers/parameters#system_parameters
120120

121121
* `extension_ref` -
122122
(Required)

0 commit comments

Comments
 (0)