remove random provider when not needed (#4663) (#3127)

modular-magician · web-flow · commit 217cf8662e9b · 2021-04-06T09:12:36.000-07:00
Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/.changelog/4663.txt b/.changelog/4663.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/resource_access_context_manager_gcp_user_access_binding_test.go b/google-beta/resource_access_context_manager_gcp_user_access_binding_test.go
@@ -23,11 +23,8 @@ func testAccAccessContextManagerGcpUserAccessBinding_basicTest(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckAccessContextManagerGcpUserAccessBindingDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_api_gateway_api_config_test.go b/google-beta/resource_api_gateway_api_config_test.go
@@ -14,11 +14,8 @@ func TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated(t *testin
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckApiGatewayApiConfigDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -41,11 +38,8 @@ func TestAccApiGatewayApiConfig_generatedPrefix(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckApiGatewayApiConfigDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_api_gateway_api_test.go b/google-beta/resource_api_gateway_api_test.go
@@ -14,11 +14,8 @@ func TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckApiGatewayApiDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_api_gateway_gateway_test.go b/google-beta/resource_api_gateway_gateway_test.go
@@ -14,11 +14,8 @@ func TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated(t *testing.T)
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckApiGatewayGatewayDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_big_query_routine_test.go b/google-beta/resource_big_query_routine_test.go
@@ -14,11 +14,8 @@ func TestAccBigQueryRoutine_bigQueryRoutine_Update(t *testing.T) {
 	routine := fmt.Sprintf("tfmanualroutine%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckBigQueryRoutineDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_bigquery_connection_connection_generated_test.go b/google-beta/resource_bigquery_connection_connection_generated_test.go
@@ -33,11 +33,8 @@ func TestAccBigqueryConnectionConnection_bigqueryConnectionBasicExample(t *testi
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckBigqueryConnectionConnectionDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -106,11 +103,8 @@ func TestAccBigqueryConnectionConnection_bigqueryConnectionFullExample(t *testin
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckBigqueryConnectionConnectionDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_bigquery_job_test.go b/google-beta/resource_bigquery_job_test.go
@@ -21,9 +21,6 @@ func TestAccBigQueryJob_withLocation(t *testing.T) {
 	vcrTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccBigQueryJob_withLocation(context),
diff --git a/google-beta/resource_billing_budget_test.go b/google-beta/resource_billing_budget_test.go
@@ -15,11 +15,8 @@ func TestAccBillingBudget_billingBudgetCurrencycode(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckBillingBudgetDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_cloud_identity_group_membership_test.go b/google-beta/resource_cloud_identity_group_membership_test.go
@@ -16,11 +16,8 @@ func TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipWithMemberK
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudIdentityGroupMembershipDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -91,11 +88,8 @@ func TestAccCloudIdentityGroupMembership_cloudIdentityGroupMembershipUserWithMem
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudIdentityGroupMembershipDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_cloud_run_domain_mapping_test.go b/google-beta/resource_cloud_run_domain_mapping_test.go
@@ -16,11 +16,8 @@ func TestAccCloudRunDomainMapping_foregroundDeletion(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckCloudRunDomainMappingDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_compute_managed_ssl_certificate_generated_test.go b/google-beta/resource_compute_managed_ssl_certificate_generated_test.go
@@ -134,11 +134,8 @@ func TestAccComputeManagedSslCertificate_managedSslCertificateRecreationExample(
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckComputeManagedSslCertificateDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_compute_region_ssl_certificate_generated_test.go b/google-beta/resource_compute_region_ssl_certificate_generated_test.go
@@ -77,11 +77,8 @@ func TestAccComputeRegionSslCertificate_regionSslCertificateRandomProviderExampl
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckComputeRegionSslCertificateDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_compute_ssl_certificate_generated_test.go b/google-beta/resource_compute_ssl_certificate_generated_test.go
@@ -76,11 +76,8 @@ func TestAccComputeSslCertificate_sslCertificateRandomProviderExample(t *testing
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckComputeSslCertificateDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_dataflow_flex_template_job_test.go b/google-beta/resource_dataflow_flex_template_job_test.go
@@ -8,7 +8,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
-	compute "google.golang.org/api/compute/v1"
+	"google.golang.org/api/compute/v1"
 )
 
 func TestAccDataflowFlexTemplateJob_basic(t *testing.T) {
diff --git a/google-beta/resource_dns_managed_zone_generated_test.go b/google-beta/resource_dns_managed_zone_generated_test.go
@@ -32,11 +32,8 @@ func TestAccDNSManagedZone_dnsManagedZoneBasicExample(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckDNSManagedZoneDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_endpoints_service_test.go b/google-beta/resource_endpoints_service_test.go
@@ -21,9 +21,6 @@ func TestAccEndpointsService_basic(t *testing.T) {
 		PreCheck:     func() { testAccPreCheck(t) },
 		CheckDestroy: testAccCheckEndpointServiceDestroyProducer(t),
 		Providers:    testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccEndpointsService_basic(serviceId, getTestProjectFromEnv(), "1"),
diff --git a/google-beta/resource_eventarc_trigger_test.go b/google-beta/resource_eventarc_trigger_test.go
@@ -23,9 +23,6 @@ func TestAccEventarcTrigger_basic(t *testing.T) {
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProvidersOiCS,
 		CheckDestroy: funcAccTestEventarcTriggerCheckDestroy(t),
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
 		Steps: []resource.TestStep{
 			{
 				Config: testAccEventarcTrigger_basic(context),
diff --git a/google-beta/resource_os_login_ssh_public_key_test.go b/google-beta/resource_os_login_ssh_public_key_test.go
@@ -21,8 +21,7 @@ func TestAccOSLoginSSHPublicKey_osLoginSshKeyExpiry(t *testing.T) {
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-			"time":   {},
+			"time": {},
 		},
 		CheckDestroy: testAccCheckOSLoginSSHPublicKeyDestroyProducer(t),
 		Steps: []resource.TestStep{
diff --git a/google-beta/resource_redis_instance_test.go b/google-beta/resource_redis_instance_test.go
@@ -77,11 +77,8 @@ func TestAccRedisInstance_redisInstanceAuthEnabled(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckRedisInstanceDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -143,8 +140,7 @@ resource "google_redis_instance" "test" {
     maxmemory-policy       = "noeviction"
     notify-keyspace-events = ""
   }
-    
-  transit_encryption_mode = "SERVER_AUTHENTICATION"
+    transit_encryption_mode = "SERVER_AUTHENTICATION"
   }
 `, name)
 }
diff --git a/google-beta/resource_spanner_database_test.go b/google-beta/resource_spanner_database_test.go
@@ -215,11 +215,8 @@ func TestAccSpannerDatabase_deletionProtection(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProviders,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckSpannerDatabaseDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
diff --git a/google-beta/resource_tags_test.go b/google-beta/resource_tags_test.go
@@ -46,11 +46,8 @@ func testAccTagsTagKey_tagKeyBasic(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckTagsTagKeyDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -79,11 +76,8 @@ func testAccTagsTagKey_tagKeyUpdate(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckTagsTagKeyDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -170,11 +164,8 @@ func testAccTagsTagValue_tagValueBasic(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckTagsTagValueDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
@@ -211,11 +202,8 @@ func testAccTagsTagValue_tagValueUpdate(t *testing.T) {
 	}
 
 	vcrTest(t, resource.TestCase{
-		PreCheck:  func() { testAccPreCheck(t) },
-		Providers: testAccProvidersOiCS,
-		ExternalProviders: map[string]resource.ExternalProvider{
-			"random": {},
-		},
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProvidersOiCS,
 		CheckDestroy: testAccCheckTagsTagValueDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,8 @@ func testAccAccessContextManagerGcpUserAccessBinding_basicTest(t *testing.T) {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`vcrTest(t, resource.TestCase{`
`26`		`- PreCheck: func() { testAccPreCheck(t) },`
`27`		`- Providers: testAccProviders,`
`28`		`- ExternalProviders: map[string]resource.ExternalProvider{`
`29`		`- "random": {},`
`30`		`- },`
	`26`	`+ PreCheck: func() { testAccPreCheck(t) },`
	`27`	`+ Providers: testAccProviders,`
`31`	`28`	`CheckDestroy: testAccCheckAccessContextManagerGcpUserAccessBindingDestroyProducer(t),`
`32`	`29`	`Steps: []resource.TestStep{`
`33`	`30`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,11 +14,8 @@ func TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated(t *testing.T) {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`vcrTest(t, resource.TestCase{`
`17`		`- PreCheck: func() { testAccPreCheck(t) },`
`18`		`- Providers: testAccProvidersOiCS,`
`19`		`- ExternalProviders: map[string]resource.ExternalProvider{`
`20`		`- "random": {},`
`21`		`- },`
	`17`	`+ PreCheck: func() { testAccPreCheck(t) },`
	`18`	`+ Providers: testAccProvidersOiCS,`
`22`	`19`	`CheckDestroy: testAccCheckApiGatewayApiDestroyProducer(t),`
`23`	`20`	`Steps: []resource.TestStep{`
`24`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,8 @@ func TestAccBillingBudget_billingBudgetCurrencycode(t *testing.T) {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`vcrTest(t, resource.TestCase{`
`18`		`- PreCheck: func() { testAccPreCheck(t) },`
`19`		`- Providers: testAccProviders,`
`20`		`- ExternalProviders: map[string]resource.ExternalProvider{`
`21`		`- "random": {},`
`22`		`- },`
	`18`	`+ PreCheck: func() { testAccPreCheck(t) },`
	`19`	`+ Providers: testAccProviders,`
`23`	`20`	`CheckDestroy: testAccCheckBillingBudgetDestroyProducer(t),`
`24`	`21`	`Steps: []resource.TestStep{`
`25`	`22`	`{`