Skip to content

Commit 2353b2f

Browse files
Update examples to use LOOKER_CORE_STANDARD_ANNUAL edition (#10325) (#7179)
[upstream:09ade7e2a6326df0431ac2aeb4a80d151ca87a85] Signed-off-by: Modular Magician <[email protected]>
1 parent 8fa3a74 commit 2353b2f

File tree

4 files changed

+16
-22
lines changed

4 files changed

+16
-22
lines changed

.changelog/10325.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
```release-note:none
2+
```

google-beta/services/looker/resource_looker_instance.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,8 @@ disrupt service.`,
335335
ForceNew: true,
336336
ValidateFunc: verify.ValidateEnum([]string{"LOOKER_CORE_TRIAL", "LOOKER_CORE_STANDARD", "LOOKER_CORE_STANDARD_ANNUAL", "LOOKER_CORE_ENTERPRISE_ANNUAL", "LOOKER_CORE_EMBED_ANNUAL", ""}),
337337
Description: `Platform editions for a Looker instance. Each edition maps to a set of instance features, like its size. Must be one of these values:
338-
- LOOKER_CORE_TRIAL: trial instance
339-
- LOOKER_CORE_STANDARD: pay as you go standard instance
338+
- LOOKER_CORE_TRIAL: trial instance (Currently Unavailable)
339+
- LOOKER_CORE_STANDARD: pay as you go standard instance (Currently Unavailable)
340340
- LOOKER_CORE_STANDARD_ANNUAL: subscription standard instance
341341
- LOOKER_CORE_ENTERPRISE_ANNUAL: subscription enterprise instance
342342
- LOOKER_CORE_EMBED_ANNUAL: subscription embed instance Default value: "LOOKER_CORE_TRIAL" Possible values: ["LOOKER_CORE_TRIAL", "LOOKER_CORE_STANDARD", "LOOKER_CORE_STANDARD_ANNUAL", "LOOKER_CORE_ENTERPRISE_ANNUAL", "LOOKER_CORE_EMBED_ANNUAL"]`,

google-beta/services/looker/resource_looker_instance_generated_test.go

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func testAccLookerInstance_lookerInstanceBasicExample(context map[string]interfa
5959
return acctest.Nprintf(`
6060
resource "google_looker_instance" "looker-instance" {
6161
name = "tf-test-my-instance%{random_suffix}"
62-
platform_edition = "LOOKER_CORE_STANDARD"
62+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
6363
region = "us-central1"
6464
oauth_config {
6565
client_id = "tf-test-my-client-id%{random_suffix}"
@@ -98,18 +98,12 @@ func testAccLookerInstance_lookerInstanceFullExample(context map[string]interfac
9898
return acctest.Nprintf(`
9999
resource "google_looker_instance" "looker-instance" {
100100
name = "tf-test-my-instance%{random_suffix}"
101-
platform_edition = "LOOKER_CORE_STANDARD"
101+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
102102
region = "us-central1"
103103
public_ip_enabled = true
104104
admin_settings {
105105
allowed_email_domains = ["google.com"]
106106
}
107-
// User metadata config is only available when platform edition is LOOKER_CORE_STANDARD.
108-
user_metadata {
109-
additional_developer_user_count = 10
110-
additional_standard_user_count = 10
111-
additional_viewer_user_count = 10
112-
}
113107
maintenance_window {
114108
day_of_week = "THURSDAY"
115109
start_time {
@@ -269,12 +263,14 @@ func testAccLookerInstance_lookerInstanceCustomDomainExample(context map[string]
269263
return acctest.Nprintf(`
270264
resource "google_looker_instance" "looker-instance" {
271265
name = "tf-test-my-instance%{random_suffix}"
272-
platform_edition = "LOOKER_CORE_STANDARD"
266+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
273267
region = "us-central1"
274268
oauth_config {
275269
client_id = "tf-test-my-client-id%{random_suffix}"
276270
client_secret = "tf-test-my-client-secret%{random_suffix}"
277271
}
272+
// After your Looker (Google Cloud core) instance has been created, you can set up, view information about, or delete a custom domain for your instance.
273+
// Therefore 2 terraform applies, one to create the instance, then another to set up the custom domain.
278274
custom_domain {
279275
domain = "tf-test-my-custom-domain%{random_suffix}.com"
280276
}

website/docs/r/looker_instance.html.markdown

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ To get more information about Instance, see:
4040
```hcl
4141
resource "google_looker_instance" "looker-instance" {
4242
name = "my-instance"
43-
platform_edition = "LOOKER_CORE_STANDARD"
43+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
4444
region = "us-central1"
4545
oauth_config {
4646
client_id = "my-client-id"
@@ -59,18 +59,12 @@ resource "google_looker_instance" "looker-instance" {
5959
```hcl
6060
resource "google_looker_instance" "looker-instance" {
6161
name = "my-instance"
62-
platform_edition = "LOOKER_CORE_STANDARD"
62+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
6363
region = "us-central1"
6464
public_ip_enabled = true
6565
admin_settings {
6666
allowed_email_domains = ["google.com"]
6767
}
68-
// User metadata config is only available when platform edition is LOOKER_CORE_STANDARD.
69-
user_metadata {
70-
additional_developer_user_count = 10
71-
additional_standard_user_count = 10
72-
additional_viewer_user_count = 10
73-
}
7468
maintenance_window {
7569
day_of_week = "THURSDAY"
7670
start_time {
@@ -195,12 +189,14 @@ resource "google_kms_crypto_key_iam_member" "crypto_key" {
195189
```hcl
196190
resource "google_looker_instance" "looker-instance" {
197191
name = "my-instance"
198-
platform_edition = "LOOKER_CORE_STANDARD"
192+
platform_edition = "LOOKER_CORE_STANDARD_ANNUAL"
199193
region = "us-central1"
200194
oauth_config {
201195
client_id = "my-client-id"
202196
client_secret = "my-client-secret"
203197
}
198+
// After your Looker (Google Cloud core) instance has been created, you can set up, view information about, or delete a custom domain for your instance.
199+
// Therefore 2 terraform applies, one to create the instance, then another to set up the custom domain.
204200
custom_domain {
205201
domain = "my-custom-domain.com"
206202
}
@@ -259,8 +255,8 @@ The following arguments are supported:
259255
* `platform_edition` -
260256
(Optional)
261257
Platform editions for a Looker instance. Each edition maps to a set of instance features, like its size. Must be one of these values:
262-
- LOOKER_CORE_TRIAL: trial instance
263-
- LOOKER_CORE_STANDARD: pay as you go standard instance
258+
- LOOKER_CORE_TRIAL: trial instance (Currently Unavailable)
259+
- LOOKER_CORE_STANDARD: pay as you go standard instance (Currently Unavailable)
264260
- LOOKER_CORE_STANDARD_ANNUAL: subscription standard instance
265261
- LOOKER_CORE_ENTERPRISE_ANNUAL: subscription enterprise instance
266262
- LOOKER_CORE_EMBED_ANNUAL: subscription embed instance

0 commit comments

Comments
 (0)