Skip to content

Commit 2b8b220

Browse files
Added support for request-based SLIs in monitoring SLO (#3491) (#2058)
* initial slo resource * whitespace and update mask * add exactly X of to slo descriptions * unit tests Signed-off-by: Modular Magician <[email protected]>
1 parent aba1159 commit 2b8b220

File tree

7 files changed

+760
-15
lines changed

7 files changed

+760
-15
lines changed

.changelog/3491.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
monitoring: Added `request_based` SLI support to `google_monitoring_slo`
3+
```

google-beta/resource_app_engine_domain_mapping.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,8 @@ func resourceAppEngineDomainMappingUpdate(d *schema.ResourceData, meta interface
293293
updateMask := []string{}
294294

295295
if d.HasChange("ssl_settings") {
296-
updateMask = append(updateMask, "ssl_settings.certificate_id,ssl_settings.ssl_management_type")
296+
updateMask = append(updateMask, "ssl_settings.certificate_id",
297+
"ssl_settings.ssl_management_type")
297298
}
298299
// updateMask is a URL parameter but not present in the schema, so replaceVars
299300
// won't set it

google-beta/resource_kms_crypto_key.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,8 @@ func resourceKMSCryptoKeyUpdate(d *schema.ResourceData, meta interface{}) error
272272
}
273273

274274
if d.HasChange("rotation_period") {
275-
updateMask = append(updateMask, "rotationPeriod,nextRotationTime")
275+
updateMask = append(updateMask, "rotationPeriod",
276+
"nextRotationTime")
276277
}
277278

278279
if d.HasChange("version_template") {

0 commit comments

Comments
 (0)