Update Cloud Workstations resources in the beta provider. (#7629) (#5585)

* Update mutability of fields in Cloud Workstations resources.

* Revert WorkstationsConfig persistent directories fields to be default_from_api.

* Revert and mark breaking changes for Cloud Workstations resources.

* Update display name for Cloud Workstation.

* Revert default_from_api on fields not sent by API if not changed.

* Add an update test for Cloud Workstations host field.

* Add more update tests to include all recently changed fields.

* Revert addition of idle and running timeout fields.

* Fix config tests for newly mutable attributes.

* Use default value instead of sending empty for advanced host options.

* Send empty values for special nested objects, configure diff suppress when empty.

* Add custom flatteners for instance configs.

* Add default_from_ap to ssubfields where custom flatteners are used.

* Send default_from_api on entire config block instead of fields.

* Fix formatting for attributes not caught by rebase.

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/7629.txt

@@ -0,0 +1,9 @@
+```release-note:enhancement
+workstations: supported in-place update for `host` and `container` in `google_workstations_workstation_config` (beta)
+```
+```release-note:bug
+workstations: fixed an issue where unsetting the container working directory in `google_workstations_workstations_config` was not propagated to the underlying resource (beta)
+```
+```release-note:bug
+workstations: fixed an issue where modifying `persistent_directories` and `encryption_key` would fail with API errors; now updating them will recreate the resource (beta)
+```

google-beta/iam_workstations_workstation_config_generated_test.go

@@ -155,7 +155,7 @@ resource "google_workstations_workstation_config" "default" {
   workstation_config_id  = "tf-test-workstation-config%{random_suffix}"
   workstation_cluster_id = google_workstations_workstation_cluster.default.workstation_cluster_id
   location   		         = "us-central1"
-  
+
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -214,7 +214,7 @@ resource "google_workstations_workstation_config" "default" {
   workstation_config_id  = "tf-test-workstation-config%{random_suffix}"
   workstation_cluster_id = google_workstations_workstation_cluster.default.workstation_cluster_id
   location   		         = "us-central1"
-  
+
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -280,7 +280,7 @@ resource "google_workstations_workstation_config" "default" {
   workstation_config_id  = "tf-test-workstation-config%{random_suffix}"
   workstation_cluster_id = google_workstations_workstation_cluster.default.workstation_cluster_id
   location   		         = "us-central1"
-  
+
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -342,7 +342,7 @@ resource "google_workstations_workstation_config" "default" {
   workstation_config_id  = "tf-test-workstation-config%{random_suffix}"
   workstation_cluster_id = google_workstations_workstation_cluster.default.workstation_cluster_id
   location   		         = "us-central1"
-  
+
   host {
     gce_instance {
       machine_type                = "e2-standard-4"
@@ -401,7 +401,7 @@ resource "google_workstations_workstation_config" "default" {
   workstation_config_id  = "tf-test-workstation-config%{random_suffix}"
   workstation_cluster_id = google_workstations_workstation_cluster.default.workstation_cluster_id
   location   		         = "us-central1"
-  
+
   host {
     gce_instance {
       machine_type                = "e2-standard-4"

google-beta/resource_workstations_workstation.go

@@ -47,19 +47,19 @@ func ResourceWorkstationsWorkstation() *schema.Resource {
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
-				Description: `The location where the workstation cluster config should reside.`,
+				Description: `The location where the workstation parent resources reside.`,
 			},
 			"workstation_cluster_id": {
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
-				Description: `The name of the workstation cluster.`,
+				Description: `The ID of the parent workstation cluster.`,
 			},
 			"workstation_config_id": {
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
-				Description: `The ID of the workstation cluster config.`,
+				Description: `The ID of the parent workstation cluster config.`,
 			},
 			"workstation_id": {
 				Type:        schema.TypeString,
@@ -87,7 +87,7 @@ func ResourceWorkstationsWorkstation() *schema.Resource {
 			"create_time": {
 				Type:        schema.TypeString,
 				Computed:    true,
-				Description: `Time the Instance was created in UTC.`,
+				Description: `Time when this resource was created.`,
 			},
 			"host": {
 				Type:     schema.TypeString,
@@ -99,7 +99,7 @@ To send traffic to a different port, clients may prefix the host with the destin
 			"name": {
 				Type:        schema.TypeString,
 				Computed:    true,
-				Description: `The name of the cluster resource.`,
+				Description: `Full name of this resource.`,
 			},
 			"state": {
 				Type:        schema.TypeString,
@@ -109,7 +109,7 @@ To send traffic to a different port, clients may prefix the host with the destin
 			"uid": {
 				Type:        schema.TypeString,
 				Computed:    true,
-				Description: `The system-generated UID of the resource.`,
+				Description: `A system-assigned unique identified for this resource.`,
 			},
 			"project": {
 				Type:     schema.TypeString,

google-beta/resource_workstations_workstation_cluster.go

@@ -61,7 +61,7 @@ Must be part of the subnetwork specified for this cluster.`,
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
-				Description: `The ID of the workstation cluster.`,
+				Description: `ID to use for the workstation cluster.`,
 			},
 			"annotations": {
 				Type:        schema.TypeMap,
@@ -110,7 +110,7 @@ To access workstations in the cluster, create a new DNS zone mapping this domain
 							Type:     schema.TypeString,
 							Computed: true,
 							Description: `Service attachment URI for the workstation cluster.
-The service attachemnt is created when private endpoint is enabled.
+The service attachment is created when private endpoint is enabled.
 To access workstations in the cluster, configure access to the managed service using (Private Service Connect)[https://cloud.google.com/vpc/docs/configure-private-service-connect-services].`,
 						},
 					},
@@ -146,7 +146,7 @@ To access workstations in the cluster, configure access to the managed service u
 			"create_time": {
 				Type:        schema.TypeString,
 				Computed:    true,
-				Description: `Time the Instance was created in UTC.`,
+				Description: `Time when this resource was created.`,
 			},
 			"degraded": {
 				Type:     schema.TypeBool,